January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Rely on engine entities
by masayag＠redhat.com 07 Jan '14

07 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Rely on engine entities ...................................................................... engine: Rely on engine entities The attach/detach networks to/from clusters commands rely on entities provided by the clients, although the entity could have other values than in the engine db. In order to avoid such a discrepancy, the networks are being retrieved internally. Change-Id: I62f05855c09e5fdee862d18dcce59c343baeafa9 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java 2 files changed, 18 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62f05855c09e5fdee862d18dcce59c343baeafa9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Refactor setup networks parameters builders
by masayag＠redhat.com 07 Jan '14

07 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Refactor setup networks parameters builders ...................................................................... engine: Refactor setup networks parameters builders Shared code is being extracted into the base class. Change-Id: Id3e7dcc5ec5fc2a4f38e3b4bd48eec32e2573f70 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java 3 files changed, 43 insertions(+), 45 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3e7dcc5ec5fc2a4f38e3b4bd48eec32e2573f70 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use proper getter
by masayag＠redhat.com 07 Jan '14

07 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use proper getter ...................................................................... engine: Use proper getter Change-Id: I8ee0d357bf0cdbeee9b6362f6bc021af6f735f72 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnlabelNicCommand.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ee0d357bf0cdbeee9b6362f6bc021af6f735f72 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: Don't add parameters with null values
by juan.hernandez＠redhat.com 07 Jan '14

07 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Don't add parameters with null values ...................................................................... sdk: Don't add parameters with null values Currently the methods that receive header or URL parameters add them to the request even if the value is null. This patch changes those methods to not add the header or URL parameter in this case. Change-Id: Ifabf318632e57302727683d78355f1805b48b6af Bug-Url: https://bugzilla.redhat.com/1047638 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Cluster.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterHook.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolume.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBrick.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBrickStatistics.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBricks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumes.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterNetwork.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterNetworks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Clusters.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenter.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterCluster.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterHook.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolume.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBrick.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBricks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumes.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetwork.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetworks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusters.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterNetwork.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterNetworkPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterNetworkPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterNetworkVnicProfile.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterNetworkVnicProfilePermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterNetworkVnicProfilePermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterNetworkVnicProfiles.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterNetworks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomain.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDisk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDiskPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDiskPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomains.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenters.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Disk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskStatistics.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Disks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DomainGroups.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DomainUsers.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Domains.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Event.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Events.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Group.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRole.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRolePermit.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRolePermits.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRoles.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupTag.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupTags.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Groups.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNIC.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNICStatistics.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNICs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostStatistics.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostTag.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostTags.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Hosts.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Job.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/JobStep.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/JobStepStatistics.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/JobSteps.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Jobs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Network.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/NetworkPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/NetworkPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/NetworkVnicProfile.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/NetworkVnicProfilePermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/NetworkVnicProfilePermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/NetworkVnicProfiles.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Networks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Permission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Permissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Role.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/RolePermit.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/RolePermits.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Roles.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageConnection.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageConnections.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomain.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDisk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDiskPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDiskPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainFiles.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainImages.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainStorageConnection.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainStorageConnections.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplate.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplates.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVM.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVMs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomains.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Tag.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Tags.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateCdRoms.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateDisk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateNIC.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateNICs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplatePermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplatePermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateWatchDog.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateWatchDogs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Templates.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/User.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRole.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRolePermit.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRolePermits.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRoles.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserTag.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserTags.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Users.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMCdRom.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMCdRoms.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDiskPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDiskPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNIC.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshot.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshots.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMStatistics.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMTag.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMTags.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMWatchDog.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMWatchDogs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPool.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPoolPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPoolPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPools.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VnicProfile.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VnicProfilePermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VnicProfilePermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VnicProfiles.java 158 files changed, 3,341 insertions(+), 2,463 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifabf318632e57302727683d78355f1805b48b6af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: Don't add parameters with null values
by juan.hernandez＠redhat.com 07 Jan '14

07 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Don't add parameters with null values ...................................................................... codegen: Don't add parameters with null values Currently the methods that receive header or URL parameters add them to the request even if the value is null. This patch changes those methods to not add the header or URL parameter in this case. Change-Id: I6d8b8936f219db148cff9de2825773908a289f92 Bug-Url: https://bugzilla.redhat.com/1047638 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionActionMethodTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionAddMethodTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionListMethodTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/DeleteMethodTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/DeleteMethodWithBodyTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/HeaderBuilderParameterTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ResourceActionMethodTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/SubCollectionAddMethodTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/SubCollectionListMethodTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/UpdateMethodTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/UrlBuilderParameterTemplate 11 files changed, 42 insertions(+), 38 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d8b8936f219db148cff9de2825773908a289f92 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: Regenerate from the latest master
by juan.hernandez＠redhat.com 07 Jan '14

07 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate from the latest master ...................................................................... sdk: Regenerate from the latest master This regenerates the SDK from the XML schema and the RSDL documents obtained from the latest build of the engine (git hash e992aa). Change-Id: I05de53959eb2730d6180bb10f2e86d0012359f13 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/Api.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Cluster.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Clusters.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterCluster.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusters.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPool.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPools.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Cluster.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Display.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Payload.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VmPool.java 11 files changed, 128 insertions(+), 23 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05de53959eb2730d6180bb10f2e86d0012359f13 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: Don't require the SDK
by juan.hernandez＠redhat.com 07 Jan '14

07 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Don't require the SDK ...................................................................... codegen: Don't require the SDK Currently the code generator uses some utility classes and some entity classes from the SDK. This introduces a chicken-egg situation, and it makes difficult to regenerate the SDK from scratch. This patch copies the required utility methods from the SDK to the generator, and creates the entity classes from the XML schema before compiling the generator. This removes the dependency on the SDK. Change-Id: I32815467bdd91124daa71c0de377809baa0be718 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/pom.xml M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/common/IDocCodegen.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/documentation/DocsGen.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/holders/ResourceHolder.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/ApiCodegen.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/AbstractOverloadableTemplate.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/DeleteMethodTemplate.java A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/ArrayUtils.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/FormatUtils.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/StringUtils.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/UrlUtils.java 12 files changed, 121 insertions(+), 32 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32815467bdd91124daa71c0de377809baa0be718 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: Use Maven to generate code
by juan.hernandez＠redhat.com 07 Jan '14

07 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Use Maven to generate code ...................................................................... codegen: Use Maven to generate code Currently the code generator has to be executed as a Java class with a script or from an IDE. This patch adds a Maven profile that executes the generator using the exec plugin, so that it can be executed with the following command: mvn validate -Pupdate-code Once the generated code is updated the developer is resposible from adding it to the source code repository. Change-Id: I2b3472ed3009aa6acc2500d49e26628660764aaf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/pom.xml 1 file changed, 39 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b3472ed3009aa6acc2500d49e26628660764aaf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: Use XSD instead of classpath scanning
by juan.hernandez＠redhat.com 07 Jan '14

07 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Use XSD instead of classpath scanning ...................................................................... codegen: Use XSD instead of classpath scanning Currently the code generator scans the classpath to find the set of entity classes generated by the xjc compiler. This means that the generation has to be done in several steps: first generate the entities, then compile the result, then generate the decorators and the entry point, then compile again. These steps are currently managed by the generator itself, which calls Maven to do the intermediate compilation. To avoid this issue this patch changes the generator so that it extracts the set of entity classes from the XSD, using XSOM to parse it. Change-Id: Ia9c7146b477d421ad296cef376cef7c08d051ad8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/pom.xml M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/common/AbstractCodegen.java D ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/compile/CodeCompiler.java D ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/compile/ICompiler.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/ApiCodegen.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java D ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/ReflectionHelper.java 8 files changed, 46 insertions(+), 296 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9c7146b477d421ad296cef376cef7c08d051ad8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: Add XML schema and RSDL from latest master
by juan.hernandez＠redhat.com 07 Jan '14

07 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Add XML schema and RSDL from latest master ...................................................................... codegen: Add XML schema and RSDL from latest master This patch adds the XML schema and RSDL documents obtained from the latest build of the engine, git hash e992aa. Change-Id: Ifbce798ec1bbe227b210c0bebdceff2553c2bfaf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/resources/api.rsdl M ovirt-engine-sdk-java-codegen/src/main/resources/api.xsd 2 files changed, 15,710 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbce798ec1bbe227b210c0bebdceff2553c2bfaf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0