January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Expand GetNetworkByIdQuery to a user query
by masayag＠redhat.com 04 Jan '14

04 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Expand GetNetworkByIdQuery to a user query ...................................................................... engine: Expand GetNetworkByIdQuery to a user query The query will be used for fetch a specific entity by the clients. Change-Id: Ia4bef895ede7416d1dce34561e7b6af63483b69c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetNetworkByIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java M packaging/dbscripts/network_sp.sql 5 files changed, 36 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4bef895ede7416d1dce34561e7b6af63483b69c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Update network on hosts when label is changed
by masayag＠redhat.com 04 Jan '14

04 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Update network on hosts when label is changed ...................................................................... engine: Update network on hosts when label is changed When the network's label is being modifies, the change to the label should be reflected to the labeled hosts. There supported options in this regards are: 1. Labeling a network - will add the network to any of labeled hosts which the network is assigned to their cluster. 2. Unlabeling a network - will remove the network from any of labeled hosts that the network is assigned to their cluster. 3. Label unchanged - only sync action will apply to hosts that the network is configured on. Changing an existing label while the label is set on interfaces will not be supported at this time. Change-Id: Id8b851d589db8ad6ef025d3b752c9596aa30aee2 Bug-Url: https://bugzilla.redhat.com/1040586 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 145 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/22772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8b851d589db8ad6ef025d3b752c9596aa30aee2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Selection of incompatible templates
by tjelinek＠redhat.com 03 Jan '14

03 Jan '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Selection of incompatible templates ...................................................................... webadmin: Selection of incompatible templates This change filters the displayed templates in the "New Pool" and "New VM" dialogs to show only the ones that are compatible with the selected cluster. Change-Id: I2acd521718c8c6d4c27ffce20628b8d096dc4f1a Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java 4 files changed, 39 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2acd521718c8c6d4c27ffce20628b8d096dc4f1a Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Fixing a bug in Alert logging.
by emesika＠redhat.com 03 Jan '14

03 Jan '14

Eli Mesika has submitted this change and it was merged. Change subject: Fixing a bug in Alert logging. ...................................................................... Fixing a bug in Alert logging. Log Alert when failing to get Host status via the PM agent was recorded to the database without the Host UUID, therefor the attempt to remove this Alert when the Host was fenced manually failed and a junk Alert remained in the database. This patch sets the Host id on the Alert log message. Change-Id: Iee997e6b3df37f411a74815757195dc584c4e8e5 Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1045139 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee997e6b3df37f411a74815757195dc584c4e8e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup:correct parameter for method inst_update_se...
by emesika＠redhat.com 03 Jan '14

03 Jan '14

Eli Mesika has submitted this change and it was merged. Change subject: packaging: setup:correct parameter for method inst_update_service_type ...................................................................... packaging: setup:correct parameter for method inst_update_service_type This patch sends correct cluster_id as a parameter for method inst_update_service_type instead of null. Because of this the service type for default cluster is properly updated during setup. Change-Id: I34bebf502b94f69701ec5b68bd5497ff68a4a143 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34bebf502b94f69701ec5b68bd5497ff68a4a143 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove network from hosts when detached from cluster
by masayag＠redhat.com 02 Jan '14

02 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove network from hosts when detached from cluster ...................................................................... engine: Remove network from hosts when detached from cluster When detaching a labeled network from a cluster, the label became ineffective in that cluster in regards to the detached network context. Therefore, the network should be removed from all labeled hosts. Change-Id: I513f5ce7332388ac44ddc1f05988f23d6531cb89 Bug-Url: https://bugzilla.redhat.com/1040586 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 134 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I513f5ce7332388ac44ddc1f05988f23d6531cb89 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extract getNetwork() method
by masayag＠redhat.com 02 Jan '14

02 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract getNetwork() method ...................................................................... engine: Extract getNetwork() method Too many repetitions of getParameters().getNetwork() Change-Id: I7c6257df48afa86673eda39499c53d7f09325365 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved Objections: oVirt Jenkins CI Server: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/22770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c6257df48afa86673eda39499c53d7f09325365 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Change DetachNetworkToVdsGroup to non-transactive
by masayag＠redhat.com 02 Jan '14

02 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Change DetachNetworkToVdsGroup to non-transactive ...................................................................... engine: Change DetachNetworkToVdsGroup to non-transactive The command will be used also for removing the network from the hostis. For that purpose the command should be managed as a non-transactive. Change-Id: I419ddbd3b657dae7829f15d45399b3b1a4996172 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java 1 file changed, 14 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I419ddbd3b657dae7829f15d45399b3b1a4996172 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extract method to create the vlan name
by masayag＠redhat.com 02 Jan '14

02 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract method to create the vlan name ...................................................................... engine: Extract method to create the vlan name A method to produce a vlan device name is being extract for the sake of reusability. Change-Id: Ic00417b54feb523d8152363ed0986ae9b685f36e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java 2 files changed, 16 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved Objections: oVirt Jenkins CI Server: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/22768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic00417b54feb523d8152363ed0986ae9b685f36e Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Configure network on hosts on cluster assignment
by masayag＠redhat.com 02 Jan '14

02 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Configure network on hosts on cluster assignment ...................................................................... engine: Configure network on hosts on cluster assignment When a labelled network is being assigned to a cluster, it will be configured on all of the cluster's hosts which own an interfaces with that label. Change-Id: Ided511feab3a7addffcb1ddc559f32da6cb1873c Bug-Url: http://bugzilla.redhat.com/1040586 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 122 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved Objections: oVirt Jenkins CI Server: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/22767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ided511feab3a7addffcb1ddc559f32da6cb1873c Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0