November 2014 - Engine-commits - oVirt List Archives

Change in mom[master]: Track and log exceptions during thread init
by alitke＠redhat.com 24 Nov '14

24 Nov '14

Adam Litke has submitted this change and it was merged. Change subject: Track and log exceptions during thread init ...................................................................... Track and log exceptions during thread init We are currently tracking and logging exceptions that happen in mom threads within their run loop. We should also log exceptions that are raised during thread initialization. Change-Id: Iaf2289a401156c9384b4237f631313c4031a6cf2 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/35437 Reviewed-by: Martin Sivák <msivak(a)redhat.com> --- M mom/__init__.py M tests/GeneralTests.py 2 files changed, 18 insertions(+), 14 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf2289a401156c9384b4237f631313c4031a6cf2 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: better handling of preexisting storage domain
by sbonazzo＠redhat.com 24 Nov '14

24 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: better handling of preexisting storage domain ...................................................................... packaging: setup: better handling of preexisting storage domain Better handling of preexisting storage domain validating it Change-Id: I622e0540ca21eea5ebddbfa4361bfb6537ca42d8 Bug-Url: https://bugzilla.redhat.com/1155637 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit edc763f1a773e59baa7d3c965c6dff5344cb3ace) --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 16 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/35388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I622e0540ca21eea5ebddbfa4361bfb6537ca42d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Enable Long xmlrpc support for new VM and disk hotplug
by tnisan＠redhat.com 24 Nov '14

24 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Enable Long xmlrpc support for new VM and disk hotplug ...................................................................... engine: Enable Long xmlrpc support for new VM and disk hotplug This is needed for the two commands to support Long based values in the ioTune QoS policy parameters. Change-Id: I82673b6dec7ba320c56a1cf6e0cd3f1dde86fd22 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145621 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/35278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82673b6dec7ba320c56a1cf6e0cd3f1dde86fd22 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Use proper units in Storage QoS when talking to VDSM
by tnisan＠redhat.com 24 Nov '14

24 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Use proper units in Storage QoS when talking to VDSM ...................................................................... engine: Use proper units in Storage QoS when talking to VDSM The engine used Mbps and VDSM expects B/s. This patch changes the engine side to use MB/s (as is more common when dealing with storage) and properly translates that to Bytes when sending the value to VDSM. Change-Id: I2644e9e029c8b6ebe4b5b7626f7b1ed6b6b5aea4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145621 Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 3 files changed, 20 insertions(+), 14 deletions(-) Approvals: Martin Sivák: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2644e9e029c8b6ebe4b5b7626f7b1ed6b6b5aea4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Enhance the xml-rpc Long support to deal with Maps a...
by tnisan＠redhat.com 24 Nov '14

24 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Enhance the xml-rpc Long support to deal with Maps and Lists ...................................................................... engine: Enhance the xml-rpc Long support to deal with Maps and Lists It is common to have a Long value in a sub-map of an xml-rpc argument. The current implementation does not deal with this case. The ideal solution to this would be to instruct the marshaller to do this. Unfortunately that is not possible and we have to work around that limitation. Change-Id: I5a5933a68f937c4734b547c173188e88bd7b9464 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145665 Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java 1 file changed, 32 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a5933a68f937c4734b547c173188e88bd7b9464 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: update vm version for pool-vm
by ofrenkel＠redhat.com 24 Nov '14

24 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: update vm version for pool-vm ...................................................................... core: update vm version for pool-vm When pool-vm is started by admin, it is not attached to any user, nor doest it have a stateless snapshot. so in this case, the logic that check if new version exists is skipped. this patch calls restoreStatelessSnapshot (that contains the new version logic) also to pool vms that are not attached to any user. Change-Id: Ibce7bc6d744a0bc4ef42e7f039e880c595e44f89 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167102 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibce7bc6d744a0bc4ef42e7f039e880c595e44f89 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Engine: Pre-started vms in vm pool display bad auditlog message
by shavivi＠redhat.com 24 Nov '14

24 Nov '14

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: Pre-started vms in vm pool display bad auditlog message ...................................................................... Engine: Pre-started vms in vm pool display bad auditlog message Change-Id: I6ce736c1b24265a13b147ffae235428ddbd597e4 Bug-Url: https://bugzilla.redhat.com/1163728 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified Arik Hadas: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ce736c1b24265a13b147ffae235428ddbd597e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add vertical split table
by ahadas＠redhat.com 24 Nov '14

24 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: add vertical split table ...................................................................... webadmin: add vertical split table Similar to HorizontalSplitTable but the excluded items table is located to the left of the included items table and there are left and right arrows which are used to pass items between the two. Change-Id: I353c7c0fbc1461d8c8832dcd558f84f011fe37b6 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/VerticalSplitTable.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/VerticalSplitTable.ui.xml A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_left_click.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_left_disabled.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_left_normal.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_left_over.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_right_click.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_right_disabled.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_right_normal.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_right_over.png 11 files changed, 130 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/35211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I353c7c0fbc1461d8c8832dcd558f84f011fe37b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add Video managed device for VM's/Template's OVF.
by tnisan＠redhat.com 24 Nov '14

24 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add Video managed device for VM's/Template's OVF. ...................................................................... core: Add Video managed device for VM's/Template's OVF. The number of monitors data in the Template should be part of the OVF data. so the information will still be availale after the attach of a Storage Domain with import of existing entities. This information consists in the video device of the entity, therefore the fix adds video devices while building the OVF data, same as being done in the export VM/Template process. Change-Id: I5583edadd75bce7dfb3f5ba04cfcbe38f1dc7091 Bug-Url: https://bugzilla.redhat.com/1136902 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5583edadd75bce7dfb3f5ba04cfcbe38f1dc7091 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: AuditLogMessage for internal disk addition
by tnisan＠redhat.com 24 Nov '14

24 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: AuditLogMessage for internal disk addition ...................................................................... core: AuditLogMessage for internal disk addition When adding a disk as part of an internal command - when no user is involved, the <UNKNOWN> user was specified as user. This is now corrected and new audit log messages were added with no user specification in the message. Change-Id: Ia66bb5fb393802cbfe6847240d6adfbbd1a53e4e Bug-Url: https://bugzilla.redhat.com/1149620 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 10 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/35461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia66bb5fb393802cbfe6847240d6adfbbd1a53e4e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0