November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: support custom properties for templates
by ofrenkel＠redhat.com 19 Nov '14

19 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: frontend: support custom properties for templates ...................................................................... frontend: support custom properties for templates currently custom properties are vm only feature, so adding also to templates. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1011735 Change-Id: If5d982307a9ffcee758dfec712916dc47ce3aab5 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreUnitToVmBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/VmSpecificUnitToVmBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 10 files changed, 12 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/35119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5d982307a9ffcee758dfec712916dc47ce3aab5 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: mapParams performance improvement
by oourfali＠redhat.com 19 Nov '14

19 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: mapParams performance improvement ...................................................................... core: mapParams performance improvement When going through jprofiler snapshots from scale env I noticed that getDataTimeInstance is taking a lot of time. DateFormat objects is not used but we create it every time we run mapParams so we can remove it without any harm. Change-Id: Ib914112be17442e13148def922a486ccf9c0f63f Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1155146 --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib914112be17442e13148def922a486ccf9c0f63f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: extapi: build: fix checkstyle plugin
by oourfali＠redhat.com 19 Nov '14

19 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: extapi: build: fix checkstyle plugin ...................................................................... extapi: build: fix checkstyle plugin Change-Id: I01f2f7b1f883faabdb28d9cd9cec3a577120f362 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A backend/manager/modules/extensions-api-root/extensions-api/checkstyle.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java M backend/manager/modules/extensions-api-root/pom.xml 4 files changed, 58 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01f2f7b1f883faabdb28d9cd9cec3a577120f362 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: filters: fix formatting
by oourfali＠redhat.com 19 Nov '14

19 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: filters: fix formatting ...................................................................... aaa: filters: fix formatting Change-Id: I03ee9a1e9c7c57751eb206e633efeef721fe98ef Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03ee9a1e9c7c57751eb206e633efeef721fe98ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: extapi: revert version to release
by piotr.kliczewski＠gmail.com 19 Nov '14

19 Nov '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: extapi: revert version to release ...................................................................... extapi: revert version to release maven is not z-stream aware, so we should keep artifact as-is. Change-Id: Ib5599e3bc24460c54a1fc220709bd778122bce80 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M pom.xml 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5599e3bc24460c54a1fc220709bd778122bce80 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: extapi: build: fix checkstyle plugin
by yzaslavs＠redhat.com 19 Nov '14

19 Nov '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extapi: build: fix checkstyle plugin ...................................................................... extapi: build: fix checkstyle plugin Change-Id: I01f2f7b1f883faabdb28d9cd9cec3a577120f362 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A backend/manager/modules/extensions-api-root/extensions-api/checkstyle.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java M backend/manager/modules/extensions-api-root/pom.xml 4 files changed, 58 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified Moti Asayag: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01f2f7b1f883faabdb28d9cd9cec3a577120f362 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Allow registerVds with same name and hostname if provisioned
by oourfali＠redhat.com 19 Nov '14

19 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: Allow registerVds with same name and hostname if provisioned ...................................................................... Allow registerVds with same name and hostname if provisioned Currently we delete the old vds record with InstallingOS status to allow adding new record as waiting for approval. This is wrong approach which causes lose of all the initial information that set on the vds record. With this fix we don't delete the record and skip the duplication check Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115343 Change-Id: I157b567b2c868b12a89a394e909e97895338380d Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 1 file changed, 19 insertions(+), 10 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I157b567b2c868b12a89a394e909e97895338380d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.5]: sos: fix missing backport of add_alert
by sbonazzo＠redhat.com 19 Nov '14

19 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: fix missing backport of add_alert ...................................................................... sos: fix missing backport of add_alert fixes add_alert -> addAlert backport from sos 3.y to 2.y Change-Id: I3469fc13cfd1ece311476a5c1a5200f294763587 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit a0e280011c1b8f310d24689f6ee1033deffb81b1) --- M src/sos/plugins/ovirt.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3469fc13cfd1ece311476a5c1a5200f294763587 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-log-collector[master]: sos: fix missing backport of add_alert
by sbonazzo＠redhat.com 19 Nov '14

19 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: fix missing backport of add_alert ...................................................................... sos: fix missing backport of add_alert fixes add_alert -> addAlert backport from sos 3.y to 2.y Change-Id: I3469fc13cfd1ece311476a5c1a5200f294763587 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/ovirt.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3469fc13cfd1ece311476a5c1a5200f294763587 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: reduced logging in Even distribution policy
by tnisan＠redhat.com 19 Nov '14

19 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: reduced logging in Even distribution policy ...................................................................... engine: reduced logging in Even distribution policy Change-Id: I99d7492bba98670027dbb5b13e2290bf84510ec1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126839 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> (cherry picked from commit 7f74698b81b55156d9d779e9aff248cdf5064709) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jiří Moskovčák: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d7492bba98670027dbb5b13e2290bf84510ec1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0