November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: codegen, sdk: Rename "export" to "export_"
by juan.hernandez＠redhat.com 28 Nov '14

28 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen, sdk: Rename "export" to "export_" ...................................................................... codegen, sdk: Rename "export" to "export_" The classes generated by the generateDS.py tool contain an "export" method intended to convert the objects to the corresponding XML document. The broker classes generated by our own code generator also generate "export" methods for some resources that have an "export" action, for example virtual machines. These two methods clash, making it impossible to generate XML for some broker classes. To avoid this class this patch modifies our code generator so that it will modify the code generated with generateDS.py, renaming the "export" method to "export_". Change-Id: Iad8a031684ddaed11c1b11efc379e746888cd0a2 Bug-Url: https://bugzilla.redhat.com/1167851 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/XsdCodegen.java M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/infrastructure/common.py M src/ovirtsdk/utils/parsehelper.py M src/ovirtsdk/xml/params.py 6 files changed, 831 insertions(+), 816 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad8a031684ddaed11c1b11efc379e746888cd0a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Remove unused function
by juan.hernandez＠redhat.com 28 Nov '14

28 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Remove unused function ...................................................................... codegen: Remove unused function This patch removes a function of the XML schema generator that is never used. The change has no impact in the generated code. Change-Id: I79fa56613fe904e4e1087d5bcb41f122b354f9ab Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/XsdCodegen.java 1 file changed, 0 insertions(+), 17 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79fa56613fe904e4e1087d5bcb41f122b354f9ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: sync: handle group loops
by yzaslavs＠redhat.com 28 Nov '14

28 Nov '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: sync: handle group loops ...................................................................... aaa: sync: handle group loops Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1168631 Change-Id: Ie90ad3cbef9675be8c0ceba47c22609a9985b518 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java 1 file changed, 29 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie90ad3cbef9675be8c0ceba47c22609a9985b518 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add try/catch block in end action of ExportVmCommand
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add try/catch block in end action of ExportVmCommand ...................................................................... core: Add try/catch block in end action of ExportVmCommand When exporting a VM with the collapse snapshot option, the VM ovf is updated after the images export ends successfully. If this operation will fail and throw an exception the source VM will be stayed in locked status. This patch surrounds the operation with a try/catch block in order to log the fault and continue the end action correctly to unlock the VM and it's disks. Bug-Url: https://bugzilla.redhat.com/1167297 Change-Id: I67e5119f0f65ce77bc30b6762192e927c88c4434 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 13 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67e5119f0f65ce77bc30b6762192e927c88c4434 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: Use correct Avalon Framework .jar files in EL7
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: Use correct Avalon Framework .jar files in EL7 ...................................................................... packaging: Use correct Avalon Framework .jar files in EL7 In version 7 of RHEL and CentOS the Avalon Framework .jar files are split, like in Fedora, but currently we assume that they aren't, as that was the case in version 6. This modifies the .spec file so that this difference is taken into account. Change-Id: Idd0ea12dfbd3ad695cc2a3390fd3d104d2823ea9 Bug-Url: https://bugzilla.redhat.com/1168405 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit b5d7622f742152d62d850349d7475efed5ff4f3b) --- M ovirt-engine.spec.in 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/35667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd0ea12dfbd3ad695cc2a3390fd3d104d2823ea9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Moved disk alias genenration in AddDiskCommand to exec...
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Moved disk alias genenration in AddDiskCommand to execution ...................................................................... core: Moved disk alias genenration in AddDiskCommand to execution Moved the disk alias generation in AddDiskCommand to the execution phase as in the job properties calculation the VM disk map is not yet populated. Also the disk alias was omitted from the execution message as we cannot assure that in 100% of the times a disk alias will be specified (the VM name is not there for the same reason) Bug-Url: https://bugzilla.redhat.com/1168252 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Change-Id: Id30fa5d3a99dd12b8c45633d592d017c3a6ffd1b --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 2 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id30fa5d3a99dd12b8c45633d592d017c3a6ffd1b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Fixing multiple src rpms build
by dcaroest＠redhat.com 27 Nov '14

27 Nov '14

David Caro has submitted this change and it was merged. Change subject: Fixing multiple src rpms build ...................................................................... Fixing multiple src rpms build On fc21 it seems that building more than one src rpm at a time breaks, now it should build them one by one. Change-Id: I52f340135af03b89abd963acbd1155597fbc09c6 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/mock_build_onlyrpm.sh 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52f340135af03b89abd963acbd1155597fbc09c6 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change import vm to be VmCommand - part 3
by ahadas＠redhat.com 27 Nov '14

27 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: change import vm to be VmCommand - part 3 ...................................................................... core: change import vm to be VmCommand - part 3 Introduce ImportValidator that stores the validation logics which are required for import operations, to reduce the coupling between ImportVmcommand and MoveOrCopyTemplateCommand. This validator will be used later in other import commands. The tests which test the logic of the validation were moved to ImportValidatorTest and the tests in ImportVmCommandTest were changed such that they will check that the right error is returned from the canDoAction method, assuming that the validator returns the appropriate error. Change-Id: I7fa61e7f493d196acdb40bfe461665d6668c6508 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ImportValidatorTest.java 6 files changed, 392 insertions(+), 50 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fa61e7f493d196acdb40bfe461665d6668c6508 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: Fix search button logic
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: ui: Fix search button logic ...................................................................... ui: Fix search button logic Commit 60331c40535c95950274984d89177643df5686db broke the search button logic. This patch returns the same refresh logic that was next to the current changes. Change-Id: Ia86fa287a050e030d28ab96eeecfb888dd1cb22b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165669 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 3 files changed, 36 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia86fa287a050e030d28ab96eeecfb888dd1cb22b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Reduced visibility of methods in ExportVmCommand
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Reduced visibility of methods in ExportVmCommand ...................................................................... core: Reduced visibility of methods in ExportVmCommand Change-Id: I07ccaed16483a25a4798954bc6bb96e8ef344877 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07ccaed16483a25a4798954bc6bb96e8ef344877 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0