November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: adding retry for host start for PPC
by tnisan＠redhat.com 02 Nov '14

02 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: adding retry for host start for PPC ...................................................................... core: adding retry for host start for PPC Sometimes a restart operation started by engine is not completed because the host PM failed to put the host on 'on' state This occurred on PPC hosts only until now. Some fencing scripts as the one used here (IPMI) have an option to se retries for the 'on' operation by sending : retry_on=<number> The patch adds "retry_on=2" for the relevant PPC fencing scripts such that this will be sent by engine as a default when a PPC host has one of those agents used Change-Id: I2c7a195526eb3f6454116806131294de2d3fc067 Bug-Url: https://bugzilla.redhat.com/1151553 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c7a195526eb3f6454116806131294de2d3fc067 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: set boot order index 0 for unmanaged nic
by ahadas＠redhat.com 02 Nov '14

02 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: set boot order index 0 for unmanaged nic ...................................................................... core: set boot order index 0 for unmanaged nic This patch fix NPE which was thrown when computing boot order for a VM that has unmanaged network interface. The boot order index for unmanaged network interfaces will now be 0. Change-Id: If299f5c10dbfd15cf5ebe01f6d7911a7f92eb56f Bug-Url: https://bugzilla.redhat.com/1155667 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtilsTest.java 2 files changed, 23 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If299f5c10dbfd15cf5ebe01f6d7911a7f92eb56f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix typos in test.
by oourfali＠redhat.com 02 Nov '14

02 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix typos in test. ...................................................................... core: fix typos in test. Change-Id: I15a9c82059d4c470dc8de6b6c69ae1a818dedf25 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VdcActionTypeTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15a9c82059d4c470dc8de6b6c69ae1a818dedf25 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Create default disk profiles for data domains
by tnisan＠redhat.com 02 Nov '14

02 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Create default disk profiles for data domains ...................................................................... core: Create default disk profiles for data domains All data domains should have default disk profiles with unlimited QoS (currently implemented by null) Otherwise all existing data domains needs manual intervention for creating disks if the data center is upgraded to version 3.5 Change-Id: I3ee3174e5c7bef3bcd5591b9cd99ff5324bee488 Bug-Url: https://bugzilla.redhat.com/1145241 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_1130_create_default_disk_profiles.sql 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Roy Golan: Verified -- To view, visit http://gerrit.ovirt.org/34598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ee3174e5c7bef3bcd5591b9cd99ff5324bee488 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: handle host architecture in fence flow
by tnisan＠redhat.com 02 Nov '14

02 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: handle host architecture in fence flow ...................................................................... core: handle host architecture in fence flow This patch adds a getArchitecture method to VDS. It is used in order to get the host architecture using its cpu flags, in case that this is null, the architecture of the containing cluster is used. Please note that a separate call to get VdsDynamic information for the host since the VDS object passed to the fencing code is slim and does not contain any dymanic information. Change-Id: I081361c9f956ea71a715acf0368c79c7130674c7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149235 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsArchitectureHelper.java 3 files changed, 36 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I081361c9f956ea71a715acf0368c79c7130674c7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: HotUnplug - clear device logical name
by tnisan＠redhat.com 02 Nov '14

02 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: HotUnplug - clear device logical name ...................................................................... core: HotUnplug - clear device logical name Change-Id: Ib770de4c901ad29badfdb2544865283bbf1a6e3b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063597 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/34485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib770de4c901ad29badfdb2544865283bbf1a6e3b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: GetAllDisksByVmIdQuery - set logical name
by tnisan＠redhat.com 02 Nov '14

02 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: GetAllDisksByVmIdQuery - set logical name ...................................................................... core: GetAllDisksByVmIdQuery - set logical name Change-Id: Id35fac4c3b2d7441928fb69001498984dde03457 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063597 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQuery.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/34484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id35fac4c3b2d7441928fb69001498984dde03457 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: VdsUpdateRunTimeInfo - update device logical name
by tnisan＠redhat.com 02 Nov '14

02 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: VdsUpdateRunTimeInfo - update device logical name ...................................................................... core: VdsUpdateRunTimeInfo - update device logical name This patch adds support to update disks logical names as retrieved from vdsm. Change-Id: I08b13ba18ded824d7c62f72766fa7055da6ec49c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063597 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 6 files changed, 71 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/34483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08b13ba18ded824d7c62f72766fa7055da6ec49c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: rest: adding logicalName to Disk
by tnisan＠redhat.com 02 Nov '14

02 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: rest: adding logicalName to Disk ...................................................................... rest: adding logicalName to Disk Change-Id: I61590c59cd0b85ebdda0f4a2c98de83983b0dccc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063597 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java 3 files changed, 7 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/34482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61590c59cd0b85ebdda0f4a2c98de83983b0dccc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: adding logicalName to Disk
by tnisan＠redhat.com 02 Nov '14

02 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: adding logicalName to Disk ...................................................................... core: adding logicalName to Disk Change-Id: I29a51446b7821b2f1ea2840d44adaff2542bfa0f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063597 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/34481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29a51446b7821b2f1ea2840d44adaff2542bfa0f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0