December 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Preventing moving a shareable disk to a Gluster domain
by laravot＠redhat.com 30 Dec '14

30 Dec '14

Liron Aravot has submitted this change and it was merged. Change subject: core: Preventing moving a shareable disk to a Gluster domain ...................................................................... core: Preventing moving a shareable disk to a Gluster domain Gluster domian does not support shareable disks- therefor MoveDisksCommand now prevents this action. Tests are also added. Change-Id: I37e500e86d2b6094bb257221a4ca899590aed610 Bug-Url: https://bugzilla.redhat.com/1135771 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 82 insertions(+), 30 deletions(-) Approvals: Amit Aviram: Verified Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37e500e86d2b6094bb257221a4ca899590aed610 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: supress findbugs warning in StorageServerConnectionCom...
by laravot＠redhat.com 29 Dec '14

29 Dec '14

Liron Aravot has submitted this change and it was merged. Change subject: core: supress findbugs warning in StorageServerConnectionCommandBase ...................................................................... core: supress findbugs warning in StorageServerConnectionCommandBase after change I0fc70dd4e7988f4ea4597f016c9de8419c17adfa findbugs complains about null pointer dereference of connections which is wrong. Change-Id: I139f33ddba33cfb109145505afc1aea609c82807 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I139f33ddba33cfb109145505afc1aea609c82807 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Check if data center version supports import data doma...
by tnisan＠redhat.com 29 Dec '14

29 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Check if data center version supports import data domain upon attach ...................................................................... core: Check if data center version supports import data domain upon attach When we are selecting a data center that does not support import of data domains, make those options unselectable Change-Id: I05b6a8fe737691655dedbfbbb8d1f0ee4a592668 Bug-Url: https://bugzilla.redhat.com/1176436 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 6 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05b6a8fe737691655dedbfbbb8d1f0ee4a592668 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Warn when importing a data domain to a DC that doe...
by tnisan＠redhat.com 29 Dec '14

29 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Warn when importing a data domain to a DC that doesn't support ...................................................................... webadmin: Warn when importing a data domain to a DC that doesn't support Show a warning when the user is trying to import a data domain a data center which version does not support import of a data domain Change-Id: I79e57dc3d2bcc8a3efb717f0261d9ca66636b463 Bug-Url: https://bugzilla.redhat.com/1176436 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 6 files changed, 74 insertions(+), 59 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79e57dc3d2bcc8a3efb717f0261d9ca66636b463 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: history: removed Host power management
by ydary＠redhat.com 29 Dec '14

29 Dec '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: removed Host power management ...................................................................... history: removed Host power management Removed Host power management fields from History DB. Change-Id: I9d4bff565a4bcebc1200978ec066f0d0bafb410c Bug-Url: https://bugzilla.redhat.com/951902 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/src/ovirt_engine_dwh/configurationsync_3_6/ConfigurationSync.java M etl_export/src/ovirt_engine_dwh/hostconfigcheck_3_6/HostConfigCheck.java M packaging/dbscripts/create_tables.sql M packaging/dbscripts/create_views_3_0.sql M packaging/dbscripts/create_views_3_1.sql M packaging/dbscripts/create_views_3_2.sql M packaging/dbscripts/create_views_3_3.sql M packaging/dbscripts/create_views_3_4.sql M packaging/dbscripts/create_views_3_5.sql M packaging/dbscripts/create_views_3_6.sql A packaging/dbscripts/upgrade/03_06_0010_drop_pm_ip_address_from_host_configuration.sql M tos_project/configuration/ExpressionBuilder/ConfigurationSync.xml M tos_project/process/ConfigurationSync_3.6.item M tos_project/process/ConfigurationSync_3.6.properties M tos_project/process/HostConfigCheck_3.6.item M tos_project/process/HostConfigCheck_3.6.properties 16 files changed, 270 insertions(+), 496 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d4bff565a4bcebc1200978ec066f0d0bafb410c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: create ReconstructMasterDomain validators
by laravot＠redhat.com 29 Dec '14

29 Dec '14

Liron Aravot has submitted this change and it was merged. Change subject: core: create ReconstructMasterDomain validators ...................................................................... core: create ReconstructMasterDomain validators Change-Id: I1b8c4727336c5df28f06566f7cb05c1871fcb000 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StoragePoolValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommandTest.java 4 files changed, 150 insertions(+), 28 deletions(-) Approvals: Federico Simoncelli: Verified Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b8c4727336c5df28f06566f7cb05c1871fcb000 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix executeDeactivateCommand spelling
by laravot＠redhat.com 29 Dec '14

29 Dec '14

Liron Aravot has submitted this change and it was merged. Change subject: core: fix executeDeactivateCommand spelling ...................................................................... core: fix executeDeactivateCommand spelling Change-Id: I06c7443ae24310953c41aca6dcbb61a800a66d1b Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Federico Simoncelli: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06c7443ae24310953c41aca6dcbb61a800a66d1b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Change audit log value to avoid a duplicate value
by tnisan＠redhat.com 28 Dec '14

28 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Change audit log value to avoid a duplicate value ...................................................................... core: Change audit log value to avoid a duplicate value Both audit log types now contain the same value 1019, changing one of them to avoid this duplicity Change-Id: I8aa0f12eea61464348f7be9272d743b8f088d0f8 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8aa0f12eea61464348f7be9272d743b8f088d0f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: find connections with same password
by tnisan＠redhat.com 28 Dec '14

28 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: find connections with same password ...................................................................... core: find connections with same password When saving connections to the db the password is being encrypted (introduced in change d0ed215) - the problem with that is that if we attempt to check if a connection with specific details was already saved - we'll not be able to fetch it (as the encrypted password is different each time). This issue was handled in I997b by removing the password out of the query but further fix is required, for example if connection with wrong password already exists in the db, we'll use it instead of using the other password. In this change i changed the way that we check if similar connection exists, the conenctions with the 'same' details (besides the password) are being loaded and then it's being checked if the password is the same as the entered one - if it is, it's the same connection and otherwise it's a different one. Change-Id: I0fc70dd4e7988f4ea4597f016c9de8419c17adfa Bug-Url: https://bugzilla.redhat.com/1176578 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java 5 files changed, 42 insertions(+), 21 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/36404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fc70dd4e7988f4ea4597f016c9de8419c17adfa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Check if data center version supports import data doma...
by tnisan＠redhat.com 28 Dec '14

28 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Check if data center version supports import data domain upon attach ...................................................................... core: Check if data center version supports import data domain upon attach When we are selecting a data center that does not support import of data domains, make those options unselectable Change-Id: I05b6a8fe737691655dedbfbbb8d1f0ee4a592668 Bug-Url: https://bugzilla.redhat.com/1176436 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 6 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05b6a8fe737691655dedbfbbb8d1f0ee4a592668 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0