December 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: ui: fixing addHost form issues when playing with using host ...
by oourfali＠redhat.com 01 Dec '14

01 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: fixing addHost form issues when playing with using host provider ...................................................................... ui: fixing addHost form issues when playing with using host provider Apparently hiding the host provider form was buggy. In this patch we fix the fields cleaning and the visibility of the provider parameters. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165670 Change-Id: I700ec281a1bd1617d0168d59c8daef5b5bcf4f6b Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 3 files changed, 12 insertions(+), 18 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I700ec281a1bd1617d0168d59c8daef5b5bcf4f6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Improve LexoNumericComparator case-insensitive behavior
by lvernia＠redhat.com 01 Dec '14

01 Dec '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Improve LexoNumericComparator case-insensitive behavior ...................................................................... core: Improve LexoNumericComparator case-insensitive behavior It is generally bad to return 0 when comparing strings that aren't identical - I can think of at least two good reasons. Firstly, due to dysfunctional TreeSet behavior in Java (it uses a comparator to tell whether two items are identical - this actually breaks the contract of Set, which is guaranteed to only refer to items as identical if they return the same hashCode() or true for equals()), it is best to distinguish between non-identical strings even if they're equal when compared case-insensitively. Secondly, when collections of items are sorted, it's best to have a deterministic order between them - otherwise "equal" rows may switch places (e.g. upon refresh). Change-Id: I097cdb5f4f784577586160f10c0ef151fc9c9b4f Bug-Url: https://bugzilla.redhat.com/1167641 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparator.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparatorTest.java 2 files changed, 28 insertions(+), 6 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/35572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I097cdb5f4f784577586160f10c0ef151fc9c9b4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : [mla] query execution failed due to insufficient pe...
by yzaslavs＠redhat.com 01 Dec '14

01 Dec '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : [mla] query execution failed due to insufficient permissions ...................................................................... engine : [mla] query execution failed due to insufficient permissions GetTasksStatusesByTasksIDsQuery throws insufficient permissions when querying for task ids Change-Id: I2d036f6a03a5f46342945452340133bd8150ce45 Bug-Url: https://bugzilla.redhat.com/1153043 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTasksStatusesByTasksIDsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java 3 files changed, 31 insertions(+), 4 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d036f6a03a5f46342945452340133bd8150ce45 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0