December 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Use CanDoActionTestUtils in test
by tnisan＠redhat.com 25 Dec '14

25 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use CanDoActionTestUtils in test ...................................................................... core: Use CanDoActionTestUtils in test Use CanDoActionTestUtils instead of executing CDA followed by asserting false and checking messages in UpdateVmDiskCommandTest. Change-Id: I99e7be1c20b243da63f9df28ad4e25f580b201eb Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 1 file changed, 6 insertions(+), 21 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/35459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99e7be1c20b243da63f9df28ad4e25f580b201eb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Removed useless code from test
by tnisan＠redhat.com 25 Dec '14

25 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed useless code from test ...................................................................... core: Removed useless code from test In UpdateVmDiskCommandTest, there were recurrent mockings to vmDeviceDao.get, which were never called in the command, therefore the mock is useless. Now removed, along with vmDevices that are no longer used. Change-Id: If1580f66cc5a41583abbc936308946ea3b70939f Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 1 file changed, 15 insertions(+), 54 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/35458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1580f66cc5a41583abbc936308946ea3b70939f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: disable illegal operations on a pooled VM
by tnisan＠redhat.com 25 Dec '14

25 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: disable illegal operations on a pooled VM ...................................................................... core: disable illegal operations on a pooled VM When a disk is defined as ReadOnly or Wipe After Delete in a VmTemplate, after which a VmPool was created, these values shouldn't be allowed to be changed as long as the vm is still attached to the pool. This patch enforces this in the backend. Change-Id: Ie3a6e1542f3ef4fb78f074b62e854a4907dfbca6 Bug-Url: https://bugzilla.redhat.com/1057721 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 50 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/35457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3a6e1542f3ef4fb78f074b62e854a4907dfbca6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Enhance RO need to update check
by tnisan＠redhat.com 25 Dec '14

25 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Enhance RO need to update check ...................................................................... core: Enhance RO need to update check RO property's null is interpreted as false in VmDevice and remains null in Disk. This may result in a wrong decision whether to an update is in need or not. This patch addresses this issue. Change-Id: I9bbfc60c3e9bda0133eec9b1db116f8e7bad9d1d Related-To: https://bugzilla.redhat.com/1057721 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/35456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bbfc60c3e9bda0133eec9b1db116f8e7bad9d1d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix alignment issue in new domain view
by tnisan＠redhat.com 25 Dec '14

25 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix alignment issue in new domain view ...................................................................... webadmin: Fix alignment issue in new domain view Under the Custom Connection Parameters, some of the fields were not separated. Change-Id: I4970cfd8c8fd7503082e53fff4a7045877fc7ccf Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/36350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4970cfd8c8fd7503082e53fff4a7045877fc7ccf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: label change for "Advanced Parameters"
by tnisan＠redhat.com 25 Dec '14

25 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: label change for "Advanced Parameters" ...................................................................... webadmin: label change for "Advanced Parameters" Replaced "Advanced Parameters" label in NfsStorageView to "Custom Connection Parameters", as this is the theme for the parameters below. Change-Id: I9bae92c4e1e70cab83463d914018cc468355903a Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bae92c4e1e70cab83463d914018cc468355903a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Set disk alias and description on register disk
by tnisan＠redhat.com 25 Dec '14

25 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Set disk alias and description on register disk ...................................................................... core: Set disk alias and description on register disk Setting the disk alias name and description from the disk's meta data, once it is being registered again. Change-Id: If65018fef71fa126173ab516a89e8bd158b06f7e Bug-Url: https://bugzilla.redhat.com/1047623 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/36392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If65018fef71fa126173ab516a89e8bd158b06f7e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add alias and description for disk meta data
by tnisan＠redhat.com 25 Dec '14

25 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add alias and description for disk meta data ...................................................................... core: Add alias and description for disk meta data Add the disk alias and the description in the disk meta data. Those fields should be initialized in the meta data so they can be preserved and restored for floating disks, once the Storage Domain was being detached and attached again. Change-Id: Ie2642ae7016579ead699509426e01ac2010bd374 Bug-Url: https://bugzilla.redhat.com/1047623 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 7 files changed, 215 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/36391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2642ae7016579ead699509426e01ac2010bd374 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Set disk alias and description on register disk
by mlipchuk＠redhat.com 24 Dec '14

24 Dec '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Set disk alias and description on register disk ...................................................................... core: Set disk alias and description on register disk Setting the disk alias name and description from the disk's meta data, once it is being registered again. Change-Id: If65018fef71fa126173ab516a89e8bd158b06f7e Bug-Url: https://bugzilla.redhat.com/1047623 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/34164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If65018fef71fa126173ab516a89e8bd158b06f7e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add alias and description for disk meta data
by mlipchuk＠redhat.com 24 Dec '14

24 Dec '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add alias and description for disk meta data ...................................................................... core: Add alias and description for disk meta data Add the disk alias and the description in the disk meta data. Those fields should be initialized in the meta data so they can be preserved and restored for floating disks, once the Storage Domain was being detached and attached again. Change-Id: Ie2642ae7016579ead699509426e01ac2010bd374 Bug-Url: https://bugzilla.redhat.com/1047623 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 7 files changed, 215 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/34163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2642ae7016579ead699509426e01ac2010bd374 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0