February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Remove javadoc from one of DiskValidator APIs
by amureini＠redhat.com 18 Feb '14

18 Feb '14

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove javadoc from one of DiskValidator APIs ...................................................................... engine: Remove javadoc from one of DiskValidator APIs Removed javadoc is not alligned with the curent API signature and doesn't provide any additional information about it. Change-Id: Iaa3d1173400be9eae7f0ba79344fdeb9724ca6d3 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Sergey Gotliv: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa3d1173400be9eae7f0ba79344fdeb9724ca6d3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: post ovirt-engine-3.4.0_beta3
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: post ovirt-engine-3.4.0_beta3 ...................................................................... packaging: post ovirt-engine-3.4.0_beta3 Updated version to 3.4.0-0.10 Change-Id: I182f3a7c7431ead266aa7bae03cfae08581d00e7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M version.mak 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I182f3a7c7431ead266aa7bae03cfae08581d00e7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: ovirt-engine-3.4.0_beta3
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.4.0_beta3 ...................................................................... packaging: ovirt-engine-3.4.0_beta3 Updated version to be 3.4.0_beta3 Change-Id: I6b9286820e03b82f2ca68c048d9057c11cf3b868 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M version.mak 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b9286820e03b82f2ca68c048d9057c11cf3b868 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools: Sort domains when validating in engine-manage-domains
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: tools: Sort domains when validating in engine-manage-domains ...................................................................... tools: Sort domains when validating in engine-manage-domains Sort domains by name prior to validate action in engine-manage-domains. Change-Id: I6243fb8d6ae1fc34c31517559bb56b091cc10b1d Bug-Url: https://bugzilla.redhat.com/1057182 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 21 insertions(+), 12 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6243fb8d6ae1fc34c31517559bb56b091cc10b1d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: Fail to add Event-Notification
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: Fail to add Event-Notification ...................................................................... Fail to add Event-Notification While trying to add event notification name "Failed to restart VM on a different host" under "VM Events" getting popup the following popup error: Error while executing action: The notification event VDS_INITIATED_RUN_VM_FAILED is unsupported. Change-Id: Id99444dc827bf21fd70637276eb3a9390839002f Bug-Url: https://bugzilla.redhat.com/1057136 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0590_add_restart_different_host_event.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Adam Litke: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id99444dc827bf21fd70637276eb3a9390839002f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: packaging: services: don't enable services on install
by gpadgett＠redhat.com 18 Feb '14

18 Feb '14

Greg Padgett has submitted this change and it was merged. Change subject: packaging: services: don't enable services on install ...................................................................... packaging: services: don't enable services on install Avoid to enable HA services automatically after rpm install. It should be done by hosted-engine --deploy. Change-Id: I9064a8a7bc28d0e581f2311d11b9fdca375dd3b5 Related-To: https://bugzilla.redhat.com/1034726 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified Greg Padgett: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9064a8a7bc28d0e581f2311d11b9fdca375dd3b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Refactor AuditLog severity handling - step 1
by emesika＠redhat.com 17 Feb '14

17 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: engine: Refactor AuditLog severity handling - step 1 ...................................................................... engine: Refactor AuditLog severity handling - step 1 Having a separate structure (AuditLogDirector.severities) to hold the severity definitions for messages from AuditLogType has so far caused many warnings and bug reports. Developers were forgetting to update the map. Java supports fields in Enums and we were already using them to limit the frequency of reporting for certain messages. This patch moves the severity to the AuditLogType enum. NORMAL severity is considered default and does not have to be specified. It keeps the severities map and adds a test that compares the old map with the new field to make sure no mistake was made during the rewrite. Change-Id: I9c784a2f63d1c1d194f8f6712a39fa18a21b17da Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java 3 files changed, 540 insertions(+), 453 deletions(-) Approvals: Martin Sivák: Verified Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c784a2f63d1c1d194f8f6712a39fa18a21b17da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Sort domains when validating in engine-manage-domains
by emesika＠redhat.com 17 Feb '14

17 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: tools: Sort domains when validating in engine-manage-domains ...................................................................... tools: Sort domains when validating in engine-manage-domains Sort domains by name prior to validate action in engine-manage-domains. Change-Id: I6243fb8d6ae1fc34c31517559bb56b091cc10b1d Bug-Url: https://bugzilla.redhat.com/1057182 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 21 insertions(+), 12 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6243fb8d6ae1fc34c31517559bb56b091cc10b1d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Display empty list when failed to retrieve list of...
by derez＠redhat.com 17 Feb '14

17 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Display empty list when failed to retrieve list of iso images ...................................................................... webadmin: Display empty list when failed to retrieve list of iso images Change-Id: Ie0d148e89c4574a7e286b07ce1ce94a88996493c Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 10 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/24564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d148e89c4574a7e286b07ce1ce94a88996493c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in samples-uiplugins[master]: Introducing space-shooter plugin
by vszocs＠redhat.com 17 Feb '14

17 Feb '14

Vojtech Szocs has submitted this change and it was merged. Change subject: Introducing space-shooter plugin ...................................................................... Introducing space-shooter plugin Welcome, space traveler! This plugin is part of UI Plugins Crash Course: http://www.ovirt.org/Tutorial/UIPlugins/CrashCourse This plugin contains Alien Invasion, sample HTML5 game developed by Pascal Rettig and released under both GPL and MIT license: https://github.com/cykod/AlienInvasion Refer to Crash Course wiki for step-by-step tutorial. Check out README file for details on installation. Change-Id: I347b18ca57b7b41e4cdf42e528cf5a7aff60c583 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- A space-shooter-plugin/.gitignore A space-shooter-plugin/README A space-shooter-plugin/space-shooter-resources/dc-score.html A space-shooter-plugin/space-shooter-resources/game/GPL-LICENSE.txt A space-shooter-plugin/space-shooter-resources/game/MIT-LICENSE.txt A space-shooter-plugin/space-shooter-resources/game/README.md A space-shooter-plugin/space-shooter-resources/game/base.css A space-shooter-plugin/space-shooter-resources/game/engine.js A space-shooter-plugin/space-shooter-resources/game/game.js A space-shooter-plugin/space-shooter-resources/game/game.manifest A space-shooter-plugin/space-shooter-resources/game/images/sprites.png A space-shooter-plugin/space-shooter-resources/game/index.html A space-shooter-plugin/space-shooter-resources/modernizr.custom.js A space-shooter-plugin/space-shooter-resources/plugin.html A space-shooter-plugin/space-shooter.json 15 files changed, 1,490 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Doron Fediuck: Verified; Looks good to me, but someone else must approve Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I347b18ca57b7b41e4cdf42e528cf5a7aff60c583 Gerrit-PatchSet: 1 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0