February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: allow attaching iso and export SDs to local DC
by iheim＠redhat.com 09 Feb '14

09 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: allow attaching iso and export SDs to local DC ...................................................................... core: allow attaching iso and export SDs to local DC Attaching an ISO or export domain to local DC should not be blocked. Change-Id: I1ba6619b3b2858ab60ffb4df4824ae51467a2ecd Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/24232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ba6619b3b2858ab60ffb4df4824ae51467a2ecd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: guide me local cluster - added note on sd
by iheim＠redhat.com 09 Feb '14

09 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: guide me local cluster - added note on sd ...................................................................... webadmin: guide me local cluster - added note on sd Local Cluster/DC GuideMe dialog: * Replaced 'Fully configured and ready for use' message with 'Configuration completed' - as in shared storage. * Added a note that a local storage domain must be attached to the DC and activated. Change-Id: Ic2f3f59cdcf30721bbefc9bb84d97973faa36f99 Bug-Url: https://bugzilla.redhat.com/1023484 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml 6 files changed, 40 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/24227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2f3f59cdcf30721bbefc9bb84d97973faa36f99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Exclude read-only disks when creating a snapshot
by iheim＠redhat.com 09 Feb '14

09 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Exclude read-only disks when creating a snapshot ...................................................................... engine: Exclude read-only disks when creating a snapshot Change-Id: Ib05f61e5a61616908bd31aa0fc3ee3e477655e67 Bug-Url: https://bugzilla.redhat.com/1056169 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sergey Gotliv: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib05f61e5a61616908bd31aa0fc3ee3e477655e67 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Dialogue for attaching ISOs is not logically ordered
by iheim＠redhat.com 09 Feb '14

09 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Dialogue for attaching ISOs is not logically ordered ...................................................................... webadmin: Dialogue for attaching ISOs is not logically ordered In install host dialog the iso's listed are not ordered. Use the new RpmVersionUtils class to order the iso's in decreasing order of version and release. Change-Id: I80cf81769e34bf66e512ada7cb2a60efe88d11ab Bug-Url: https://bugzilla.redhat.com/1060636 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/24169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80cf81769e34bf66e512ada7cb2a60efe88d11ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: refactor failure to run vm flow - part 2
by ofrenkel＠redhat.com 09 Feb '14

09 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: refactor failure to run vm flow - part 2 ...................................................................... core: refactor failure to run vm flow - part 2 When migration fails and the VM get back to UP state in the source host, we do not want to treat the VM as VM that failed to run. Thus, MigrateVmCommand overrides RunVmCommandBase#failedToRunVm method and do not do anything in that case. Instead of override the whole RunVmCommandBase#failedToRunVm method, it is better to override just the RunVmCommandBase#processVmPoolOnStopVm method so the rest of the things that failedToRunVm do would be executed. In addition, the code in RunVmCommandBase#reportCompleted was simplified a bit. Change-Id: I6dc8e13f1ab932283557b3cbf16a34e72b9b3a69 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 2 files changed, 13 insertions(+), 11 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/23643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6dc8e13f1ab932283557b3cbf16a34e72b9b3a69 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: refactor failure to run vm flow - part 1
by ofrenkel＠redhat.com 09 Feb '14

09 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: refactor failure to run vm flow - part 1 ...................................................................... core: refactor failure to run vm flow - part 1 In most of the case when we fail to run VM we want to have proper audit message for it to be logged. That's why on almost every call to RunVmCommandBase#failedToRunVm method we log an audit message right before or after the call. One exception though is on the execution phase of RunVm - if the VM fails to run we do not need to log it, because it would be logged automatically by the infrastructure when the execution phase ends. This patch moves the call to log audit message to be within the failedToRunVm method. As for the case where the failedToRunVm method is called within the execution phase of RunVm, we'll also log it inside the failedToRunVm method, but set commandShouldBeLogged to false so the infrastructure will not log it again. This patch contains two additional minor refactoring changes. Change-Id: I74bd39fd5a4dc95694e9a059c40f7797b5e97623 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 3 files changed, 15 insertions(+), 16 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/23642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74bd39fd5a4dc95694e9a059c40f7797b5e97623 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: fixing integer out of range exception in search
by emesika＠redhat.com 09 Feb '14

09 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: fixing integer out of range exception in search ...................................................................... fixing integer out of range exception in search The change [1] introduced to return all rows when max=-1 generates an integer overflow in the calculation of the indexes used for paging. For example, in an environment with one data center running a query with "page 2" generates the following error: <fault><reason>Operation Failed</reason><detail>statementcallback; sql [select * from (select * from storage pool where ( id in (select storage pool with storage domain.id from storage pool with storage domain )) order by name asc ) as t1 offset (-2147483648 -1) limit 2147483647]; error: integer out of range; nested exception is org.postgresql.util.psqlexception: error: integer out of range</detail></fault> The problem is in SyntaxChecker.java, in line 954, where we do the following: result = StringFormat.format(pagingSyntax, (page - 1) * syntax.getMaxCount() + 1, syntax.getMaxCount()); This multiplication results in Integer.MAX_VALUE + 1, which overflows the integer and results in the value -2147483648. This affect all uses of queries with paging. [1] http://gerrit.ovirt.org/21375 Change-Id: I518dfdfff93dde28d9741d5e333c695239b7e7d2 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 2 files changed, 10 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I518dfdfff93dde28d9741d5e333c695239b7e7d2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Set proper severity to a failed command
by masayag＠redhat.com 09 Feb '14

09 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Set proper severity to a failed command ...................................................................... engine: Set proper severity to a failed command The audit log of commit networks changes failure should be changed to error to reflect its true nature. Change-Id: Ib7254bc1506d57edc158d034c7d06fe6e1e9c5c7 Bug-Url: https://bugzilla.redhat.com/1061727 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7254bc1506d57edc158d034c7d06fe6e1e9c5c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: build: switch to ant
by ydary＠redhat.com 09 Feb '14

09 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: build: switch to ant ...................................................................... packaging: build: switch to ant no reason at all to use maven, we can build our-self linked into the jasperreports-server instance. Change-Id: Idd3f37d7dc813c1b34693e50bdda3aabf2db9fb7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile A build.xml M ovirt-engine-reports.spec.in A ovirt-engine-reports/ChartsCustomizers/build.xml D ovirt-engine-reports/ChartsCustomizers/pom.xml A ovirt-engine-reports/CustomOvirtReportsQueryManipulator/build.xml D ovirt-engine-reports/CustomOvirtReportsQueryManipulator/pom.xml A ovirt-engine-reports/EngineAuthentication/build.xml D ovirt-engine-reports/EngineAuthentication/pom.xml A ovirt-engine-reports/ReportsLineBarChartTheme/build.xml D ovirt-engine-reports/ReportsLineBarChartTheme/pom.xml A ovirt-engine-reports/ReportsPieChartTheme/build.xml D ovirt-engine-reports/ReportsPieChartTheme/pom.xml A ovirt-engine-reports/ReportsStatus/build.xml D ovirt-engine-reports/ReportsStatus/pom.xml A ovirt-engine-reports/WebadminLineBarChartTheme/build.xml D ovirt-engine-reports/WebadminLineBarChartTheme/pom.xml D ovirt-engine-reports/pom.xml D pom.xml M version.mak 21 files changed, 266 insertions(+), 598 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd3f37d7dc813c1b34693e50bdda3aabf2db9fb7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Do not invoke CommitNetworkChanges if not needed
by masayag＠redhat.com 09 Feb '14

09 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Do not invoke CommitNetworkChanges if not needed ...................................................................... engine: Do not invoke CommitNetworkChanges if not needed There is no reason to sent persist network changes if no changes were detected via setupNetworks. Change-Id: Ie06d43ffaf899af4749bb1221764d40fab10a572 Bug-Url: https://bugzilla.redhat.com/1061724 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java 2 files changed, 12 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie06d43ffaf899af4749bb1221764d40fab10a572 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0