February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: userportal, webadmin: fix loading animation.
by iheim＠redhat.com 06 Feb '14

06 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: userportal,webadmin: fix loading animation. ...................................................................... userportal,webadmin: fix loading animation. - Fixed loading animation not showing when doing the following: - Select item in the system tree - Switch main tabs - Switch sub tabs. - Fixed loading animation being stuck when you first log in. Change-Id: I834253f33ae965eacd058f77f720035f45ec6f02 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1052149 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/ModelBoundPopupHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/SearchableTabModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/PropertyChangedEventArgs.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.java 9 files changed, 13 insertions(+), 11 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I834253f33ae965eacd058f77f720035f45ec6f02 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Dialogue for attaching ISOs is not logically ordered
by iheim＠redhat.com 06 Feb '14

06 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Dialogue for attaching ISOs is not logically ordered ...................................................................... webadmin: Dialogue for attaching ISOs is not logically ordered In install host dialog the iso's listed are not ordered. Use the new RpmVersionUtils class to order the iso's in decreasing order of version and release. Change-Id: I80cf81769e34bf66e512ada7cb2a60efe88d11ab Bug-Url: https://bugzilla.redhat.com/1060636 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/24168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80cf81769e34bf66e512ada7cb2a60efe88d11ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[cli_3.4]: cli: Show HTTP error page only in debug mode
by juan.hernandez＠redhat.com 06 Feb '14

06 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Show HTTP error page only in debug mode ...................................................................... cli: Show HTTP error page only in debug mode Currently when we try to connect to the engine and the connection fails with an HTTP error code we print the error document to the output. This is usually an HTML document, and not friendly for the user. This patch changes the CLI so that it will only print the error document when the -d option has been specified. Change-Id: Ic6a3a1ec12f343038a6b0ddac2fe875b46841471 Bug-Url: https://bugzilla.redhat.com/869283 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 07e5011adc02bad6684b5f457f85385d4b3ecc55) --- M src/ovirtcli/command/connect.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6a3a1ec12f343038a6b0ddac2fe875b46841471 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: Show HTTP error page only in debug mode
by juan.hernandez＠redhat.com 06 Feb '14

06 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Show HTTP error page only in debug mode ...................................................................... cli: Show HTTP error page only in debug mode Currently when we try to connect to the engine and the connection fails with an HTTP error code we print the error document to the output. This is usually an HTML document, and not friendly for the user. This patch changes the CLI so that it will only print the error document when the -d option has been specified. Change-Id: Ic6a3a1ec12f343038a6b0ddac2fe875b46841471 Bug-Url: https://bugzilla.redhat.com/869283 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/connect.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/24082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6a3a1ec12f343038a6b0ddac2fe875b46841471 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: Change version number to 3.5.0.0
by juan.hernandez＠redhat.com 06 Feb '14

06 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Change version number to 3.5.0.0 ...................................................................... cli: Change version number to 3.5.0.0 The 3.4 branch has been created for the next stable release. The master branch will use version 3.5.0.0 now. Change-Id: If03fdfd2cede2ed52b6f3a95f275cb8b95a2a312 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/23669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If03fdfd2cede2ed52b6f3a95f275cb8b95a2a312 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine, webadmin: synchronous multiple action
by awels＠redhat.com 06 Feb '14

06 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: engine, webadmin: synchronous multiple action ...................................................................... engine, webadmin: synchronous multiple action - Added a 'synchronous' version of run multiple actions to allow the frontend combine multiple single actions into one request and wait for the result of all of them. At the same time not disturb existing multiple actions that do NOT wait for the results. Change-Id: I935f4257e731de719540db9d79d5865537be228d Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperation.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProviderTest.java 10 files changed, 156 insertions(+), 67 deletions(-) Approvals: Alexander Wels: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I935f4257e731de719540db9d79d5865537be228d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : No email notification sent when host recovers from pr...
by emesika＠redhat.com 06 Feb '14

06 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: core : No email notification sent when host recovers from previously reported condition ...................................................................... core : No email notification sent when host recovers from previously reported condition There is no option in event manager to subscribe for 'Host is responsive' event. Users can choose to receive email notifications for several host conditions listed under "Host Event" section of event notifications. When a user has chosen a specific condition and such condition occurs the user receives an email notification. When such condition is resolved or disappears the user does not receive any email notification alerting him/her that the previously reported condition has been solved is no longer present. Change-Id: I93038f1ef81aa82643eb1b0e4bf9bc523a28b22c Bug-Url: https://bugzilla.redhat.com/1013631 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0610_map_vds_detected_to_event_map.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/23399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93038f1ef81aa82643eb1b0e4bf9bc523a28b22c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: build: move to ant drop maven and jboss modules
by ydary＠redhat.com 06 Feb '14

06 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: build: move to ant drop maven and jboss modules ...................................................................... packaging: build: move to ant drop maven and jboss modules Change-Id: I39550f694d7e8c37bbe189c1b9bfd944a5dad2e0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile D build-tools-root/jboss-modules-maven-plugin/pom.xml D build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/Module.java D build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/ModulesMojo.java D build-tools-root/pom.xml A build.xml M ovirt-engine-dwh.spec.in A ovirt-engine-dwh/advancedPersistentLookupLib/build.xml D ovirt-engine-dwh/advancedPersistentLookupLib/pom.xml D ovirt-engine-dwh/dependencies/pom.xml D ovirt-engine-dwh/dependencies/src/main/modules/org/ovirt/engine/dwh/main/module.xml D ovirt-engine-dwh/dependencies/src/main/modules/org/postgresql/main/module.xml A ovirt-engine-dwh/etltermination/build.xml D ovirt-engine-dwh/etltermination/pom.xml A ovirt-engine-dwh/historyETL/build.xml D ovirt-engine-dwh/historyETL/pom.xml D ovirt-engine-dwh/pom.xml A ovirt-engine-dwh/routines/build.xml D ovirt-engine-dwh/routines/pom.xml A packaging/bin/dwh-classpath.sh M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.conf.in M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/__init__.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/jboss.py D pom.xml M version.mak 27 files changed, 304 insertions(+), 1,011 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39550f694d7e8c37bbe189c1b9bfd944a5dad2e0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: doc: branding: style cleanups
by awels＠redhat.com 06 Feb '14

06 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: doc: branding: style cleanups ...................................................................... doc: branding: style cleanups Change-Id: I339f60c54aa6e54ff78d82e525b00dff8ba36026 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.branding 1 file changed, 35 insertions(+), 24 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I339f60c54aa6e54ff78d82e525b00dff8ba36026 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: disk live migrate - snapshot only on migrated disks
by derez＠redhat.com 06 Feb '14

06 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: core: disk live migrate - snapshot only on migrated disks ...................................................................... core: disk live migrate - snapshot only on migrated disks LiveSnapshotTaskHandler: Take a snapshot only on the migrated disks (by utilizing single disk snapshot feature). Change-Id: I21387ef38b5f86806b985b8dffb49d5b7952a628 Bug-Url: https://bugzilla.redhat.com/969789 Bug-Url: https://bugzilla.redhat.com/1056922 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 2 files changed, 21 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21387ef38b5f86806b985b8dffb49d5b7952a628 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0