February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core: Improve audit_log seach query
by iheim＠redhat.com 05 Feb '14

05 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Improve audit_log seach query ...................................................................... core: Improve audit_log seach query This patch improves the performance of the SearchQuery mechanism for the audit_log table. Change-Id: I396a90d63a10fc049a37e4792d3e558ff2a7fea3 Bug-Url: https://bugzilla.redhat.com/1061165 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 2 files changed, 46 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/24094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I396a90d63a10fc049a37e4792d3e558ff2a7fea3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: better glance template description when importing
by iheim＠redhat.com 05 Feb '14

05 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: better glance template description when importing ...................................................................... core: better glance template description when importing Change-Id: Ic753add97f59cc15c6521fb51ef762c5519c59fb Bug-Url: https://bugzilla.redhat.com/1053544 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> (cherry picked from commit 2781e93ab6572d140da2983b6ca97b1f7e6ac27d) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Federico Simoncelli: Looks good to me, but someone else must approve Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic753add97f59cc15c6521fb51ef762c5519c59fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: post ovirt-engine-3.4.0_beta2
by iheim＠redhat.com 05 Feb '14

05 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: post ovirt-engine-3.4.0_beta2 ...................................................................... packaging: post ovirt-engine-3.4.0_beta2 Updated version to 3.4.0-0.8 Change-Id: I4cce1c1eec59c2bba67a466eeded351de469db7f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M version.mak 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cce1c1eec59c2bba67a466eeded351de469db7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: ovirt-engine-3.4.0_beta2
by iheim＠redhat.com 05 Feb '14

05 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.4.0_beta2 ...................................................................... packaging: ovirt-engine-3.4.0_beta2 Updated version to be 3.4.0_beta2 Change-Id: I39b30f0f93cc260aa0ec44af51f0b40d45e83c53 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M version.mak 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39b30f0f93cc260aa0ec44af51f0b40d45e83c53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: db: made change to upgrade script to support el6
by ydary＠redhat.com 05 Feb '14

05 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: db: made change to upgrade script to support el6 ...................................................................... packaging: db: made change to upgrade script to support el6 Change-Id: I38e4a02ea924852dff4b8b00a593d71e10356f5f Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/dbscripts/upgrade/03_02_0090_updated_enums.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38e4a02ea924852dff4b8b00a593d71e10356f5f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Update VM - Validate Against Empty Domain (#1049080)
by oliel＠redhat.com 05 Feb '14

05 Feb '14

Ori Liel has submitted this change and it was merged. Change subject: restapi: Update VM - Validate Against Empty Domain (#1049080) ...................................................................... restapi: Update VM - Validate Against Empty Domain (#1049080) When updating VM, if <domain> supplied, verify that <domain><name> supplied as well. Bug-Url: http://bugzilla.redhat.com/1049080 Change-Id: If0555c4a26e4fe99058d490a3f5808248683a1fa Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/Messages.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/resources/org/ovirt/engine/api/restapi/logging/Messages.properties 3 files changed, 14 insertions(+), 0 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0555c4a26e4fe99058d490a3f5808248683a1fa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Empty String Validation (#1005296)
by oliel＠redhat.com 05 Feb '14

05 Feb '14

Ori Liel has submitted this change and it was merged. Change subject: restapi: Empty String Validation (#1005296) ...................................................................... restapi: Empty String Validation (#1005296) The generic input validation method in the API - validateParameters() uses reflection to invoke isSetX() for the given field. In the particular case of when the filed is a string, .isEmpty() check should be added. This is what this patch does. This fix is done in the context of a specific bug - 1005296 - which complains about empty <address> field passing validation when creating a new storage server connection Bug-Url: http://bugzilla.redhat.com/1005296 Change-Id: Ib0556725ad2ddc607d587c079bad451e4b74972d Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/ReflectionHelper.java 1 file changed, 25 insertions(+), 2 deletions(-) Approvals: Ori Liel: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0556725ad2ddc607d587c079bad451e4b74972d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: better glance template description when importing
by oourfali＠redhat.com 05 Feb '14

05 Feb '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: better glance template description when importing ...................................................................... core: better glance template description when importing Change-Id: Ic753add97f59cc15c6521fb51ef762c5519c59fb Bug-Url: https://bugzilla.redhat.com/1053544 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Federico Simoncelli: Looks good to me, but someone else must approve Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic753add97f59cc15c6521fb51ef762c5519c59fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: backward compatibility for monitor devices
by iheim＠redhat.com 05 Feb '14

05 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: backward compatibility for monitor devices ...................................................................... core: backward compatibility for monitor devices Before v3.1 we used to have just one item for monitors in the OVF file which contained an element called VirtualQuantity that represented the number of monitors the VM has. Now we're setting monitor device per monitor item in the OVF file, assuming that we have a separate item for each monitor. Since it doesn't hold for OVF that was created in versions which are earlier that 3.1, when we import a VM that was exported in version 3.0 and below, it will always have just one monitor device. The solution is that in case we import a VM that was exported in version which is early than 3.1, the number of monitor devices that will be created will be according to the VirtualQuantity value. Change-Id: I00a88f7856bc7f356f3ac5fd6eac8e432f659d09 Bug-Url: https://bugzilla.redhat.com/1060705 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/24046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00a88f7856bc7f356f3ac5fd6eac8e432f659d09 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix issues with splitter tabs
by iheim＠redhat.com 05 Feb '14

05 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Fix issues with splitter tabs ...................................................................... webadmin: Fix issues with splitter tabs - Fixed issue where if the system tree was minimized the tab to expand would cover the 'new' button of the active main tab. - Fixed issue where the tab of the splitter would show on top of a dialog if the dialog was dragged over it. Change-Id: I151fc3a76d9c6f55e265688fbecf965326774497 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabbedSplitLayout.css 3 files changed, 13 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I151fc3a76d9c6f55e265688fbecf965326774497 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0