March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: engine: Collect stats before activating host
by oourfali＠redhat.com 24 Mar '14

24 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Collect stats before activating host ...................................................................... engine: Collect stats before activating host When the host moves to non operational due to a required interface in down state, the host statistics should be collected and examined before attempting to activate the host. Change-Id: Id3de8a3ccb1084f8be8f9c3213f797146f8f0b36 Bug-Url: https://bugzilla.redhat.com/1070260 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java 3 files changed, 17 insertions(+), 16 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/26015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3de8a3ccb1084f8be8f9c3213f797146f8f0b36 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor cleanup in migration related classes
by ahadas＠redhat.com 24 Mar '14

24 Mar '14

Arik Hadas has submitted this change and it was merged. Change subject: core: minor cleanup in migration related classes ...................................................................... core: minor cleanup in migration related classes - Remove redundant setting of migrating-to-vds field in MigrateVmCommand - Remove '_' prefix in MigrateVDSCommandParameters field names - Fix indentation in MigrateVDSCommand - Extract the invocation of MigrateVDSCommand from MigrateVmCommand#perform to separate method in order to make the perform method more readable Change-Id: If7e8f60d8e9accf2618ed10fa17f74e56e0d1ae9 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java 3 files changed, 31 insertions(+), 33 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/25572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7e8f60d8e9accf2618ed10fa17f74e56e0d1ae9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fixing NPE in case a directory was not found for user.
by yzaslavs＠redhat.com 24 Mar '14

24 Mar '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing NPE in case a directory was not found for user. ...................................................................... core: Fixing NPE in case a directory was not found for user. This can happen if the domain was removed by engine-manage-domains (the users for the directory are not removed) Change-Id: Ief4761b9234f3839a1dba1eefbf871ae2bae3c69 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief4761b9234f3839a1dba1eefbf871ae2bae3c69 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: new pool dialog should not contain Blank template
by oourfali＠redhat.com 23 Mar '14

23 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: new pool dialog should not contain Blank template ...................................................................... webadmin: new pool dialog should not contain Blank template This regression has been introduced by: 604d22dc036d1f5a4431c8247ce246d0c0a0c109 Fixed by moving back the code to filter out the Blank template from the new pool dialog. Change-Id: I6acdd3427e5c11b854bfd4c9c209c55da12b88a5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066646 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified Gustavo Frederico Temple Pedrosa: Looks good to me, but someone else must approve Gilad Chaplik: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6acdd3427e5c11b854bfd4c9c209c55da12b88a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Filter domains on disk move dialog from main disk tab
by oourfali＠redhat.com 23 Mar '14

23 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Filter domains on disk move dialog from main disk tab ...................................................................... webadmin: Filter domains on disk move dialog from main disk tab Since we currently do not support live storage migration from block domains to file domains and vice versa, the destination domains list will be filtered when moving a disk that is plugged to a running VM (from the main disks tab) Change-Id: Ia28d3acd7ceeaff07745f16af920f8d225e485c7 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1073343 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 4 files changed, 59 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia28d3acd7ceeaff07745f16af920f8d225e485c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix bug in a add floating disk
by oourfali＠redhat.com 23 Mar '14

23 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix bug in a add floating disk ...................................................................... webadmin: Fix bug in a add floating disk Change-Id: Ie354b70ca88374cc054f84d7a3488742cb65727d Bug-Url: https://bugzilla.redhat.com/1079741 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie354b70ca88374cc054f84d7a3488742cb65727d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: ux: allow using password authentication on foreman hosts
by oourfali＠redhat.com 23 Mar '14

23 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: ux: allow using password authentication on foreman hosts ...................................................................... ux: allow using password authentication on foreman hosts Previous patch removed the ability to use password authentication with external hosts provided by Foreman. This patch fixes that issue by hiding this option only when installation relevant properties are to be hidden. Change-Id: I26e351f0560ac4fe8f45ec2314ef4a6aa7ddafb9 Bug-Url: https://bugzilla.redhat.com/1079072 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/26003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26e351f0560ac4fe8f45ec2314ef4a6aa7ddafb9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added a number of VMs in clusters general details ...
by tnisan＠redhat.com 23 Mar '14

23 Mar '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Added a number of VMs in clusters general details sub tab ...................................................................... webadmin: Added a number of VMs in clusters general details sub tab Change-Id: I679f4b44aec3614e3ec046affc7a6dc5437b26e4 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/913234 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java 4 files changed, 33 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I679f4b44aec3614e3ec046affc7a6dc5437b26e4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: DAO test for testGetVmsCountByClusterId in VdsGroupDao
by tnisan＠redhat.com 23 Mar '14

23 Mar '14

Tal Nisan has submitted this change and it was merged. Change subject: core: DAO test for testGetVmsCountByClusterId in VdsGroupDao ...................................................................... core: DAO test for testGetVmsCountByClusterId in VdsGroupDao Change-Id: I604f25e13b7f13cdd2e1f1b32e478c83b7e923cc Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Related-To: https://bugzilla.redhat.com/913234 --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I604f25e13b7f13cdd2e1f1b32e478c83b7e923cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Added a query to return the number of VMs in a cluster
by tnisan＠redhat.com 23 Mar '14

23 Mar '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Added a query to return the number of VMs in a cluster ...................................................................... core: Added a query to return the number of VMs in a cluster Change-Id: I04b7bf0c6edf4e55d0e5d7ce5e7030ba974de5e2 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Related-To: https://bugzilla.redhat.com/913234 --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNumberOfVmsInVdsGroupByVdsGroupIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M packaging/dbscripts/vds_groups_sp.sql 5 files changed, 40 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04b7bf0c6edf4e55d0e5d7ce5e7030ba974de5e2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0