March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: custom snapshot preview - default disks selection
by derez＠redhat.com 12 Mar '14

12 Mar '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: custom snapshot preview - default disks selection ...................................................................... webadmin: custom snapshot preview - default disks selection Custom snapshot dialog: if a partial snapshot has been pre-selected, the missing disks should be selected on the active snapshot by default. Change-Id: I78c1c11802c72c8eef91a25905078ce309dd03ea Bug-Url: https://bugzilla.redhat.com/1071791 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PreviewSnapshotModel.java 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78c1c11802c72c8eef91a25905078ce309dd03ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : User is not able to see newly added permissions on ob...
by emesika＠redhat.com 12 Mar '14

12 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: core : User is not able to see newly added permissions on object if he inherited this permission on that object. ...................................................................... core : User is not able to see newly added permissions on object if he inherited this permission on that object. If user inherit some permissions on some object, than if he try to add new permissions to object that he inherit permission from, he is not able to see this newly added permissions. Fixes the case where a single role TemplateAdmin can create multiple role_type entries in permissions_view Change-Id: I60d0c320453fa30554b6ac63e6652729dd0735d6 Bug-Url: https://bugzilla.redhat.com/877906 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/dbscripts/multi_level_administration_sp.sql 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/25094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60d0c320453fa30554b6ac63e6652729dd0735d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: disks tab - fix type selection after sign out
by derez＠redhat.com 12 Mar '14

12 Mar '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disks tab - fix type selection after sign out ...................................................................... webadmin: disks tab - fix type selection after sign out MainTabDiskView -> use CommonModelManager singleton instance instead of saving it as a class member (needed for fixing disk type selection after signing out). Change-Id: I11b1489db03608fddf1aa24fa6664f6c3ab5abb3 Bug-Url: https://bugzilla.redhat.com/1073574 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/25538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11b1489db03608fddf1aa24fa6664f6c3ab5abb3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: disks - prevent redundant search manipulation
by derez＠redhat.com 12 Mar '14

12 Mar '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disks - prevent redundant search manipulation ...................................................................... webadmin: disks - prevent redundant search manipulation Ensure that the selected main tab (in commonModel) is DiskListModel. Change-Id: I0505bbea25e16f7e663689f4baa66df103e8b533 Bug-Url: https://bugzilla.redhat.com/1073574 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/25537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0505bbea25e16f7e663689f4baa66df103e8b533 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: snapshots sub-tab - ensure model listeners
by derez＠redhat.com 12 Mar '14

12 Mar '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: snapshots sub-tab - ensure model listeners ...................................................................... webadmin: snapshots sub-tab - ensure model listeners VMs -> Snapshots sub-sub: Ensure model listeners existence after sign out. Re-adding the listeners in presenter's onUiCommonInit method as VmSnapshotListModel is being initialized on sign in (along with the other list models: VmListModel -> initDetailModels). Change-Id: I006023de74150754d8c79f95b79eb9ad0158b055 Bug-Url: https://bugzilla.redhat.com/1058618 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/AbstractModelBoundTableWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/virtualMachine/SubTabVirtualMachineSnapshotPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineSnapshotView.java 4 files changed, 41 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I006023de74150754d8c79f95b79eb9ad0158b055 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: snapshot sub-tab - avoid redundant update
by derez＠redhat.com 12 Mar '14

12 Mar '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: snapshot sub-tab - avoid redundant update ...................................................................... webadmin: snapshot sub-tab - avoid redundant update VmSnapshotListModel -> updateActionAvailability: avoid update when getItems is null (to prevent an NPE). Change-Id: If3469c20f2a4caceb96b40bbf542baacbadcf30e Bug-Url: https://bugzilla.redhat.com/1058618 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3469c20f2a4caceb96b40bbf542baacbadcf30e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: LunDAODbFacadeImpl - use createFullParametersMapper
by derez＠redhat.com 12 Mar '14

12 Mar '14

Daniel Erez has submitted this change and it was merged. Change subject: core: LunDAODbFacadeImpl - use createFullParametersMapper ...................................................................... core: LunDAODbFacadeImpl - use createFullParametersMapper LunDAODbFacadeImpl -> getBatchMapper: use createFullParametersMapper method instead of adding values manually. Change-Id: I472798776849b4ab266329acc490b4685317a61f Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I472798776849b4ab266329acc490b4685317a61f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: normalize capitalization of lun_id column
by derez＠redhat.com 12 Mar '14

12 Mar '14

Daniel Erez has submitted this change and it was merged. Change subject: core: normalize capitalization of lun_id column ...................................................................... core: normalize capitalization of lun_id column Normalize to 'lun_id' in the relevant DAOs for accommodating with the naming in 'luns' table Change-Id: I533df11f2a5ef52920af4f5ce029f31d83f9c492 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 11 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I533df11f2a5ef52920af4f5ce029f31d83f9c492 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Networks with role configured with DHCP in nic
by iheim＠redhat.com 12 Mar '14

12 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Networks with role configured with DHCP in nic ...................................................................... engine: Networks with role configured with DHCP in nic Network with roles must have an IP address in order for the host to be operational (either for display or for migration purposes). A mass operation to configure networks on various hosts, where some of the networks might have roles, is by setting the boot protocol to DHCP. This will configure the networks on the hosts in a way that will enable to IP assignment. If the DHCP request fails, there is a change the network will not be configure on the host. This will cause the host to be non-operational, with a simple resolution for the nature of the problem. Change-Id: I3ee53ec1f354ea766cea59977e869f97c2be94df Bug-Url: https://bugzilla.redhat.com/1073043 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java 2 files changed, 23 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/25666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ee53ec1f354ea766cea59977e869f97c2be94df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Attached network to host for unused labeled network
by iheim＠redhat.com 12 Mar '14

12 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Attached network to host for unused labeled network ...................................................................... engine: Attached network to host for unused labeled network The engine should support configuring a labeled network on hosts, if the network was already labeled, but never configured on any host. Change-Id: I646dd1901b2e75b1b6bebc5562c9cc2e8377425d Bug-Url: https://bugzilla.redhat.com/1074258 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 18 insertions(+), 13 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/25665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I646dd1901b2e75b1b6bebc5562c9cc2e8377425d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0