March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Display VncKeyboardLayout only for VNC display
by tjelinek＠redhat.com 07 Mar '14

07 Mar '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Display VncKeyboardLayout only for VNC display ...................................................................... webadmin: Display VncKeyboardLayout only for VNC display Added missing ModeSwitchingVisibilityRenderer to vncKeyboardLayoutEditor. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057591 Change-Id: I39b48037d5ea4ef2a909cd7ff0e79d1a7690b5e1 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/25483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39b48037d5ea4ef2a909cd7ff0e79d1a7690b5e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[master]: fix interactive option
by obasan＠redhat.com 06 Mar '14

06 Mar '14

Ohad Basan has submitted this change and it was merged. Change subject: fix interactive option ...................................................................... fix interactive option Bug-Url: https://bugzilla.redhat.com/1073418 Change-Id: I1d14a0860f8ce5b7f454c6ef590b8e0efbeb9003 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M centos/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/engine-setup-yad.sh M fedora/oVirtLiveFiles/engine-setup-yad.sh 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Ohad Basan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d14a0860f8ce5b7f454c6ef590b8e0efbeb9003 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: allow values higher than 9 minutes for CpuOverCommit...
by gchaplik＠redhat.com 06 Mar '14

06 Mar '14

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: allow values higher than 9 minutes for CpuOverCommitDuration ...................................................................... engine: allow values higher than 9 minutes for CpuOverCommitDuration Change-Id: I1b8b4f7b4f8ef76dc9774dc1620e6bb76aaf2f65 Bug-Url: https://bugzilla.redhat.com/1071200 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_0100_allow_values_higher_9_for_cpuovercommit.sql 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jiří Moskovčák: Verified Doron Fediuck: Looks good to me, but someone else must approve Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b8b4f7b4f8ef76dc9774dc1620e6bb76aaf2f65 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sven Kieske <svenkieskemittwald(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Don't assume that Lists are ArrayLists
by juan.hernandez＠redhat.com 06 Mar '14

06 Mar '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't assume that Lists are ArrayLists ...................................................................... restapi: Don't assume that Lists are ArrayLists Currently there are a few places where we assume that the result returned by the backend is an ArrayList. This isn't necessary true, in particular it isn't true for lists of users and groups returned by directories, as they will be special empty lists. This patch changes the RESTAPI so that it uses the List interface instead of the ArrayList class. Change-Id: Iff2d2a7b558f111312b6299ce7ed95993deb68ca Bug-Url: https://bugzilla.redhat.com/1073359 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainUsersResource.java 3 files changed, 3 insertions(+), 9 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff2d2a7b558f111312b6299ce7ed95993deb68ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Set boot order to more then one CDROM if selected
by shavivi＠redhat.com 06 Mar '14

06 Mar '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: Set boot order to more then one CDROM if selected ...................................................................... engine: Set boot order to more then one CDROM if selected When dealing with more then one CDROM we set only the first in list if user select boot order from CDROM, which can cause a problem if the first CDROM is payload or cloud-init which are not bootable. When setting all CDROM to be bootable qemu will try to boot from one of them. Change-Id: I7d4783f084623bc59096d87514a6f143e056d5a2 Bug-Url: https://bugzilla.redhat.com/1064927 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d4783f084623bc59096d87514a6f143e056d5a2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: glance import as template should fail on old DCs
by oourfali＠redhat.com 06 Mar '14

06 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: glance import as template should fail on old DCs ...................................................................... core: glance import as template should fail on old DCs If the DC compatibility level is less than 3.4 then the glance import should fail on canDoAction. This patch adds this validation Change-Id: I4b975d2f8d540af6f0a3c8e4de9296173950f9ce Bug-Url: https://bugzilla.redhat.com/1072023 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 24 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b975d2f8d540af6f0a3c8e4de9296173950f9ce Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add ability to call plsql function with different mappers
by emesika＠redhat.com 06 Mar '14

06 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Add ability to call plsql function with different mappers ...................................................................... core: Add ability to call plsql function with different mappers We are calling GetTagVmByTagIdAndByvmId plsql function in getTagTemplateByTagIdAndByTemplateId and getTagVmByTagIdAndByVmId with different row mappers. This patch sets the rowmapper in the SimpleJdbcCall which is saved in the map by function name Change-Id: I003e2b054db3eb406984fd39b59a346c7fd85492 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java 1 file changed, 15 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I003e2b054db3eb406984fd39b59a346c7fd85492 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: fix double naming of one stage
by sbonazzo＠redhat.com 06 Mar '14

06 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: fix double naming of one stage ...................................................................... packaging: setup: fix double naming of one stage Fix double naming of one stage introduced with 15b69cc Change-Id: I9648dced383a75768a7a5908cafe924c6810a40f Related-To: https://bugzilla.redhat.com/1034726 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 95f82cf4b16d3a2a76e362b4cee9999088169985) --- M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9648dced383a75768a7a5908cafe924c6810a40f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.1]: packaging: setup: fix double naming of one stage
by sbonazzo＠redhat.com 06 Mar '14

06 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: fix double naming of one stage ...................................................................... packaging: setup: fix double naming of one stage Fix double naming of one stage introduced with 15b69cc Change-Id: I9648dced383a75768a7a5908cafe924c6810a40f Related-To: https://bugzilla.redhat.com/1034726 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 95f82cf4b16d3a2a76e362b4cee9999088169985) --- M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9648dced383a75768a7a5908cafe924c6810a40f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: libvirt and system PKI
by sbonazzo＠redhat.com 06 Mar '14

06 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: libvirt and system PKI ...................................................................... packaging: setup: libvirt and system PKI Copy generated vdsm pki also to libvirt. Copy generated vdsm cacert to system-wide /etc/pki/CA/cacert.pem . Reorder so that vdsm pki generation happens before configuring libvirt for vdsm, so that it's configured with tls. Fix selinux contexts for libvirt-spice pki if enabled. Bug-Url: https://bugzilla.redhat.com/1073446 Change-Id: I74f44c46e6720ca8c62af1afa6df4a5d7c013b49 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/mixins.py M src/plugins/ovirt-hosted-engine-setup/core/conf.py M src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py 5 files changed, 143 insertions(+), 22 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/25473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74f44c46e6720ca8c62af1afa6df4a5d7c013b49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0