March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.0]: packaging: services: don't enable services on install
by gpadgett＠redhat.com 04 Mar '14

04 Mar '14

Greg Padgett has submitted this change and it was merged. Change subject: packaging: services: don't enable services on install ...................................................................... packaging: services: don't enable services on install Avoid to enable HA services automatically after rpm install. It should be done by hosted-engine --deploy. Change-Id: I9064a8a7bc28d0e581f2311d11b9fdca375dd3b5 Related-To: https://bugzilla.redhat.com/1066373 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified Greg Padgett: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9064a8a7bc28d0e581f2311d11b9fdca375dd3b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: check existing VMs running
by sbonazzo＠redhat.com 04 Mar '14

04 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: check existing VMs running ...................................................................... packaging: setup: check existing VMs running Check if there is already any VM reported as running by VDSM and fail if it exists. Change-Id: Iae7b88d5c56bd76b87cfcdef29e629a3a30b6491 Bug-Url: https://bugzilla.redhat.com/1066373 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 15b69cc68a9f12084fa9dc235c520e57961e42c1) --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py 3 files changed, 27 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae7b88d5c56bd76b87cfcdef29e629a3a30b6491 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: fix remote database typo
by sbonazzo＠redhat.com 04 Mar '14

04 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: fix remote database typo ...................................................................... packaging: setup: fix remote database typo Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072307 Change-Id: I9b8876f5699c7abd8953ff01295111b4a983a1aa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b8876f5699c7abd8953ff01295111b4a983a1aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: allow putting host on maintenance if lonley in dc also...
by iheim＠redhat.com 04 Mar '14

04 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: core: allow putting host on maintenance if lonley in dc also for SPM host ...................................................................... core: allow putting host on maintenance if lonley in dc also for SPM host fixup to commit 998c17 which introduced this ability but didn't cleanup irsBrokerCommand cached mCurrentVdsId value, which leaded to keep requesting for SPMStatus from unreachable or deleted host. Change-Id: Ib0dc1bb6e4318fc1465b51652d519574a3af4f99 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1055455 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 2 files changed, 37 insertions(+), 35 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Bronhaim: Verified -- To view, visit http://gerrit.ovirt.org/25307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0dc1bb6e4318fc1465b51652d519574a3af4f99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: post 3.4.0 branching
by iheim＠redhat.com 04 Mar '14

04 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: post 3.4.0 branching ...................................................................... packaging: post 3.4.0 branching Bug-Url: https://bugzilla.redhat.com/1069193 Change-Id: Ic0133e74a4f4c6c42ee7a8da7eaf954c40443c5f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dependencies/pom.xml M backend/manager/modules/authentication/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 45 files changed, 46 insertions(+), 46 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0133e74a4f4c6c42ee7a8da7eaf954c40443c5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: wedamdin: NPE when removing label from interface/bond
by alkaplan＠redhat.com 04 Mar '14

04 Mar '14

Alona Kaplan has submitted this change and it was merged. Change subject: wedamdin: NPE when removing label from interface/bond ...................................................................... wedamdin: NPE when removing label from interface/bond When removing label from a nic with no 'network labels' attahced to it there was NPE. Added safe check to fix this issue. Change-Id: I18619a212503731586c68dc414e51ae12e52fefa Bug-Url: https://bugzilla.redhat.com/1063762 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18619a212503731586c68dc414e51ae12e52fefa Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add missing engine lock in run once
by ofrenkel＠redhat.com 04 Mar '14

04 Mar '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: add missing engine lock in run once ...................................................................... core: add missing engine lock in run once RunVmOnce should take the engine lock that RunVm takes, but it didn't take locks at all because the LockIdNameAttribute annotation was missing. Thus, the LockIdNameAttribute annotation is added to RunVmOnce. Change-Id: Iff7c176ad3741b501df4ce7fab08b89c11a33be2 Bug-Url: https://bugzilla.redhat.com/1071997 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/25277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff7c176ad3741b501df4ce7fab08b89c11a33be2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: extract parameters initialization from vdsUpEvent
by ofrenkel＠redhat.com 04 Mar '14

04 Mar '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: extract parameters initialization from vdsUpEvent ...................................................................... core: extract parameters initialization from vdsUpEvent Extract the part that initialize the parameters for the migrate VM to server commands from VdsEventListener#vdsUpEvent to make it more readable. In addition, change MigrateBrokerVDSCommand to create the migrate-info map right before invoking VDSM verb as this information is not needed until then and we do not need to hold it as class member. Minor cleanup in MigrateVDSCommand is also included in this patch. Change-Id: I54501c64f9b0ff3cd2bb80d457a597d01328b8d5 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 4 files changed, 43 insertions(+), 33 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/24798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54501c64f9b0ff3cd2bb80d457a597d01328b8d5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: edited ic query-host_type
by ydary＠redhat.com 04 Mar '14

04 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: edited ic query-host_type ...................................................................... reports: edited ic query-host_type I edited the, host_type, input control query, so it will be more readable and added comments. Change-Id: I133e38b83976c318a45f550c2aaccd0ee30ada97 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/host_ic/P_Host_Type.xml 1 file changed, 106 insertions(+), 39 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I133e38b83976c318a45f550c2aaccd0ee30ada97 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: change decrease pending memory & cpu places
by ofrenkel＠redhat.com 04 Mar '14

04 Mar '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: change decrease pending memory & cpu places ...................................................................... core: change decrease pending memory & cpu places We used to decrease the pending memory & CPU in 3 places: 1. RunVmCommandBase#onPoweringUp: we wanted to decrease the pending resources as soon as we know the VM is running, i.e when it reaches the POWERING_UP state 2. RunVmCommandBase#rerun: when the VM fails to run on a host, we decreased the pending resources on that host 3. MigrateVmCommand#reportCompleted: in 48af8ddc we added it, so the pending resources will be decreased when migration is done as well. This patch changes the locations where the pending memory & CPU is decreased such that locations #1 and #2 that mentioned above will remain, and instead of the third location we're now decreasing them in RunVmCommandBase#runningSucceeded & RunVmCommandBase#runningFailed. reportCompleted is not supposed to be overridden and is not the place where the reduction should be made. This method should only finish the monitoring job/step. The runningSucceeded & runningFailed are the more appropriate places for that. A positive side-effect of this change is that we're now decreasing the pending memory & CPU in other flows it should be decreased in, such as when resume paused VM which was paused for more than 1 minute. Change-Id: I8a3a10864d64e67a36942e01869b8f41c67f032a Bug-Url: https://bugzilla.redhat.com/1049321 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 2 files changed, 16 insertions(+), 17 deletions(-) Approvals: Gilad Chaplik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/23644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a3a10864d64e67a36942e01869b8f41c67f032a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0