March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: db: cleanup: remove -f VERSION feature
by emesika＠redhat.com 02 Mar '14

02 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: db: cleanup: remove -f VERSION feature ...................................................................... db: cleanup: remove -f VERSION feature apparently not used any more. Change-Id: I24efcb7546ee496279fda7d111ae0d956f01e6ce Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/dbfunctions.sh M packaging/dbscripts/upgrade.sh 2 files changed, 2 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24efcb7546ee496279fda7d111ae0d956f01e6ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: cleanup: remove unused fn_db_set_dbobjects_ownership
by emesika＠redhat.com 02 Mar '14

02 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: db: cleanup: remove unused fn_db_set_dbobjects_ownership ...................................................................... db: cleanup: remove unused fn_db_set_dbobjects_ownership Change-Id: I0a87b65a237527a84ff2a9382781e5f48923008e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/dbcustomfunctions.sh 1 file changed, 0 insertions(+), 23 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a87b65a237527a84ff2a9382781e5f48923008e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: database: move storage validations to vali...
by emesika＠redhat.com 02 Mar '14

02 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: packaging: setup: database: move storage validations to validation ...................................................................... packaging: setup: database: move storage validations to validation Change-Id: I4a7e02d517927f1034b8e6eb717884f3e6c28a4e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a7e02d517927f1034b8e6eb717884f3e6c28a4e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: cleanup: move public interface to top
by emesika＠redhat.com 02 Mar '14

02 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: db: cleanup: move public interface to top ...................................................................... db: cleanup: move public interface to top Change-Id: I9174019cce81acf7e2085a9dcf8070f5df78c929 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/dbfunc-common.sh 1 file changed, 233 insertions(+), 244 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9174019cce81acf7e2085a9dcf8070f5df78c929 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: cleanup: rename function names
by emesika＠redhat.com 02 Mar '14

02 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: db: cleanup: rename function names ...................................................................... db: cleanup: rename function names dbfunc_common_ - public interface dbfunc_common_hook_ - hooks _dbfunc_common_ - private custom functions are provided as hooks, the default implementation a void hook, custom can override it. reorder public interface to have <prefix>_<group>_<verb> Change-Id: Icce88f1d8f19da83c757f94ad661cb676bd70274 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/cleandb.sh M packaging/dbscripts/create_schema.sh M packaging/dbscripts/dbfunc-common.sh M packaging/dbscripts/dbfunc-custom.sh M packaging/dbscripts/refreshStoredProcedures.sh M packaging/dbscripts/unlock_entity.sh M packaging/dbscripts/upgrade.sh 7 files changed, 101 insertions(+), 73 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icce88f1d8f19da83c757f94ad661cb676bd70274 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: cleanup: rename commons to consistent prefix
by emesika＠redhat.com 02 Mar '14

02 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: db: cleanup: rename commons to consistent prefix ...................................................................... db: cleanup: rename commons to consistent prefix dbfunctions.sh -> dbfunc-common.sh dbcustomfunctions.sh -> dbfunc-custom.sh Change-Id: I76ee5311eaabf5d7b1b69e780725979730fbca41 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/cleandb.sh M packaging/dbscripts/create_schema.sh R packaging/dbscripts/dbfunc-common.sh R packaging/dbscripts/dbfunc-custom.sh M packaging/dbscripts/refreshStoredProcedures.sh M packaging/dbscripts/unlock_entity.sh M packaging/dbscripts/upgrade.sh 7 files changed, 6 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76ee5311eaabf5d7b1b69e780725979730fbca41 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: cleanup: psql usage
by emesika＠redhat.com 02 Mar '14

02 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: db: cleanup: psql usage ...................................................................... db: cleanup: psql usage 1. all command to use single psql wrapper 2. parser friendly psql wrapper without need to perform text manipulation including escaping. 3. extract base psql functionality into own dbfunc-base.sh to be used by dbutils as well. 4. prefix dbfunc variables to avoid duplications and have clearer code. 5. reformat complex sqls to multi line notation. 6. remove the no md5 parameter in favor for md5dir exist/absent. 7. boolean as -z -n 8. minor additional cleanups. Change-Id: Ib93ad2ca4d35fe3f44e3f8915182778a9fe6ed66 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/cleandb.sh M packaging/dbscripts/create_schema.sh M packaging/dbscripts/dbcustomfunctions.sh A packaging/dbscripts/dbfunc-base.sh M packaging/dbscripts/dbfunctions.sh M packaging/dbscripts/refreshStoredProcedures.sh M packaging/dbscripts/unlock_entity.sh M packaging/dbscripts/upgrade.sh M packaging/setup/dbutils/changedbowner.sh D packaging/setup/dbutils/common.sh A packaging/setup/dbutils/dbfunc-base.sh M packaging/setup/dbutils/encodingvalidator.sh M packaging/setup/dbutils/fkvalidator.sh M packaging/setup/dbutils/taskcleaner.sh M packaging/setup/dbutils/validatedb.sh M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py 18 files changed, 631 insertions(+), 506 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib93ad2ca4d35fe3f44e3f8915182778a9fe6ed66 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: cleanup: add die and usage
by emesika＠redhat.com 02 Mar '14

02 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: db: cleanup: add die and usage ...................................................................... db: cleanup: add die and usage Change-Id: I5d708d1855c93f88fcba97c04660b2e4f5f47a6e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/dbcustomfunctions.sh M packaging/dbscripts/dbfunctions.sh M packaging/dbscripts/unlock_entity.sh M packaging/setup/dbutils/changedbowner.sh M packaging/setup/dbutils/common.sh M packaging/setup/dbutils/encodingvalidator.sh M packaging/setup/dbutils/fkvalidator.sh M packaging/setup/dbutils/taskcleaner.sh 8 files changed, 52 insertions(+), 59 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d708d1855c93f88fcba97c04660b2e4f5f47a6e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: cleanup: trivial issues and bashism removal
by emesika＠redhat.com 02 Mar '14

02 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: db: cleanup: trivial issues and bashism removal ...................................................................... db: cleanup: trivial issues and bashism removal 1. remove bash specific usage, will enable us to drop bash dependency from product. 2. cleanup non consistent indents. 3. add {} all over. 4. add "" all over. 5. add local whenever possible. 6. proper cleanup of temporary files. 7. remove unused DEBUG. 8. misc trivial fixups. 9. argument reorg. no change in functionality. tested with dash and bash. Change-Id: I6e937b290ad966e9d574596f4ca4a7c6c4292a43 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.developer M packaging/dbscripts/cleandb.sh M packaging/dbscripts/create_schema.sh M packaging/dbscripts/dbcustomfunctions.sh M packaging/dbscripts/dbfunctions.sh M packaging/dbscripts/refreshStoredProcedures.sh M packaging/dbscripts/unlock_entity.sh M packaging/dbscripts/upgrade.sh M packaging/setup/dbutils/changedbowner.sh M packaging/setup/dbutils/common.sh M packaging/setup/dbutils/encodingvalidator.sh M packaging/setup/dbutils/fkvalidator.sh M packaging/setup/dbutils/taskcleaner.sh M packaging/setup/dbutils/validatedb.sh 14 files changed, 651 insertions(+), 708 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e937b290ad966e9d574596f4ca4a7c6c4292a43 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: cleanup: move task clean into custom
by emesika＠redhat.com 02 Mar '14

02 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: db: cleanup: move task clean into custom ...................................................................... db: cleanup: move task clean into custom this is engine specific. Change-Id: If4c099e23dd1903171cdce71f5c410ce3f05320a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/dbfunc-common.sh M packaging/dbscripts/dbfunc-custom.sh M packaging/dbscripts/upgrade.sh 3 files changed, 15 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4c099e23dd1903171cdce71f5c410ce3f05320a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0