April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Add header to each response.
by awels＠redhat.com 16 Apr '14

16 Apr '14

Alexander Wels has submitted this change and it was merged. Change subject: engine: Add header to each response. ...................................................................... engine: Add header to each response. - This patch adds headers to each response with the option of defining extra headers in the web.xml. There are 3 headers added by default. - X-FRAME-OPTIONS: SAMEORIGIN (To stop click jacking) - X-CONTENT-TYPE-OPTIONS: NOSNIFF (To stop mime type attacks) - X-XSS-PROTECTION: 1; MODE=BLOCK (To enable IE XSS filter) Change-Id: I4e9c26dddd0d0300d6b3d078ae763b78600f25d1 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/HeaderFilter.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/HeaderFilterTest.java M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/frontend/src/main/resources/META-INF/web-fragment.xml M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml 8 files changed, 258 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e9c26dddd0d0300d6b3d078ae763b78600f25d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Only one method to set mapping locator
by juan.hernandez＠redhat.com 16 Apr '14

16 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Only one method to set mapping locator ...................................................................... restapi: Only one method to set mapping locator The method that sets the mapping loator has been recently moved to the backend base resource class, so it is no longer necessary to have it in other resources and to explicitly check the type of the resource when calling it. Change-Id: I28595e36feb41bf2915e2fb0b28f78d7b3b65f74 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java 2 files changed, 1 insertion(+), 14 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28595e36feb41bf2915e2fb0b28f78d7b3b65f74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: userportal, webadmin: refresh session on login
by oourfali＠redhat.com 16 Apr '14

16 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: userportal, webadmin: refresh session on login ...................................................................... userportal, webadmin: refresh session on login - This patch creates a new session when a user attempts to log in. This enhances the session management. Change-Id: I3df427683c924f10cb59f4af1dd067fcfd21a8f2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1077446 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3df427683c924f10cb59f4af1dd067fcfd21a8f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: ListModelTypeAheadListBox to not always add to val...
by oourfali＠redhat.com 16 Apr '14

16 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: ListModelTypeAheadListBox to not always add to valid values ...................................................................... webadmin: ListModelTypeAheadListBox to not always add to valid values Added a parameter that determines whether the widget should automatically add values to the list of "valid" values (those suggested). This is particularly useful when the selected value is initialized to some value, that shouldn't be chosen again once it's been changed (which is the case for the vNIC widget). Change-Id: Ic35073123696fe7e727464079c31794935a7ad70 Bug-Url: https://bugzilla.redhat.com/1020861 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileEditor.java 3 files changed, 26 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/26753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic35073123696fe7e727464079c31794935a7ad70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Return additional info for 400 messages
by oourfali＠redhat.com 16 Apr '14

16 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Return additional info for 400 messages ...................................................................... restapi: Return additional info for 400 messages This was already done for JAXB exceptions, but is missing for RESTEasy JAXB marshall exceptions. Change-Id: I31a7a5f487c662cbcba3734153e9fcb120ba330d Bug-Url: https://bugzilla.redhat.com/867794 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 25dacd5f2f7d2e13f687f24b663a408cf62c6bcb) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JaxbExceptionMapper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JaxbMarshallExceptionMapper.java 2 files changed, 7 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31a7a5f487c662cbcba3734153e9fcb120ba330d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: userportal, webadmin: Changing cluster of existing VM changes...
by oourfali＠redhat.com 16 Apr '14

16 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: userportal,webadmin: Changing cluster of existing VM changes OS type ...................................................................... userportal,webadmin: Changing cluster of existing VM changes OS type Fixed by selecting the already selected OS type if it is still applicable under the context of the newly selected cluster. Change-Id: Ifaf27934e200e69beeb0912db22f26525b85e9b1 Bug-Url: https://bugzilla.redhat.com/1080056 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaf27934e200e69beeb0912db22f26525b85e9b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: requirng newer version of sdk
by oourfali＠redhat.com 16 Apr '14

16 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: spec: requirng newer version of sdk ...................................................................... packaging: spec: requirng newer version of sdk Previous version of the SDK was affected by a bug when using long passwords. Also requiring -sdk-python instead of the obsolete -sdk Change-Id: Iee4833fc2846cacf03eb015f82692ab16b8aad18 Related-To: https://bugzilla.redhat.com/1085837 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee4833fc2846cacf03eb015f82692ab16b8aad18 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Fix LDAP servers issue in engine-manage-domains
by yzaslavs＠redhat.com 16 Apr '14

16 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fix LDAP servers issue in engine-manage-domains ...................................................................... tools: Fix LDAP servers issue in engine-manage-domains LDAP servers discovered using DNS query will not be written to database (they will be rediscovered using DNS query when needed). LDAP servers entered in --ldap-servers argument will be always written to database (they will be used then and no LDAP DNS discovery will be executed). Change-Id: I4ab5bd3a27787615c7430ce2f3a120261f4cd300 Bug-Url: https://bugzilla.redhat.com/1084479 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ab5bd3a27787615c7430ce2f3a120261f4cd300 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.4]: packaging: spec: requirng newer version of sdk
by sbonazzo＠redhat.com 16 Apr '14

16 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: requirng newer version of sdk ...................................................................... packaging: spec: requirng newer version of sdk Previous version of the SDK was affected by a bug when using long passwords. Related-To: https://bugzilla.redhat.com/1085837 Change-Id: I8c5a8b2f4a7a7b2637800f6344875409d0c58055 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-iso-uploader.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c5a8b2f4a7a7b2637800f6344875409d0c58055 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: packaging: spec: requirng newer version of sdk
by sbonazzo＠redhat.com 16 Apr '14

16 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: requirng newer version of sdk ...................................................................... packaging: spec: requirng newer version of sdk Previous version of the SDK was affected by a bug when using long passwords. Related-To: https://bugzilla.redhat.com/1085837 Change-Id: Ic1ec32332d40bf7156205d0f67993223090b930e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-log-collector.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1ec32332d40bf7156205d0f67993223090b930e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0