May 2014 - Engine-commits - oVirt List Archives

Change in ovirt-reports[master]: reports: dr5 report - added comments to queries
by ydary＠redhat.com 20 May '14

20 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: dr5 report - added comments to queries ...................................................................... reports: dr5 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I027027d48a8bfc4454ba38fc84ad48e774df0ed8 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/dc_host_uptime_status_dr5_jrxml.data 1 file changed, 43 insertions(+), 13 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I027027d48a8bfc4454ba38fc84ad48e774df0ed8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: dr11 report - added comments to queries
by ydary＠redhat.com 20 May '14

20 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: dr11 report - added comments to queries ...................................................................... reports: dr11 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I9d7ebe0b286ac74543945f99e776064e5068d847 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/dc_host_resources_status_dr11_jrxml.data 1 file changed, 42 insertions(+), 16 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d7ebe0b286ac74543945f99e776064e5068d847 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: dr2 report - added comments to queries
by ydary＠redhat.com 20 May '14

20 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: dr2 report - added comments to queries ...................................................................... reports: dr2 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I446d98d7da8bb35d681fbb7eb73f95d7fd1ab5fb Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/dc_entities_counts_list_dr2_jrxml.data 1 file changed, 43 insertions(+), 22 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I446d98d7da8bb35d681fbb7eb73f95d7fd1ab5fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: dr21 report - added comments to queries
by ydary＠redhat.com 20 May '14

20 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: dr21 report - added comments to queries ...................................................................... reports: dr21 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I41e7e67f550a1ea2a9afbce11bc02ed04b1e1759 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/datacenter_top_five_busiest_clusters_dr21_jrxml.data 1 file changed, 40 insertions(+), 14 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41e7e67f550a1ea2a9afbce11bc02ed04b1e1759 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: dr20 report - added comments to queries
by ydary＠redhat.com 20 May '14

20 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: dr20 report - added comments to queries ...................................................................... reports: dr20 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I97c21c05180f5cba93d54bd8b18d9c32ba5ef186 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/top_five_ha_virtual_servers_downtime_dr20_jrxml.data 1 file changed, 60 insertions(+), 14 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97c21c05180f5cba93d54bd8b18d9c32ba5ef186 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: br14 report - added comments to queries
by ydary＠redhat.com 20 May '14

20 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br14 report - added comments to queries ...................................................................... reports: br14 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: Ib86ac921334b4e8c86907b0c18d172e4cc0daba5 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/cluster_vm_over_commit_status_dr14_jrxml.data 1 file changed, 103 insertions(+), 30 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib86ac921334b4e8c86907b0c18d172e4cc0daba5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal: add 'update on next restart' dialog
by ahadas＠redhat.com 20 May '14

20 May '14

Arik Hadas has submitted this change and it was merged. Change subject: userportal: add 'update on next restart' dialog ...................................................................... userportal: add 'update on next restart' dialog On update running VM such that part of the changed configuration can be applied only when the VM will be restarted, new dialog is presented with a proper message and the user can choose whether cpu changes (if exist) will be applied immediately or later. Change-Id: Ie2fbede65c57505d1290cd8eb6c3bc239a6eb47d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VmNextRunConfigurationPresenterWidget.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmNextRunConfigurationPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java 5 files changed, 171 insertions(+), 57 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/27582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2fbede65c57505d1290cd8eb6c3bc239a6eb47d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add 'update on next restart' dialog
by ahadas＠redhat.com 20 May '14

20 May '14

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: add 'update on next restart' dialog ...................................................................... webadmin: add 'update on next restart' dialog On update running VM such that part of the changed configuration can be applied only when the VM will be restarted, new dialog is presented with a proper message and the user can choose whether cpu changes (if exist) will be applied immediately or later. Change-Id: Ic2d7a5fa18bc2df73d5e9d898cd3f23f52fdf0ba Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/vm/VmNextRunConfigurationPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmNextRunConfigurationPopupView.java 13 files changed, 266 insertions(+), 6 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2d7a5fa18bc2df73d5e9d898cd3f23f52fdf0ba Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: amend style for confirm host reboot dialog
by derez＠redhat.com 20 May '14

20 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: amend style for confirm host reboot dialog ...................................................................... webadmin: amend style for confirm host reboot dialog To accommodate PatternFly changes, amend style for 'Confirm host has been rebooted' dialog (avoid vertical scrollbar/missing padding). Before-Screenshot: http://i.imgur.com/oEpNKkG.jpg After-Screenshot: http://i.imgur.com/TEPzHFZ.jpg Change-Id: I16f43d896014143b1eb90276d8b625b94589d7e6 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/ManualFenceConfirmationPopupView.ui.xml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Daniel Erez: Verified Greg Sheremeta: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16f43d896014143b1eb90276d8b625b94589d7e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: Use GWTP Bootstrapper for ApplicationInit
by vszocs＠redhat.com 20 May '14

20 May '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Use GWTP Bootstrapper for ApplicationInit ...................................................................... webadmin,userportal: Use GWTP Bootstrapper for ApplicationInit Before this patch, ApplicationInit classes were bound in GIN SystemModule as eager singletons. This was to ensure that these classes are instantiated right after Ginjector is created, i.e. before GWTP place transition kicks in. After this patch, ApplicationInit classes implement GWTP Bootstrapper interface, effectively replacing the use of DefaultBootstrapper (built-in GWTP fallback). The role of GWTP Bootstrapper is to perform any application-specific initialization before initiating transition to requested application place, as defined by history token within the URL. By utilizing GWTP Bootstrapper feature, we no longer have to rely on eager singletons to perform initialization at application startup. Change-Id: I31472c718678ef2ccd45fbf1d988f3faa49bb54d Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/SystemModule.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml 7 files changed, 50 insertions(+), 12 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31472c718678ef2ccd45fbf1d988f3faa49bb54d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0