May 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: extapi: expand jboss module description
by yzaslavs＠redhat.com 02 May '14

02 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: extapi: expand jboss module description ...................................................................... aaa: extapi: expand jboss module description Change-Id: I173955c20d01e81482de12682ec0932f0c78e120 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java 1 file changed, 22 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I173955c20d01e81482de12682ec0932f0c78e120 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix @SuppressWarnings("unchecked") + organize imports
by lvernia＠redhat.com 01 May '14

01 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fix @SuppressWarnings("unchecked") + organize imports ...................................................................... webadmin: Fix @SuppressWarnings("unchecked") + organize imports Change-Id: Ic0c9d16e1d9088fb8137506cb70e6d3ff38cd1f9 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0c9d16e1d9088fb8137506cb70e6d3ff38cd1f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: branding: fix default encoding issue
by awels＠redhat.com 01 May '14

01 May '14

Alexander Wels has submitted this change and it was merged. Change subject: branding: fix default encoding issue ...................................................................... branding: fix default encoding issue Change-Id: I1ec355a526c4999a00ef2779b47011623de1c2c1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java 1 file changed, 10 insertions(+), 14 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ec355a526c4999a00ef2779b47011623de1c2c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Merge VM Reason column with status column
by awels＠redhat.com 01 May '14

01 May '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Merge VM Reason column with status column ...................................................................... webadmin: Merge VM Reason column with status column Merge the VM shutdown/Poweroff reason column with the status column. The reason is shown as a note besides the VM status. Change-Id: I6b4967f8d3b626094e114b99c0823ecb17a7575f Bug-Url: https://bugzilla.redhat.com/1065753 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/HasStyleClass.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StyledImageResourceCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/StatusCompositeCell.css M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 6 files changed, 100 insertions(+), 14 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b4967f8d3b626094e114b99c0823ecb17a7575f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine, restapi, webadmin: Ability to dismiss alerts and eve...
by emesika＠redhat.com 01 May '14

01 May '14

Eli Mesika has submitted this change and it was merged. Change subject: engine, restapi, webadmin: Ability to dismiss alerts and events from web-admin portal ...................................................................... engine, restapi, webadmin: Ability to dismiss alerts and events from web-admin portal >From the webadmin portal, the user should have the ability to dismiss the unwanted/undesired Alerts. An x is provided besides the alert to remove it from the alerts table in the footer. A right click option clear all is available to clear all dismissed alerts and show all alerts. Two backend commands have been added RemoveAuditLogById and ClearAllDismissedAuditLog to support the actions from webadmin. A new action group AUDIT_LOG_MANAGEMENT has been added and all Admin users are given access to this action. When creating a new role the role can be assigned the new permit. The rest api code has been modified to support deleting alerts and also to undelete all deleted alerts. Change-Id: I3873226b64049170743d4bf0add531d0fda2a0cb Bug-Url: https://bugzilla.redhat.com/988392 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearAllDismissedAuditLogsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveAuditLogByIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveExternalEventParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/EventsResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendEventsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/AuditLogDaoMocker.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ImageButtonCell.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/AlertListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/audit_log_sp.sql A packaging/dbscripts/upgrade/03_05_0360_add_audit_log_operation_action_group_and_roles.sql 34 files changed, 510 insertions(+), 90 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/26722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3873226b64049170743d4bf0add531d0fda2a0cb Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: fix commit snapshot flow on active vm commit
by oourfali＠redhat.com 01 May '14

01 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix commit snapshot flow on active vm commit ...................................................................... core: fix commit snapshot flow on active vm commit * RestoreAllSnapshotsCommand -> getSnapshot method: - COMMIT branch: get IN_PREVIEW snapshot by status. * SnapshotDao: - Added a new getter for fetching snapshots only by status. * snapshot_sp.sql: - Added GetSnapshotByVmIdAndStatus stored procedure. Change-Id: Ib27d225b7bf584f1d0c6e2861e91403ba205f087 Bug-Url: https://bugzilla.redhat.com/1093047 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SnapshotDaoTest.java M packaging/dbscripts/snapshots_sp.sql 6 files changed, 51 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib27d225b7bf584f1d0c6e2861e91403ba205f087 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Clear VM Poweroff/Shutdown reason when RunVmCommand...
by oourfali＠redhat.com 01 May '14

01 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Clear VM Poweroff/Shutdown reason when RunVmCommand succeeds ...................................................................... engine : Clear VM Poweroff/Shutdown reason when RunVmCommand succeeds Change the way the reason is cleared. When the RunVmCommand succeeds the reason for the previous shutdown is cleared. Change-Id: Ia1fcf297218295b8cae9e5652e32a1351b0ac9e7 Bug-Url: https://bugzilla.redhat.com/1065753 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1fcf297218295b8cae9e5652e32a1351b0ac9e7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix commit snapshot flow on active vm commit
by derez＠redhat.com 01 May '14

01 May '14

Daniel Erez has submitted this change and it was merged. Change subject: core: fix commit snapshot flow on active vm commit ...................................................................... core: fix commit snapshot flow on active vm commit * RestoreAllSnapshotsCommand -> getSnapshot method: - COMMIT branch: get IN_PREVIEW snapshot by status. * SnapshotDao: - Added a new getter for fetching snapshots only by status. * snapshot_sp.sql: - Added GetSnapshotByVmIdAndStatus stored procedure. Change-Id: Ib27d225b7bf584f1d0c6e2861e91403ba205f087 Bug-Url: https://bugzilla.redhat.com/1093047 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SnapshotDaoTest.java M packaging/dbscripts/snapshots_sp.sql 6 files changed, 51 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib27d225b7bf584f1d0c6e2861e91403ba205f087 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Update audit log message when storage is extended.
by mlipchuk＠redhat.com 01 May '14

01 May '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update audit log message when storage is extended. ...................................................................... core: Update audit log message when storage is extended. Update the audit log to indicate that the update of the total size and free size for the Storage Domain, might take a few moments. The reason that the operation of extend might suffer from latency issues is that the mechanism of the storage size is depended on different asynchronous operations, such as domain monitor in VDSM, IrsBroker in the engine, and query for storage domains in the GUI main tab. Change-Id: Id903df200a3325dc1a741d0b543e2cb9466f8a4d Bug-Url: https://bugzilla.redhat.com/1075515 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id903df200a3325dc1a741d0b543e2cb9466f8a4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4.1]: core: db fix event renaming upgrade script.
by oourfali＠redhat.com 01 May '14

01 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: db fix event renaming upgrade script. ...................................................................... core: db fix event renaming upgrade script. db upgrade fails if there's a subscription to VDS_HIGH_NETWORK_USE event Original upgrade script renamed an event without taking in account that it may be used by subscribers. This patch updates both event_map and event_sunscriber tables with the renamed event, in order to do that we need to remove the FK before the update and adding it back again after the update is finished. Change-Id: I3ac7f33fad30aba5cc459ec05dc990a60bbc65e0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093283 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/03_04_0720_add_host_interface_high_network_use_event.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ac7f33fad30aba5cc459ec05dc990a60bbc65e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.1 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0