June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Recover kdumping host after engine restart
by emesika＠redhat.com 25 Jun '14

25 Jun '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Recover kdumping host after engine restart ...................................................................... core: Recover kdumping host after engine restart Recovers all hosts with status Kdumping after engine startup by scheduling execution of VdsNotRespondingTreatment for host after DisableFenceAtStartupInSec period passed. Change-Id: Icc815a113a703c96cdbe52f28da732f13e96085d Bug-Url: https://bugzilla.redhat.com/1079821 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java 2 files changed, 55 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc815a113a703c96cdbe52f28da732f13e96085d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix eclipse warning
by masayag＠redhat.com 25 Jun '14

25 Jun '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix eclipse warning ...................................................................... engine: Fix eclipse warning Add missing default case to switch statement. Change-Id: I3cdc1f2ee642af56e08f23861a1a326fbcff670a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cdc1f2ee642af56e08f23861a1a326fbcff670a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove dead code
by masayag＠redhat.com 25 Jun '14

25 Jun '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove dead code ...................................................................... engine: Remove dead code Change-Id: I7a63ea48a109604542165347ffc00b0693c252a5 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 8 insertions(+), 17 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/29098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a63ea48a109604542165347ffc00b0693c252a5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix coverity complaint
by masayag＠redhat.com 25 Jun '14

25 Jun '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix coverity complaint ...................................................................... engine: Fix coverity complaint CID 1223220 (#1 of 1): Dereference null return value (NULL_RETURNS) null_method_call: Calling a method on null object jobType. In addition, the job type is not allowed to be null in vm_job table hence a default value should be set for it. Change-Id: If67422d839f16be850b91d9bdfdf58f7359d4672 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If67422d839f16be850b91d9bdfdf58f7359d4672 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix coverity issue
by masayag＠redhat.com 25 Jun '14

25 Jun '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix coverity issue ...................................................................... engine: Fix coverity issue CID 1223221 (#1 of 1): Dereference null return value (NULL_RETURNS) dereference: Dereferencing a pointer that might be null task when calling logAndFailTaskOfCommandWithEmptyVdsmId Change-Id: Iec7dd5de85faa7c44a29aca85a31a41b7ac1f87a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec7dd5de85faa7c44a29aca85a31a41b7ac1f87a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor refactoring in RemoveVmCommand
by ahadas＠redhat.com 25 Jun '14

25 Jun '14

Arik Hadas has submitted this change and it was merged. Change subject: core: minor refactoring in RemoveVmCommand ...................................................................... core: minor refactoring in RemoveVmCommand Change-Id: I1884a595320ac54a26d681c54770274f831ce849 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 15 insertions(+), 23 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1884a595320ac54a26d681c54770274f831ce849 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: fix logical loop in deps
by ydary＠redhat.com 25 Jun '14

25 Jun '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fix logical loop in deps ...................................................................... packaging: setup: fix logical loop in deps Change-Id: I1ea0973da49a7d01c4f58b00a33af3a702f3ef90 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ea0973da49a7d01c4f58b00a33af3a702f3ef90 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: packaging: setup: remove dependency loop in setup
by ydary＠redhat.com 25 Jun '14

25 Jun '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: remove dependency loop in setup ...................................................................... packaging: setup: remove dependency loop in setup Avoid to require odwhcons.Stages.DB_CREDENTIALS_AVAILABLE in schema validation stage while it's provided by pgpass misc stage. Avoid loop in dependency resolution since misc is after validation. Change-Id: Idd0956e6fb7eea724624b85689bcd2b9dbe8bb8f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified Yedidyah Bar David: Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd0956e6fb7eea724624b85689bcd2b9dbe8bb8f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: asynctasks: fix pep8 issues
by emesika＠redhat.com 24 Jun '14

24 Jun '14

Eli Mesika has submitted this change and it was merged. Change subject: packaging: setup: asynctasks: fix pep8 issues ...................................................................... packaging: setup: asynctasks: fix pep8 issues Change-Id: I3e65d18e21b94a8500780be2e09e054a85638caf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 1 file changed, 33 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29158 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e65d18e21b94a8500780be2e09e054a85638caf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: set HttpOnly for all cookies
by awels＠redhat.com 24 Jun '14

24 Jun '14

Alexander Wels has submitted this change and it was merged. Change subject: backend: set HttpOnly for all cookies ...................................................................... backend: set HttpOnly for all cookies - Re-introduce http only patch after session is no longer read from cookies. Change-Id: Ia82d2f594e9f923e03dffc55ea0bcf5d4802f738 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/DocsServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/LocaleFilter.java M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml 8 files changed, 41 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia82d2f594e9f923e03dffc55ea0bcf5d4802f738 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0