June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: Remove redundant for loop
by tnisan＠redhat.com 05 Jun '14

05 Jun '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Remove redundant for loop ...................................................................... frontend: Remove redundant for loop Change-Id: Ic5f967b18eddb24ae10c3365816b1756f373e3d2 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java 1 file changed, 0 insertions(+), 33 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5f967b18eddb24ae10c3365816b1756f373e3d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Remove obsolete class
by tnisan＠redhat.com 05 Jun '14

05 Jun '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Remove obsolete class ...................................................................... frontend: Remove obsolete class Change-Id: I87235688f1484071f9554594bcae68a8fef7fbc8 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Extensions.java 1 file changed, 0 insertions(+), 86 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87235688f1484071f9554594bcae68a8fef7fbc8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: No output when guest agent already running or stopped on RHE...
by vfeenstr＠redhat.com 05 Jun '14

05 Jun '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: No output when guest agent already running or stopped on RHEL5/6 ...................................................................... No output when guest agent already running or stopped on RHEL5/6 When the guest agent is already running and 'service ovirt-guest-agent start' is executed it no longer prints anything. The same for 'service ovirt-guest-agent stop' when the agent is already stopped. Additionally restart will use the same behaviour Change-Id: Id27e5b9f91b675fb5f2d2be8d5d1663efd34293f Bug-Url: https://bugzilla.redhat.com/1028381 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/ovirt-guest-agent.in 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id27e5b9f91b675fb5f2d2be8d5d1663efd34293f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: Filter Windows HotFixes by ReleaseType value
by vfeenstr＠redhat.com 05 Jun '14

05 Jun '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Filter Windows HotFixes by ReleaseType value ...................................................................... Filter Windows HotFixes by ReleaseType value Non-english releases contain a field 'ReleaseType' which contains an english string 'Security Update', 'Hotfix' or 'Update' Additionally we're checking for 'ParentKeyName' which contains 'OperatingSystem' in case of an update. Change-Id: I4ab40ed538a48d79f30ee300d791ce4636371634 Bug-Url: https://bugzilla.redhat.com/1103710 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ab40ed538a48d79f30ee300d791ce4636371634 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomáš Došek <tdosek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix conflicting getter definitions
by ofrenkel＠redhat.com 05 Jun '14

05 Jun '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix conflicting getter definitions ...................................................................... core: fix conflicting getter definitions For several boolean fields in RunVmParams we have both "isX" & "getX" getters, thus json produce: IllegalArgumentException: Conflicting getter definitions for property. The solution is to remove the "isX" getters which should be used only for primitive boolean fields. Change-Id: I37b5e286c21814e757e6369ef9b2a642ac0c621d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java 2 files changed, 21 insertions(+), 18 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37b5e286c21814e757e6369ef9b2a642ac0c621d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use Locked status when activating master domain
by laravot＠redhat.com 05 Jun '14

05 Jun '14

Liron Ar has submitted this change and it was merged. Change subject: core: use Locked status when activating master domain ...................................................................... core: use Locked status when activating master domain When we try to activate the master domain we should use the Locked status because there is no "Activating" transition (it is active by definition). In general the master domain is always active, but this special flow is used on the creation of the StoragePool when the first domain is added. Change-Id: I2f398a8fb946b339786f9776f460eab2f920c7b1 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Federico Simoncelli: Verified Liron Ar: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f398a8fb946b339786f9776f460eab2f920c7b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.4]: ovirt-iso-uploader: using API SDK insecure parameter
by sbonazzo＠redhat.com 05 Jun '14

05 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-iso-uploader: using API SDK insecure parameter ...................................................................... ovirt-iso-uploader: using API SDK insecure parameter Correctly mapping command line insecure parameter to API SDK insecure parameter. Change-Id: I2c76ee34b51bfe111ff319f4e75b7ddb09f03bcf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1102535 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit e89dcdfad8977030ba9e86af673fe8d102cab414) --- M src/__main__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/28203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c76ee34b51bfe111ff319f4e75b7ddb09f03bcf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.4 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: frontend: hotfix - spice activex plugin upgrade in ie11
by oourfali＠redhat.com 05 Jun '14

05 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: hotfix - spice activex plugin upgrade in ie11 ...................................................................... frontend: hotfix - spice activex plugin upgrade in ie11 This hotfix handles broken logic for retrieving spice activex version on in the engine which prevented ie11 clients to install updates. Change-Id: I86615c88545ba26282c4f891389e4b94e85de117 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1085772 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86615c88545ba26282c4f891389e4b94e85de117 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix canDoAction check in RemoveStoragePoolCommand
by mlipchuk＠redhat.com 05 Jun '14

05 Jun '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: fix canDoAction check in RemoveStoragePoolCommand ...................................................................... core: fix canDoAction check in RemoveStoragePoolCommand After change 60cbca3 (core: Detach storage domain when remove Storage Pool) trying to remove a datacenter without any storage domain resulted in a IndexOutOfBoundsException. Change-Id: I209fea6f4a8c9da74a3725ef539442446914de9c Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Federico Simoncelli: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I209fea6f4a8c9da74a3725ef539442446914de9c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : Hide "Architecture" from Cluster popup in gluster...
by kmayilsa＠redhat.com 05 Jun '14

05 Jun '14

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Hide "Architecture" from Cluster popup in gluster mode ...................................................................... webadmin : Hide "Architecture" from Cluster popup in gluster mode Hide "Architecture" from Cluster popup in gluster mode Change-Id: I3fd2a21e1dc28a44e906994cf3d6e59106ca1f68 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1097082 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd2a21e1dc28a44e906994cf3d6e59106ca1f68 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0