June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fix path comment style in domain dialog
by derez＠redhat.com 02 Jun '14

02 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix path comment style in domain dialog ...................................................................... webadmin: fix path comment style in domain dialog Fixed alignment issues of path comment label in domain dialog (affects posix/nfs/gluster storage types). Before-Screenshot: http://i.imgur.com/jdNIuIq.png After-Screenshot: http://i.imgur.com/dTPf0Bk.png Change-Id: Ie200eaef877260967faba45131261097912bbe1d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Alexander Wels: Looks good to me, approved Daniel Erez: Verified Greg Sheremeta: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie200eaef877260967faba45131261097912bbe1d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: LSM - validate identical source and dest SDs
by derez＠redhat.com 02 Jun '14

02 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: core: LSM - validate identical source and dest SDs ...................................................................... core: LSM - validate identical source and dest SDs LiveMigrateVmDisksCommand: Added a canDo validation for identical source and destination storage domain IDs. Change-Id: I75fbc21b654a10cd1207a70b437df75df971717e Bug-Url: https://bugzilla.redhat.com/1103499 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java 2 files changed, 37 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75fbc21b654a10cd1207a70b437df75df971717e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: show disks allocation panel on edit VM
by derez＠redhat.com 02 Jun '14

02 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: show disks allocation panel on edit VM ...................................................................... webadmin: show disks allocation panel on edit VM Disks allocation panel should be available on edit VM dialog in case VirtIO_SCSI is applicable. Change-Id: If433ac77686407d53a79f68a8699b58316df51c8 Related-To: https://bugzilla.redhat.com/1035289 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If433ac77686407d53a79f68a8699b58316df51c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: HostListModel - remove commented out code
by derez＠redhat.com 02 Jun '14

02 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: HostListModel - remove commented out code ...................................................................... webadmin: HostListModel - remove commented out code Remove commented out code from HostListModel. Change-Id: Iab8993b427618f3ae99043f6006bd9fe3479195c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 1 file changed, 0 insertions(+), 35 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/28210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab8993b427618f3ae99043f6006bd9fe3479195c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add PatternFly style fix to DiskItemView
by derez＠redhat.com 02 Jun '14

02 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add PatternFly style fix to DiskItemView ...................................................................... webadmin: add PatternFly style fix to DiskItemView DisksAllocationItemView -> added "avw_contentWidget_pfly_fix" style to content widget (needed for disk alias textbox). Before-Screenshot: http://i.imgur.com/Gy5VluW.jpg After-Screenshot: http://i.imgur.com/J5TypMQ.jpg Change-Id: Ief0490da44b815a32d529bdb676820b29e71e8ff Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.ui.xml 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Alexander Wels: Looks good to me, approved Daniel Erez: Verified Greg Sheremeta: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief0490da44b815a32d529bdb676820b29e71e8ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix the alignment of power management checkbox
by vszocs＠redhat.com 02 Jun '14

02 Jun '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Fix the alignment of power management checkbox ...................................................................... webadmin: Fix the alignment of power management checkbox Change-Id: I850b88e42c6d421a5bded9964e9361f4f993a4d6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057185 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 2 files changed, 12 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I850b88e42c6d421a5bded9964e9361f4f993a4d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: avoid NPE in RecoveryStoragePool command
by laravot＠redhat.com 02 Jun '14

02 Jun '14

Liron Ar has submitted this change and it was merged. Change subject: core: avoid NPE in RecoveryStoragePool command ...................................................................... core: avoid NPE in RecoveryStoragePool command getStoragePool() might return null which will cause to NPE, this patch set this check to occur before accessing the storage pool properties. Change-Id: Ie82c2050989c3ec34ad5ff9f23f853e1894c7ecd Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie82c2050989c3ec34ad5ff9f23f853e1894c7ecd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Enable to modify/remove PM agents via API.
by emesika＠redhat.com 02 Jun '14

02 Jun '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Enable to modify/remove PM agents via API. ...................................................................... core: Enable to modify/remove PM agents via API. After adding two power management agents to a host, impossible to remove/override second agent This patch enables to remove/modify PM agents via API. The problem was that the Host entity given to the API mapper contained the former settings and nothing cleans it in order to set the actual new settings properly This patch fixes the following flows 1) Remove PM agents 2) Add a Secondary PM agent when Primary PM agent is defined 3) Remove a Secondary PM agent 4) Remove Primary PM agent and turning the Secondary PM agent to be primary by changing the order from 2 to 1 5) remove/modify with the backward-compatibility syntax directly from the power management node (a primary PM) without sending the agents node Change-Id: I8a1025ccb4a50f5a5d45746b44b93c12fb14a268 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099903 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 1 file changed, 36 insertions(+), 5 deletions(-) Approvals: Ori Liel: Looks good to me, approved Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a1025ccb4a50f5a5d45746b44b93c12fb14a268 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GetAllFromVmStaticByStoragePoolId - remove unneeded join
by laravot＠redhat.com 02 Jun '14

02 Jun '14

Liron Ar has submitted this change and it was merged. Change subject: core: GetAllFromVmStaticByStoragePoolId - remove unneeded join ...................................................................... core: GetAllFromVmStaticByStoragePoolId - remove unneeded join remove unneeded join with vm_dynamic, vm_dynamic and vm_static should be added in the same transacation when adding a vm. I assume that this join was added to avoid querying templates, but it's unneeded as we already check the entity type in the query without performing that probably more expensive operation. Change-Id: I4fd372a5c4018d3c7bb7e38e1375fa198a14b572 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M packaging/dbscripts/vms_sp.sql 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fd372a5c4018d3c7bb7e38e1375fa198a14b572 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: Report FQDN more periodically
by vfeenstr＠redhat.com 02 Jun '14

02 Jun '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Report FQDN more periodically ...................................................................... Report FQDN more periodically Change-Id: I6754a6d77226636b8753425ca75cb7ccd56aa093 Bug-Url: https://bugzilla.redhat.com/1101947 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/OVirtAgentLogic.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6754a6d77226636b8753425ca75cb7ccd56aa093 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0