June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix typo
by oourfali＠redhat.com 26 Jun '14

26 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix typo ...................................................................... core: fix typo Change-Id: I2dc44234bf5243d2e797b465a74ae530a9791da2 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dc44234bf5243d2e797b465a74ae530a9791da2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add minimal tests to XmlUtils
by amureini＠redhat.com 26 Jun '14

26 Jun '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Add minimal tests to XmlUtils ...................................................................... core: Add minimal tests to XmlUtils Change-Id: I81c895335dae1ca370320e4dd437dc5da8ba36cd Singed-off-by: Idan Shaby <ishaby(a)redhat.com> Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/XmlUtilsTest.java 1 file changed, 68 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/29083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81c895335dae1ca370320e4dd437dc5da8ba36cd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Entities - added connectionsByIQN utility method
by derez＠redhat.com 26 Jun '14

26 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: core: Entities - added connectionsByIQN utility method ...................................................................... core: Entities - added connectionsByIQN utility method Added a utility method to Entities class that returns a map from IQN to connection. Change-Id: I6bb0a9e37f60d290155de38cf47fa74927be23c2 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bb0a9e37f60d290155de38cf47fa74927be23c2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: parse vgName on getVGInfo response
by derez＠redhat.com 26 Jun '14

26 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: core: parse vgName on getVGInfo response ...................................................................... core: parse vgName on getVGInfo response GetVGInfoVDSCommand: Parse 'vgName' property and set it for each LUN. GetDeviceListVDSCommand -> parseLunFromXmlRpc: Set 'vgName' as storageDomainId for each LUN. Change-Id: I4ae7e54f76c4f3f42fad5d4559478fc6df4d662b Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGInfoVDSCommand.java 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ae7e54f76c4f3f42fad5d4559478fc6df4d662b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: added OvfStoreOnAnyDomain to ConfigurationValues
by derez＠redhat.com 26 Jun '14

26 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: core: added OvfStoreOnAnyDomain to ConfigurationValues ...................................................................... core: added OvfStoreOnAnyDomain to ConfigurationValues Added OvfStoreOnAnyDomain key to ConfigurationValues for client usage (an indication for import data domains support). Change-Id: Iee81d04e4ed9c5ab31d34b344d737706e1f17c11 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee81d04e4ed9c5ab31d34b344d737706e1f17c11 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: UP does not load any VMs
by yzaslavs＠redhat.com 26 Jun '14

26 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: UP does not load any VMs ...................................................................... core: UP does not load any VMs The GetAllVmPoolsAttachedToUserQuery missed one of it's constructors causing that the userportal extended view did not load any VMs. Change-Id: I537a44eb64cb0e9c4fe4f11786fdfa20a6706e30 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmPoolsAttachedToUserQuery.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I537a44eb64cb0e9c4fe4f11786fdfa20a6706e30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: custom snapshot preview - disable illegal disks
by derez＠redhat.com 26 Jun '14

26 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: custom snapshot preview - disable illegal disks ...................................................................... webadmin: custom snapshot preview - disable illegal disks Custom snapshot preview dialog: * Disable selection for illegal disks ('N/A' instead of a check-box). * Show relevant tool-tip on hover. Change-Id: Ia4f7b7fd78437d5344852f22c85a3d0e11a6c6eb Bug-Url: https://bugzilla.redhat.com/1111984 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCustomPreviewPopupWidget.java 3 files changed, 13 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4f7b7fd78437d5344852f22c85a3d0e11a6c6eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added vdsm installation sanity
by dcaroest＠redhat.com 26 Jun '14

26 Jun '14

David Caro has submitted this change and it was merged. Change subject: Added vdsm installation sanity ...................................................................... Added vdsm installation sanity Change-Id: Ia6befd9fe1123c006fc9b21dba111ec92e0336c8 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M .gitignore M jobs/confs/shell-scripts/jenkins_check_yaml.sh M jobs/confs/shell-scripts/jenkins_deploy_yamls.sh M jobs/confs/shell-scripts/mock_build_onlyrpm.sh.inc M jobs/confs/shell-scripts/mock_cleanup.sh A jobs/confs/shell-scripts/mock_install.sh M jobs/confs/shell-scripts/mock_setup.sh A jobs/confs/yaml/builders/mock_install.yaml M jobs/confs/yaml/builders/rpm_mock.yaml M jobs/confs/yaml/jobs/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml A jobs/confs/yaml/jobs/vdsm/vdsm_install-rpm-sanity.yaml A jobs/confs/yaml/scms/vdsm.yaml R jobs/confs/yaml/templates/create-rpms_mock.yaml A jobs/confs/yaml/templates/install-rpm-sanity.yaml 14 files changed, 248 insertions(+), 10 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6befd9fe1123c006fc9b21dba111ec92e0336c8 Gerrit-PatchSet: 8 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add missing constructor to HandleVdsVersionCommand
by ahadas＠redhat.com 26 Jun '14

26 Jun '14

Arik Hadas has submitted this change and it was merged. Change subject: core: add missing constructor to HandleVdsVersionCommand ...................................................................... core: add missing constructor to HandleVdsVersionCommand We create it from VdsEventListener without context, so we need to have a constructor which gets only parameters. Change-Id: I63322d08311d99383e54d9b363f56e91a99934e8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63322d08311d99383e54d9b363f56e91a99934e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: NPE on new VM dialog
by tjelinek＠redhat.com 26 Jun '14

26 Jun '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: NPE on new VM dialog ...................................................................... webadmin: NPE on new VM dialog The problem was that the VDSGroup.requiredRngSources was marked as final thus the GWT deserializer inited it to null. Consequently, the VmModelBehaviorBase.setRngAvailability failed on NPE. Change-Id: I0eac061be4370cdef57c5c7b466f7a8ec5bcda01 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Martin Peřina: Verified; Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eac061be4370cdef57c5c7b466f7a8ec5bcda01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0