July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: remove AdminDomain definition.
by oourfali＠redhat.com 14 Jul '14

14 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: remove AdminDomain definition. ...................................................................... aaa: remove AdminDomain definition. This option became redundant with introduction of auth profiles. It was never exposed (Engine Config). Change-Id: I375df1489ed59d98a7be0e3d629b662a0d764d10 Topic: AAA Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/resources/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/defaults.properties M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 1 insertion(+), 5 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve mooli tayer: Verified Yair Zaslavsky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I375df1489ed59d98a7be0e3d629b662a0d764d10 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: remove exceptional AdminDomain logic from domain sorting.
by oourfali＠redhat.com 14 Jul '14

14 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: remove exceptional AdminDomain logic from domain sorting. ...................................................................... aaa: remove exceptional AdminDomain logic from domain sorting. Change-Id: I48ff93e74960c082bdd2dce1b15193272946d503 Topic: AAA Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginDomainComparator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDomainListQueryTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/LoginDomainComparatorTest.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDomainListParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java 9 files changed, 13 insertions(+), 191 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48ff93e74960c082bdd2dce1b15193272946d503 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Make GetVmsInit query accessible to users
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Make GetVmsInit query accessible to users ...................................................................... core: Make GetVmsInit query accessible to users This is required for regular users to access VMs via the RESTAPI. Change-Id: If2278f0b8116ba873b8dc27f4d11d80f346cb216 Bug-Url: https://bugzilla.redhat.com/1102801 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 926adef69e45d5745fcb936239f67d2cfacd18ad) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/30011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2278f0b8116ba873b8dc27f4d11d80f346cb216 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: tools: engine-config.properties: remove left over line.
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: tools: engine-config.properties: remove left over line. ...................................................................... tools: engine-config.properties: remove left over line. commit 116fef64 added meaningful description to the WebSocketProxy different options. However it seems as though the old description (value) was listed as a new unknown key. This causes the following line to be outputed as a value: null: (Value Type: String) Change-Id: I4a991e5aeabdf2195624a2899e6f2bf62e49296a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1116392 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a991e5aeabdf2195624a2899e6f2bf62e49296a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: SetupNetwork>edit network(with pencil)>can't edit ...
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: SetupNetwork>edit network(with pencil)>can't edit network ...................................................................... webadmin: SetupNetwork>edit network(with pencil)>can't edit network EnumRadioEditor used the global eventBus to fire ValueChangeEvent. Since UiCommonEditorVisitor subscribes all the editors of type HasValueChangeHandlers to this event- all the instances of EnumRadioEditor were subscribed to the same eventBus. Therefore, each instance pf EnumRadioEditor got the value change events of the other instances- which caused wrong behaviour and in some cases ClassCasException. To fix the issue a separate handlerManger is used for each instance of EnumRadioEditor. Note: addValueChangeHandler(..) cannot register to the valueChangeHanlder of the peer since the peer's 'value' is all the list of enum-items and not just the selected item as desired. Change-Id: I83c330b8340ba1cf6b2382877b23d07c25fc1afb Bug-Url: https://bugzilla.redhat.com/1108014 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnumRadioEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java 4 files changed, 9 insertions(+), 9 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83c330b8340ba1cf6b2382877b23d07c25fc1afb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix Live Merge logging
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fix Live Merge logging ...................................................................... core: fix Live Merge logging Minor fixes to log messages appearing during Live Merge. Change-Id: I18bcd3b135b45a443e23afdc4872234cc7c994c3 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DestroyImageParameters.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18bcd3b135b45a443e23afdc4872234cc7c994c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix coverity issue
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fix coverity issue ...................................................................... core: fix coverity issue Fix CID 1223222: Se: Incorrect definition of Serializable class (FB.SE_BAD_FIELD) The MergeStatusReturnValue member of RemoveSnapshotSingleDiskParameters did not implement Serializable. Change-Id: I7363ae80b3f6c6bdcf1f5dbb615d6021cce23872 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MergeStatusReturnValue.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7363ae80b3f6c6bdcf1f5dbb615d6021cce23872 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Fix optional parameters of add template
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix optional parameters of add template ...................................................................... restapi: Fix optional parameters of add template The operation to add a template accepts the cluster name and id as optional parameters, but they aren't documented in the metadata, thus they aren't available in the CLI. Change-Id: I612da88a8de940f635cf11efd7bafb0a5ea9f17f Bug-Url: https://bugzilla.redhat.com/1109548 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 2be1f639381be1b0843391b9e24fb947e64d4421) --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I612da88a8de940f635cf11efd7bafb0a5ea9f17f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Make GetVmsInit query accessible to users
by juan.hernandez＠redhat.com 14 Jul '14

14 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: core: Make GetVmsInit query accessible to users ...................................................................... core: Make GetVmsInit query accessible to users This is required for regular users to access VMs via the RESTAPI. Change-Id: If2278f0b8116ba873b8dc27f4d11d80f346cb216 Bug-Url: https://bugzilla.redhat.com/1102801 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/29941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2278f0b8116ba873b8dc27f4d11d80f346cb216 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: build: post ovirt-hosted-engine-ha-1.2 branch
by msivak＠redhat.com 14 Jul '14

14 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.2 branch ...................................................................... build: post ovirt-hosted-engine-ha-1.2 branch Change-Id: I1dd4c7edcf0be44b6af268ef207c2f8d4a526ef3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 12 insertions(+), 57 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dd4c7edcf0be44b6af268ef207c2f8d4a526ef3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0