July 2014 - Engine-commits - oVirt List Archives

Change in jenkins[master]: Added patternfly repo
by eedri＠redhat.com 14 Jul '14

14 Jul '14

Eyal Edri has submitted this change and it was merged. Change subject: Added patternfly repo ...................................................................... Added patternfly repo Change-Id: I94ff82708425d2927bc3a091894e04d3df1e050a Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/packaging/repo_closure_check.sh 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94ff82708425d2927bc3a091894e04d3df1e050a Gerrit-PatchSet: 7 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: make migrate commands non-transactive
by oourfali＠redhat.com 14 Jul '14

14 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: make migrate commands non-transactive ...................................................................... core: make migrate commands non-transactive Patch 94e48a02 removed the global transaction during RunVmCommand. Global transactions should also be removed from the migrate commands for the same reasons and because it prevents us from migrating multiple VMs from different hosts to the same host while one of the migrations is in its execute phase or start a VM on a host while another VM is migrating to that host and the migration is in its execute phase. Change-Id: I4894ebd5f062174f9780926a0ce6b499fcc0fc7b Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java 4 files changed, 38 insertions(+), 36 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/29872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4894ebd5f062174f9780926a0ce6b499fcc0fc7b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: minor cleanup in MigrateVDSCommand
by oourfali＠redhat.com 14 Jul '14

14 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: minor cleanup in MigrateVDSCommand ...................................................................... core: minor cleanup in MigrateVDSCommand Change-Id: I55b4365d9a71a47b4a72f98bae649a363f43ef03 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java 1 file changed, 40 insertions(+), 34 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/29871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55b4365d9a71a47b4a72f98bae649a363f43ef03 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Whitespace fixes in MacPoolManagerRanges
by mkolesni＠redhat.com 14 Jul '14

14 Jul '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Whitespace fixes in MacPoolManagerRanges ...................................................................... engine: Whitespace fixes in MacPoolManagerRanges Removed unnecessary lines where not needed, and added where needed. Change-Id: I191b9721a9629041ce998feeffdc6b163a3821b8 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerRanges.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I191b9721a9629041ce998feeffdc6b163a3821b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use AutoCloseableLock in MacPoolManagerRanges
by mkolesni＠redhat.com 14 Jul '14

14 Jul '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Use AutoCloseableLock in MacPoolManagerRanges ...................................................................... engine: Use AutoCloseableLock in MacPoolManagerRanges Refactored MacPoolManagerRanges to use the AutoCloseableLock to simplify lock blocks. Change-Id: I5fdb1cb8c302e88dbcbdc434313a6b11f7b15d5b Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerRanges.java 1 file changed, 10 insertions(+), 37 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fdb1cb8c302e88dbcbdc434313a6b11f7b15d5b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Added AutoCloseableLock
by mkolesni＠redhat.com 14 Jul '14

14 Jul '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Added AutoCloseableLock ...................................................................... engine: Added AutoCloseableLock This wrapper class will allow writing cleaner code, instead of: lock.lock(); try { // Thread safe code } finally { lock.unlock(); } We can write: try (AutoCloseableLock l = new AutoCloseableLock(lock)) { // Thread safe code } A follow-up patch will refactor code to use this new syntax and serve as an example. Change-Id: I3864d0e630c04f13e47e9f324414b308bd24290e Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/AutoCloseableLock.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/lock/AutoCloseableLockTest.java 2 files changed, 88 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified Omer Frenkel: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3864d0e630c04f13e47e9f324414b308bd24290e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix coverity unguarded read error in IsoDomainListSync...
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix coverity unguarded read error in IsoDomainListSyncronizer ...................................................................... core: Fix coverity unguarded read error in IsoDomainListSyncronizer Change-Id: I156624f62b950159d33339a4714b016cf3d58cee Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I156624f62b950159d33339a4714b016cf3d58cee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: fix flatGroups recursive
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: fix flatGroups recursive ...................................................................... aaa: fix flatGroups recursive incorrect get of groups of group record from principal record. also clean up the implementation to simplify. Topic: AAA Change-Id: Ief72097b8248ffb0c8d51d170a463453170b51c4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/DirectoryUtils.java 1 file changed, 11 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief72097b8248ffb0c8d51d170a463453170b51c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: aaa: fix group list comma construction
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: aaa: fix group list comma construction ...................................................................... webadmin: aaa: fix group list comma construction actually, the counter should have been incremented. but there is no reason to use extra variable. Topic: AAA Change-Id: Ic8b5bd60cfdcea2f5593364ed4c9a36ff4f3550d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Tal Nisan: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8b5bd60cfdcea2f5593364ed4c9a36ff4f3550d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: send virtio-serial device to VDSM
by ofrenkel＠redhat.com 13 Jul '14

13 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: send virtio-serial device to VDSM ...................................................................... core: send virtio-serial device to VDSM Add virtio-serial to the list of devices the engine sends to VDSM Change-Id: Ie99dafc1495f42ffcd76592dcd9130f12c6d61bd Bug-Url: https://bugzilla.redhat.com/1028387 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java 8 files changed, 31 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/29839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie99dafc1495f42ffcd76592dcd9130f12c6d61bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0