July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: Treat migration state as Up and check engine health normally
by msivak＠redhat.com 11 Jul '14

11 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: Treat migration state as Up and check engine health normally ...................................................................... Treat migration state as Up and check engine health normally We used to treat migration source state as Vm up Health bad. That is not the correct report as the source Vm still works properly during live-merge. This caused a situation when a migration caused other hosts to try to start the Vm and fail because of sanlock protection. This moves migration source state to the group of states with Vm up Health <query the status page> behaviour. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093366 Change-Id: If3c813461909103b11266c902ccc51b2df2d0d36 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 0554e4208c4915863baeaa16fa5baeb678bfa0cf) --- M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py 1 file changed, 9 insertions(+), 10 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3c813461909103b11266c902ccc51b2df2d0d36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Use max instead of min when computing the best score
by msivak＠redhat.com 11 Jul '14

11 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: Use max instead of min when computing the best score ...................................................................... Use max instead of min when computing the best score The best score is the highest score, so this was a 'thinko'. However this bug manifests itself only if there are more than 2 hosts in the setup. Change-Id: I0c265aa60611793b1cd4738ec057e9e7d02747a1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093366 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/state_machine.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/29580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c265aa60611793b1cd4738ec057e9e7d02747a1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: try harder when connecting the storage
by msivak＠redhat.com 11 Jul '14

11 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: try harder when connecting the storage ...................................................................... try harder when connecting the storage the agent has to wait between attempts to connect the storage to give vdsm some time to initialize Change-Id: I4c512aad490366b0fbd890d156b37243993dc498 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093621 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/29862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c512aad490366b0fbd890d156b37243993dc498 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Enable balloon by default - Patch 2 of 2
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Enable balloon by default - Patch 2 of 2 ...................................................................... core: Enable balloon by default - Patch 2 of 2 The "New VM"/"New Pool" dialogs in the frontend were changed to enable the balloon device in guest OSes where the "balloon.enabled" osinfo property is enabled. This way the system administrator will have an usable VM by default even in problematic guest OSes. Change-Id: I7803e45f07539090e5527ebc81bbc6c31df4e120 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069858 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 45 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7803e45f07539090e5527ebc81bbc6c31df4e120 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Add resteasy dependency to engine.ear manifest
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Add resteasy dependency to engine.ear manifest ...................................................................... engine: Add resteasy dependency to engine.ear manifest The org.jboss.resteasy.resteasy-jaxrs is being added to the engine.ear manifest for the sake openstack-java sdk which requires it. Change-Id: I1d41c63bc023f025dff46c054deeed0f18188c97 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M ear/src/main/resources/META-INF/MANIFEST.MF 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d41c63bc023f025dff46c054deeed0f18188c97 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Update CoCo to use CommandContext
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine : Update CoCo to use CommandContext ...................................................................... engine : Update CoCo to use CommandContext CommandCoordinator has been updated to find Commands with CommandContext constructor. RemoveSnapshotCommand and RemoveSnapshotSingleDiskLiveCommand have been updated to call CoCo with context when running child commands Change-Id: Id914da3ed1a29e651ad2491fc88a2705b7af6e8f Bug-Url: https://bugzilla.redhat.com/1115127 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 4ccb77f05177bf16e038dd59f0bce7da1fc2d43c) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskManagerUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandScheduler.java 6 files changed, 17 insertions(+), 9 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id914da3ed1a29e651ad2491fc88a2705b7af6e8f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: extmgr: Engine should start even if there is a wrong configu...
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: extmgr: Engine should start even if there is a wrong configuration of extension ...................................................................... extmgr: Engine should start even if there is a wrong configuration of extension Change-Id: Iac6b522eb8d5fc1f3993780e6c1f09f7e5046757 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1117397 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> (cherry picked from commit 13e696a6aa33e1869d016b2a37d37d348e3af9a7) --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac6b522eb8d5fc1f3993780e6c1f09f7e5046757 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: fixing hostname validation
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: fixing hostname validation ...................................................................... packaging: setup: fixing hostname validation engine-setup validates hostnames to avoid strange behaviours; it's done via a regular expression. Fixing it to avoid the match of '_' which is not a valid character in a hostname according to RFC 952 An invalid hostname can cause strange behaviour interacting with other components. Change-Id: Id5c56bc5642bfb18629c1a0ad780e8a0e58a3531 Bug-url: https://bugzilla.redhat.com/1113974 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 98079e8c37e00349ce5b1f86d2501a15615a3339) --- M packaging/setup/plugins/ovirt-engine-setup/base/network/hostname.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/29759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5c56bc5642bfb18629c1a0ad780e8a0e58a3531 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: do not use /var/tmp for engine
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: do not use /var/tmp for engine ...................................................................... packaging: do not use /var/tmp for engine /var/tmp is intended for temporary files. The engine is a long-running process, and should not keep its files there. Use /var/lib/ovirt-engine/jboss_runtime instead. Change-Id: I88563c8c0d319eb3356b47233a31c82d9e8b84c7 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 7ef24407897ba97e6eb9a41fe0b05fd1cfc9d208) --- M Makefile M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.py M packaging/services/ovirt-engine/ovirt-engine.xml.in 4 files changed, 15 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/29754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88563c8c0d319eb3356b47233a31c82d9e8b84c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: fix query directory groups
by yzaslavs＠redhat.com 11 Jul '14

11 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: fix query directory groups ...................................................................... aaa: fix query directory groups Topic: AAA Change-Id: Ie4af59ed32e36639120ac976e05b08e868719390 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/DirectoryUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4af59ed32e36639120ac976e05b08e868719390 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0