July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: bll: move aaa related logics into aaa subpackage
by yzaslavs＠redhat.com 22 Jul '14

22 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: bll: move aaa related logics into aaa subpackage ...................................................................... bll: move aaa related logics into aaa subpackage Topic: AAA Change-Id: I2af38e5ea57b6753eb0c836d3dff03df74cdfdc9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/AdGroupsHandlingCommandBase.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/AddGroupCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/AddUserCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DbUserCacheManager.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryEntryKey.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetAllDbGroupsQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetAllDbUsersQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDbUserByUserIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDbUserByUserNameAndDomainQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryGroupByIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryUserByIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetUserBySessionIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetValueBySessionQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginAdminUserCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginUserCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutBySessionCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutUserCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/RemoveGroupCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/RemoveUserCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SetDataOnSessionCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/UserCommandBase.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/ValidateSessionQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractGetEntitiesWithPermittedActionParametersQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackendTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ValidateSessionQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/GetUserBySessionIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/RemoveAdGroupCommandTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/SessionDataContainerTest.java 41 files changed, 75 insertions(+), 54 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2af38e5ea57b6753eb0c836d3dff03df74cdfdc9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: jsonrpc: Edit host restores default protocol
by piotr.kliczewski＠gmail.com 22 Jul '14

22 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: jsonrpc: Edit host restores default protocol ...................................................................... jsonrpc: Edit host restores default protocol After editing host default value of the protocol for the host is restored. Bug-Url: https://bugzilla.redhat.com/1121967 Change-Id: I64f483f10b85af4891fa40c63584dbb5befc6a8e Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Tomas Jelinek: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64f483f10b85af4891fa40c63584dbb5befc6a8e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core:Class cast exception when fence fails
by piotr.kliczewski＠gmail.com 22 Jul '14

22 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core:Class cast exception when fence fails ...................................................................... core:Class cast exception when fence fails The problem was that in the case that the proxy host is blocked by iptables to access the PM card we got a message result in the RPC XML return value which is Object[]. In the code, there was attempt to cast this result to a string which obviously failed with ClassCastException. This patch adds check for the message type and gets it properly as string in the case that we got Object[]. Change-Id: I511599ce3c6dbf313cbe8d1f0f57e329a4aa1d79 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114977 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/StatusForXmlRpc.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I511599ce3c6dbf313cbe8d1f0f57e329a4aa1d79 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove 'final' keyword from private methods
by oourfali＠redhat.com 22 Jul '14

22 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: remove 'final' keyword from private methods ...................................................................... core: remove 'final' keyword from private methods Signed-off-by: Alissa Bonas <abonas(a)redhat.com> Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> Change-Id: I0871b3853b287d5e8918f7d7e38b99895e575f77 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java 5 files changed, 9 insertions(+), 9 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0871b3853b287d5e8918f7d7e38b99895e575f77 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:Class cast exception when fence fails
by oourfali＠redhat.com 22 Jul '14

22 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core:Class cast exception when fence fails ...................................................................... core:Class cast exception when fence fails The problem was that in the case that the proxy host is blocked by iptables to access the PM card we got a message result in the RPC XML return value which is Object[]. In the code, there was attempt to cast this result to a string which obviously failed with ClassCastException. This patch adds check for the message type and gets it properly as string in the case that we got Object[]. Change-Id: I511599ce3c6dbf313cbe8d1f0f57e329a4aa1d79 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114977 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/StatusForXmlRpc.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Juan Hernandez: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I511599ce3c6dbf313cbe8d1f0f57e329a4aa1d79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.3]: packaging: added release notes.
by ydary＠redhat.com 22 Jul '14

22 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added release notes. ...................................................................... packaging: added release notes. Change-Id: Id6617f444a0fd6377eae6c9448611d316d0f448b Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-engine-dwh.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6617f444a0fd6377eae6c9448611d316d0f448b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.3 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: Fix missing macro
by msivak＠redhat.com 22 Jul '14

22 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: Fix missing macro ...................................................................... Fix missing macro %systemd_requires fails on f19 when systemd is not installed. Change-Id: I5ab60bd58233b4776482f2a7aee609d6a823bffd Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jiří Moskovčák: Looks good to me, but someone else must approve David Caro: Verified -- To view, visit http://gerrit.ovirt.org/30279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ab60bd58233b4776482f2a7aee609d6a823bffd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Save PM options even when PM disabled
by piotr.kliczewski＠gmail.com 22 Jul '14

22 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Save PM options even when PM disabled ...................................................................... webadmin: Save PM options even when PM disabled Fixes limitation where PM options were saved only when PM was enabled for host. Change-Id: Iccc3121e35c05123a110f98802bb548034aaa308 Bug-Url: https://bugzilla.redhat.com/1113478 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 21 insertions(+), 23 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccc3121e35c05123a110f98802bb548034aaa308 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: jsonrpc: Edit host restores default protocol
by oourfali＠redhat.com 22 Jul '14

22 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc: Edit host restores default protocol ...................................................................... jsonrpc: Edit host restores default protocol After editing host default value of the protocol for the host is restored. Bug-Url: https://bugzilla.redhat.com/1121967 Change-Id: I64f483f10b85af4891fa40c63584dbb5befc6a8e Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64f483f10b85af4891fa40c63584dbb5befc6a8e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Save PM options even when PM disabled
by oourfali＠redhat.com 22 Jul '14

22 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Save PM options even when PM disabled ...................................................................... webadmin: Save PM options even when PM disabled Fixes limitation where PM options were saved only when PM was enabled for host. Change-Id: Iccc3121e35c05123a110f98802bb548034aaa308 Bug-Url: https://bugzilla.redhat.com/1113478 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 21 insertions(+), 23 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccc3121e35c05123a110f98802bb548034aaa308 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0