July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix exception related to display network warning
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Fix exception related to display network warning ...................................................................... webadmin: Fix exception related to display network warning ClassCastException, probably due to misunderstanding of the network operations. Change-Id: Iac63576d8e15bdae47ec0e08ae2b64395adc4765 Bug-Url: https://bugzilla.redhat.com/1078836 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/29996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac63576d8e15bdae47ec0e08ae2b64395adc4765 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: External network with vlan must be labeled
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: External network with vlan must be labeled ...................................................................... engine: External network with vlan must be labeled An external network which its vlan-id is set, must include a label when it is being added to the external provider. Since the engine might not be aware of changes made to the provider, the label values cannot be enforced. (cherry picked from commit f71b849cd89e819a636a78bae58081c8fa343020) Change-Id: I811a0d55798b7dd78d37880055c4ac00303b679f Bug-Url: https://bugzilla.redhat.com/1059249 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/AddNetworkValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 34 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/30491 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I811a0d55798b7dd78d37880055c4ac00303b679f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Edit disk description when VM is up
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Edit disk description when VM is up ...................................................................... engine: Edit disk description when VM is up Since the description is just a database field, there's no (good) reason to prevent editing disks' descriptions while the related VM(s) is(are) up. This patch includes: - Fixing the UpdateVmDiskCommand to allow such updates - Adding cases to UpdateVmDiskCommandTest to check this functionality - Fixing EditDiskModel to allow this update in the UI Change-Id: Id116aec43abb8863faf17a240530dac0a78f22e0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java 3 files changed, 30 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/30501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id116aec43abb8863faf17a240530dac0a78f22e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Validate network provider properties
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Validate network provider properties ...................................................................... engine: Validate network provider properties Validates that host which is installed with network provider supplies all of the required properties or the provider has them defined. Change-Id: Idcdcddb9694426c1e656c9fa1e04dc7f37e8115c Bug-Url: https://bugzilla.redhat.com/1061728 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/ProviderValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 177 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idcdcddb9694426c1e656c9fa1e04dc7f37e8115c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Mention host's name in Setup Networks title
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Mention host's name in Setup Networks title ...................................................................... webadmin: Mention host's name in Setup Networks title Added the host name to the dialog's title, so that users will easily be aware of which host's networks they're configuring. Change-Id: Id3eaa163564846f2c24e1e86e49b7ec3879dcf85 Bug-Url: https://bugzilla.redhat.com/1114882 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 5 files changed, 10 insertions(+), 14 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/29995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3eaa163564846f2c24e1e86e49b7ec3879dcf85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: wrong log severity for interface up/down event logs
by alkaplan＠redhat.com 21 Jul '14

21 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: wrong log severity for interface up/down event logs ...................................................................... engine: wrong log severity for interface up/down event logs Interface down events' log severity should be warning. Interface up events' log severity should be normal. Change-Id: I9ff6b663a141f75241ff27f8df12922c42de04ff Bug-Url: https://bugzilla.redhat.com/1113160 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ff6b663a141f75241ff27f8df12922c42de04ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Fixing missing name field for admin user
by oourfali＠redhat.com 21 Jul '14

21 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: Fixing missing name field for admin user ...................................................................... aaa: Fixing missing name field for admin user Topic: AAA Change-Id: Ie4ae5e103ecc9f85fbeaef6c9bc3351e9d4beb21 Bug-Url: https://bugzilla.redhat.com/1101147 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java A packaging/dbscripts/upgrade/03_05_0770_set_name_for_internal_user.sql 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4ae5e103ecc9f85fbeaef6c9bc3351e9d4beb21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Fixing missing name field for admin user
by yzaslavs＠redhat.com 21 Jul '14

21 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Fixing missing name field for admin user ...................................................................... aaa: Fixing missing name field for admin user Topic: AAA Change-Id: Ie4ae5e103ecc9f85fbeaef6c9bc3351e9d4beb21 Bug-url: https://bugzilla.redhat.com/1101147 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java A packaging/dbscripts/upgrade/03_06_0030_set_name_for_internal_user.sql 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4ae5e103ecc9f85fbeaef6c9bc3351e9d4beb21 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix update VmDevices when VM is down
by derez＠redhat.com 20 Jul '14

20 Jul '14

Daniel Erez has submitted this change and it was merged. Change subject: core: fix update VmDevices when VM is down ...................................................................... core: fix update VmDevices when VM is down Updating VmDevices when the VM isn't running, mistakenly leads to next run snapshot creation. Therefore, modified 'VmHandler -> isUpdateValidForVmDevices': the function should check whether updating is valid according to the status of the VM; hence, VmStatus should be specified (so it could be validated properly on 'getVmDevicesFieldsToUpdateOnNextRun -> isUpdateValidForVmDevice'). Change-Id: Ia7a8f2a4c3f41b18a7c02ca162b01ee352e49bcf Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmUpdatesOnNextRunExistsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 4 files changed, 8 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7a8f2a4c3f41b18a7c02ca162b01ee352e49bcf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Edit disk description when VM is up
by amureini＠redhat.com 20 Jul '14

20 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Edit disk description when VM is up ...................................................................... engine: Edit disk description when VM is up Since the description is just a database field, there's no (good) reason to prevent editing disks' descriptions while the related VM(s) is(are) up. This patch includes: - Fixing the UpdateVmDiskCommand to allow such updates - Adding cases to UpdateVmDiskCommandTest to check this functionality - Fixing EditDiskModel to allow this update in the UI Change-Id: Id116aec43abb8863faf17a240530dac0a78f22e0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java 3 files changed, 30 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id116aec43abb8863faf17a240530dac0a78f22e0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0