July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Threshold validation for stateless VM
by amureini＠redhat.com 30 Jul '14

30 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Threshold validation for stateless VM ...................................................................... core: Threshold validation for stateless VM When a VM is run as stateless, temporary volumes are created for each disk leaf. Threshold validation is added in this patch. Change-Id: Ic15815abfe25bb5d78b5115e2d05bf040fdcfcdb Bug-Url: https://bugzilla.redhat.com/1054175 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/30840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic15815abfe25bb5d78b5115e2d05bf040fdcfcdb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Changed event message for suspended shutdown
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Changed event message for suspended shutdown ...................................................................... core: Changed event message for suspended shutdown Changed event message text displayed at audit log during power off\shutdown of a suspended VM. Change-Id: If788ab1117244b6fd211c17e99ddb8d31a794d35 Bug-Url: https://bugzilla.redhat.com/1073437 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If788ab1117244b6fd211c17e99ddb8d31a794d35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.4]: build: post ovirt-engine-reports-3.4.3
by ydary＠redhat.com 30 Jul '14

30 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.4.3 ...................................................................... build: post ovirt-engine-reports-3.4.3 Change-Id: I25aff8fe0b9727a7d564d08e8e040181de052540 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25aff8fe0b9727a7d564d08e8e040181de052540 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.4]: build: ovirt-engine-reports-3.4.3-2 respin
by ydary＠redhat.com 30 Jul '14

30 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.4.3-2 respin ...................................................................... build: ovirt-engine-reports-3.4.3-2 respin Change-Id: Ib965cd8886d718e35ab3ae379f3e04f2a77d0b1e Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in M version.mak 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib965cd8886d718e35ab3ae379f3e04f2a77d0b1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Host Edit Network dialog - fix custom properties l...
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Host Edit Network dialog - fix custom properties layout ...................................................................... webadmin: Host Edit Network dialog - fix custom properties layout Make dropdown wider so whole string 'Please select a key...' is visible. Change-Id: Iaf25dde046346f8bea239b9e3f6c963f86e74adc Bug-Url: https://bugzilla.redhat.com/1124404 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf25dde046346f8bea239b9e3f6c963f86e74adc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Unneeded scroll bar on KeyValueWidget
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Unneeded scroll bar on KeyValueWidget ...................................................................... webadmin: Unneeded scroll bar on KeyValueWidget Change-Id: Ic7f26ace9c783467d8f02d4c9df511b30032bd7e Bug-Url: https://bugzilla.redhat.com/1116737 Bug-Url: https://bugzilla.redhat.com/1116580 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f26ace9c783467d8f02d4c9df511b30032bd7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Editing non-VLAN network shows VLAN 0
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Editing non-VLAN network shows VLAN 0 ...................................................................... webadmin: Editing non-VLAN network shows VLAN 0 EditNetworkModel translates 'Null' vlan id to 0. It shouldn't do it. Change-Id: I9ea207d0a881500de4fe5a633e6fba5f9179ea3d Bug-Url: https://bugzilla.redhat.com/1114985 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit 5bbea9650e2850974c5417c96d42c33b0d97a5f9) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ea207d0a881500de4fe5a633e6fba5f9179ea3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Attach/Detach two (or more) nets with labels to clu...
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Attach/Detach two (or more) nets with labels to cluster fails ...................................................................... engine: Attach/Detach two (or more) nets with labels to cluster fails When more than one network with a label are attached/detached to/from a cluster via multiple action- Attach/DetachNetworkToVdsGroup an internal command Attach/DetachNetworksFromCluster is called. Due to changes in internal commands protocol- commands that are called internally should have two ctors- 1. Ctor(T parameters) 2. Ctor(T parameters, CommandContext cmdContext) Since the Attach/DetachNetworkToVdsGroup didn't have the first ctor there was an exception. Change-Id: I8862de722b42360d215285e3bd29708cc5ceec68 Bug-Url: https://bugzilla.redhat.com/1124392 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit a6ed2fe0a0aec332d2ed66b9536e8988c767157a) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworksToClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworksFromClusterCommand.java 2 files changed, 10 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8862de722b42360d215285e3bd29708cc5ceec68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Storage validation when running stateless VM
by amureini＠redhat.com 30 Jul '14

30 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Storage validation when running stateless VM ...................................................................... core: Storage validation when running stateless VM When a VM is run as stateless, temporary volumes are created for each disk leaf. Up till now there were no storage validations in this case. These were added in this patch, along with some new functionality to the MultipleStorageDomainsValidator, as well as related tests. Change-Id: Id04203119cce475afeef7658db50e132b0c7036a Bug-Url: https://bugzilla.redhat.com/1054175 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java 3 files changed, 60 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/30776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id04203119cce475afeef7658db50e132b0c7036a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Adjust Un/LabelNetworkCommand to use commandBase.run...
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Adjust Un/LabelNetworkCommand to use commandBase.runInternalAction ...................................................................... engine: Adjust Un/LabelNetworkCommand to use commandBase.runInternalAction UnlabelNetworkCommand and LabelNetworkCommand call UpdateNetworkCommand internally. For unknown reason they used getBackend().runAction(..) for this purpose. Since the call to UpdateNetworkCommand is internal runInternalAction(..) should be called. Due to the last changes to CommandBase- commandBase.runInternalAction(..) should be used. Change-Id: Ibbe6c0e74129c2ae25d540331a93225181ae41c8 Bug-Url: https://bugzilla.redhat.com/1123636 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit e71e719e0f8e90b30fb0f7c57ce7de4b07cb963d) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/LabelNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkModification.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UnlabelNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 5 files changed, 17 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbe6c0e74129c2ae25d540331a93225181ae41c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0