July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Nic labels should be sorted
by alkaplan＠redhat.com 06 Jul '14

06 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Nic labels should be sorted ...................................................................... webadmin: Nic labels should be sorted Nic labels should be presented according to LexoNumeric order. There are two places that should be sorted- 1. Setup Networks- edit nic dialog- the current labels. 2. Host interface subtab- the labels tooltip (on nic or bond). Note- Setup Networks->edit nic dialog->suggested labels- are already sorted. HostSetupNetworksModel.getFreeLabels() takes care of it. Change-Id: I28fb7750504bffdadd9d92f00565e21c272127ff Bug-Url: https://bugzilla.redhat.com/1091674 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NicLabelModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfaceLabelWithToolTip.java 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28fb7750504bffdadd9d92f00565e21c272127ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Interface dialog- when opening the labels scroll s...
by alkaplan＠redhat.com 06 Jul '14

06 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Interface dialog- when opening the labels scroll should be down ...................................................................... webadmin: Interface dialog- when opening the labels scroll should be down when opening the network labels window, the scrollbar should be down, so you should be able to click on '+' button without using scrollbar. Being there fixed all the other classes that extends AddRemoveRowWidget a have a scrollPanel. Change-Id: I4a2d5bd7280ef98a6ac0e94c336fcc6f30666c8a Bug-Url: https://bugzilla.redhat.com/1091695 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ScrollableAddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.ui.xml 9 files changed, 37 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a2d5bd7280ef98a6ac0e94c336fcc6f30666c8a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Live Merge fails to find cotr for RemoveSnapshotSin...
by oourfali＠redhat.com 06 Jul '14

06 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Live Merge fails to find cotr for RemoveSnapshotSingleDiskLiveCommand ...................................................................... engine : Live Merge fails to find cotr for RemoveSnapshotSingleDiskLiveCommand Live deletion of a snapshot (live merge) fails to find constructor for RemoveSnapshotSingleDiskLiveCommand Change-Id: I8b1053621030049ed2e04de3fb5965f98a33ad05 Bug-Url: https://bugzilla.redhat.com/1115127 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 5 files changed, 21 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Greg Padgett: Verified; Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b1053621030049ed2e04de3fb5965f98a33ad05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing format for external provider objects
by oourfali＠redhat.com 06 Jul '14

06 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fixing format for external provider objects ...................................................................... core: fixing format for external provider objects Change-Id: I6b1cc0c30b366e11bb7847a41c6234829a83e0bf Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanComputerResource.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanComputerResourceWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanDiscoveredHost.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanDiscoveredHostWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHost.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostGroup.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostGroupWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanOperatingSystem.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanOperatingSystemWrapper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalComputeResource.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalDiscoveredHost.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalEntityBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalHost.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalHostGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalOperatingSystem.java 17 files changed, 271 insertions(+), 71 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/29548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b1cc0c30b366e11bb7847a41c6234829a83e0bf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Edit interface- the last label should get the focus
by alkaplan＠redhat.com 06 Jul '14

06 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Edit interface- the last label should get the focus ...................................................................... webadmin: Edit interface- the last label should get the focus Change-Id: I3ad1d11aab2a833ac210a737bbb95319197c4f1e Bug-Url: https://bugzilla.redhat.com/1091676 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelEditor.java 2 files changed, 27 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ad1d11aab2a833ac210a737bbb95319197c4f1e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Fix DAO tests TemplateOwner can't edit template and...
by oourfali＠redhat.com 06 Jul '14

06 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Fix DAO tests TemplateOwner can't edit template and add/edit vnic in userportal. ...................................................................... engine : Fix DAO tests TemplateOwner can't edit template and add/edit vnic in userportal. Fix DAO tests Change-Id: I11cf9a0979b5cf1000406df8c5cb0c2e1a7625b5 Bug-Url: https://bugzilla.redhat.com/953043 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11cf9a0979b5cf1000406df8c5cb0c2e1a7625b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Retrieving only foreman's compute resources that relat...
by oourfali＠redhat.com 04 Jul '14

04 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Retrieving only foreman's compute resources that relates to oVirt ...................................................................... core: Retrieving only foreman's compute resources that relates to oVirt Adding search field to gather only ovirt info Change-Id: I859c786df87c58abbdca722a19f2e431e72c40e9 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I859c786df87c58abbdca722a19f2e431e72c40e9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Using signed password for ovirt-node provisioning
by oourfali＠redhat.com 04 Jul '14

04 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Using signed password for ovirt-node provisioning ...................................................................... core: Using signed password for ovirt-node provisioning Using MD5 signature util. Change-Id: I82d9e0f368e3b6e36098b33863ff7998f789688b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109540 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82d9e0f368e3b6e36098b33863ff7998f789688b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: uutils: add CryptMD5
by oourfali＠redhat.com 04 Jul '14

04 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: uutils: add CryptMD5 ...................................................................... uutils: add CryptMD5 Change-Id: Ice3c45197dd6ff27fd20dcff1e8249c815a756a7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/CryptMD5.java 1 file changed, 134 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice3c45197dd6ff27fd20dcff1e8249c815a756a7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : TemplateOwner can't edit template and add/edit vnic i...
by oourfali＠redhat.com 04 Jul '14

04 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : TemplateOwner can't edit template and add/edit vnic in userportal. ...................................................................... core : TemplateOwner can't edit template and add/edit vnic in userportal. When user have direct TemplateOwner role on template, he can't edit template in UserPortal and also can't add/edit vnic of template. Change-Id: I724187757513965ba6557d9d94ce7d3857a521a4 Bug-Url: https://bugzilla.redhat.com/953043 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I724187757513965ba6557d9d94ce7d3857a521a4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0