July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[master]: Corrections to the build system for el5
by vfeenstr＠redhat.com 01 Jul '14

01 Jul '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Corrections to the build system for el5 ...................................................................... Corrections to the build system for el5 Change-Id: I401b4b0ff68abaf492ab31379c79a18c588cfa00 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/Makefile.am M ovirt-guest-agent/Makefile.el5 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Betak: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I401b4b0ff68abaf492ab31379c79a18c588cfa00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: Bump to 1.0.10 for ovirt-3.5
by vfeenstr＠redhat.com 01 Jul '14

01 Jul '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Bump to 1.0.10 for ovirt-3.5 ...................................................................... Bump to 1.0.10 for ovirt-3.5 Change-Id: Ife1c6f7db53228d0e40242d620f9e40ff2344439 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ChangeLog M configure.ac M debian/changelog M debian/copyright M ovirt-guest-agent.rhel6.spec M ovirt-guest-agent.spec 6 files changed, 600 insertions(+), 4 deletions(-) Approvals: Martin Betak: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife1c6f7db53228d0e40242d620f9e40ff2344439 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: NetworkValidator uses new validation syntax
by mkolesni＠redhat.com 01 Jul '14

01 Jul '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: NetworkValidator uses new validation syntax ...................................................................... engine: NetworkValidator uses new validation syntax Refactor the NetworkValidator to use the new validation synatx for fluently specifying the validation when possible. In one instance the usage was with "when" instead of unless, since the positive case was easier to read than the negative one. Change-Id: I218166e474c0fb046791f9785f68ac39f4767793 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java 1 file changed, 16 insertions(+), 21 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I218166e474c0fb046791f9785f68ac39f4767793 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Clear syntax for writing validations
by mkolesni＠redhat.com 01 Jul '14

01 Jul '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Clear syntax for writing validations ...................................................................... engine: Clear syntax for writing validations Normally when using ValidationResult to do validations the code looks like the following examples: 1. Check positive case (using ternary operator): return FeatureSupported.nonVmNetwork(getDataCenter().getcompatibility_version()) ? ValidationResult.VALID : new ValidationResult(VdcBllMessages.NON_VM_NETWORK_NOT_SUPPORTED_FOR_POOL_LEVEL); 2. Check negative case (using if): VDSStatus hostStatus = getVds().getStatus(); if (hostStatus != VDSStatus.Maintenance && hostStatus != VDSStatus.Up && hostStatus != VDSStatus.NonOperational) { return new ValidationResult( VdcBllMessages.ACTION_TYPE_FAILED_VDS_STATUS_ILLEGAL, VdcBllMessages.VAR__HOST_STATUS__UP_MAINTENANCE_OR_NON_OPERATIONAL.name()); } return ValidationResult.VALID; 3. Check negative case (using ternary operator): return getVds() == null ? new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NOT_EXIST) : ValidationResult.VALID; And so forth.. The suggested syntax would enable simpler checking that is focused on a fluent syntax that's easy to write and read. To check a positive case you would write (Instead of example #1): return ValidationResult.failWith(VdcBllMessages.NON_VM_NETWORK_NOT_SUPPORTED_FOR_POOL_LEVEL) .unless(FeatureSupported.nonVmNetwork(getDataCenter().getcompatibility_version())); To check a negative case you would write (Instead of example #3): return ValidationResult.failWith(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NOT_EXIST) .when(getVds() == null); Example #2 could be rewritten in a similar matter (the condition could be simplified/extracted). The new syntax presents a more comprehensible way to read and write the validation logic, and abstracts the repetitive decision of returning the valid or invalid result. In the next patch there will be a small refactor to demonstrate the usage. In the future, the ValidationResult constructors could be hidden in favor of this API (after refactoring their usages). Change-Id: I2e40ce1bf69d2df45d3136a9f2db0afc00a02159 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ValidationResultTest.java 2 files changed, 112 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved Yair Zaslavsky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e40ce1bf69d2df45d3136a9f2db0afc00a02159 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: host-deploy: appropriate message for kdump detection
by oourfali＠redhat.com 01 Jul '14

01 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: appropriate message for kdump detection ...................................................................... host-deploy: appropriate message for kdump detection 1. a system that does not support kdump is expected, so it cannot be warning. 2. messages with '!' are not polite, user did not do anything to justify that. Change-Id: Ie10ebdbbc0b5148e4cd6e1b2deb251f96a2f56c7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie10ebdbbc0b5148e4cd6e1b2deb251f96a2f56c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use force detach only on Data SD
by mlipchuk＠redhat.com 01 Jul '14

01 Jul '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use force detach only on Data SD ...................................................................... core: Use force detach only on Data SD Use force detach on data storage domain instead on every domain which is not Export, so force detach of ISO domain will be prevented. Change-Id: I5784956d566d815b4471382b004879735ab016d2 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/29403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5784956d566d815b4471382b004879735ab016d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: no need to save vm_static on run once
by oourfali＠redhat.com 01 Jul '14

01 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: no need to save vm_static on run once ...................................................................... engine: no need to save vm_static on run once Change-Id: Idb5c0da8b0257a7751255665f4160391a1e3b2a5 Bug-Url: https://bugzilla.redhat.com/1108676 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb5c0da8b0257a7751255665f4160391a1e3b2a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: no need to save vm_static on run once
by shavivi＠redhat.com 01 Jul '14

01 Jul '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: no need to save vm_static on run once ...................................................................... engine: no need to save vm_static on run once Change-Id: Idb5c0da8b0257a7751255665f4160391a1e3b2a5 Bug-Url: https://bugzilla.redhat.com/1108676 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb5c0da8b0257a7751255665f4160391a1e3b2a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: remove Escape characters for TextBoxLabel
by shavivi＠redhat.com 01 Jul '14

01 Jul '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: remove Escape characters for TextBoxLabel ...................................................................... ui: remove Escape characters for TextBoxLabel The reason that we use: SafeHtmlUtils.htmlEscape(renderedText); is to prevent javascript code injection such as <script> etc. Its looks like the control is already safe rendering (tested with <script>, <b> and <h1>). without removing this line its render <>,. as theyer escaped value. Change-Id: I2e303decb9395fcf193e874b4ae55ab076ec0bba Bug-Url: https://bugzilla.redhat.com/1113499 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabel.java 1 file changed, 2 insertions(+), 11 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Looks good to me, approved Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e303decb9395fcf193e874b4ae55ab076ec0bba Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: handle fence agent power wait param on stop
by oourfali＠redhat.com 01 Jul '14

01 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: handle fence agent power wait param on stop ...................................................................... core: handle fence agent power wait param on stop When a host restart is dome manually or as a result of a non-responsive host treatment and in the case that power wait parameter is used the host may stay in 'off' state and even release its lock on HA VMs before the host is really down This is the scenario: 1) A restart command is issued and actually performed as stop -> wait for 'off' status -> start -> wait for 'on' status 2) power wait parameter is added to the command implicitly or explicitly giving a delay of X seconds before the operation is actually performed 3) The fence agent script returns immediately with 'off' status 4) A 'on' command is sent to the fence agent by the start operation 5) X seconds passed and the host is actually shutdown This patch handles this by adding a new configuration value that maps fence agents to the name of the parameter for power wait Upon stop operation, we will wait a fixed delay (5 seconds hard-coded) before starting to sample the host status, if power wait parameter is used, the value is extracted and we will wait for 5 + X seconds. Change-Id: I310e076ecf84988cacd0b179954d2460d7988b91 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114618 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 69 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I310e076ecf84988cacd0b179954d2460d7988b91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0