August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: backend: Fix timezone on import of Windows VMs
by tnisan＠redhat.com 27 Aug '14

27 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: backend: Fix timezone on import of Windows VMs ...................................................................... backend: Fix timezone on import of Windows VMs Incorrect default timezeone was being set based on uninitialized osId. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1123809 Change-Id: I61197951a3ea7e0aeb1a10a7f11e7cbefd9d99fe Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 12 insertions(+), 13 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/31972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61197951a3ea7e0aeb1a10a7f11e7cbefd9d99fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin:renaming "OpenStack Network" to "OpenStack Networking"
by tnisan＠redhat.com 27 Aug '14

27 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin:renaming "OpenStack Network" to "OpenStack Networking" ...................................................................... webadmin:renaming "OpenStack Network" to "OpenStack Networking" Change-Id: I6e6fc9b7ae4eb4d4e7c48c079800982dd5866022 Bug-Url: https://bugzilla.redhat.com/1096170 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Eliraz Levi: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e6fc9b7ae4eb4d4e7c48c079800982dd5866022 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: add managed virtio-serial devices on upgrade
by tnisan＠redhat.com 27 Aug '14

27 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: add managed virtio-serial devices on upgrade ...................................................................... core: add managed virtio-serial devices on upgrade The upgrade scripts do the following things: - Change every existing virtio-serial device to be managed - Then is adds managed virtio-serial device to VMs that don't have it In addition, we might get reports of unmanaged virtio-serial devices from VMs that were running at the time of the upgrade, so in that case we'll not add new device, but use the managed device instead. Change-Id: I5b99dd3fa0d43307788a685c0115b32691757454 Bug-Url: https://bugzilla.redhat.com/1028387 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java A packaging/dbscripts/upgrade/03_05_1020_change_virtio_serial_to_managed_device.sql 2 files changed, 36 insertions(+), 3 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b99dd3fa0d43307788a685c0115b32691757454 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Allow NLA auth for Native RDP execution
by tjelinek＠redhat.com 27 Aug '14

27 Aug '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Allow NLA auth for Native RDP execution ...................................................................... frontend: Allow NLA auth for Native RDP execution This patch allows Network Level Authentication in combination with Native RDP client. This is done by setting enablecredsspsupport flag in RDP descriptor to 1. Previously this flag was set to 0 which prevented clients to connect to RDP server with NLA enabled. This patch only affects 'Native client' invocation. The 'Browser plugin' still has this option disabled (enabling it would prevent passing password to ActiveX plugin and therefore SSO would be impossible). Also RDP info icon text in 'Console options' dialog was enhanced with information about NLA and SSO. Change-Id: If686b824aa05b6d0083b9be6eca681797c3c26f3 Bug-Url: https://bugzilla.redhat.com/1131693 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractRdp.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpNativeImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpPluginImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IRdp.java 5 files changed, 14 insertions(+), 12 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/31997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If686b824aa05b6d0083b9be6eca681797c3c26f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add max length validation to PM password
by oourfali＠redhat.com 27 Aug '14

27 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Add max length validation to PM password ...................................................................... webadmin: Add max length validation to PM password Adds max length (50 chars) validation to PM password option in Host detail popup. Change-Id: I30c6275f70b3692dd9fc25704b302d85e7651720 Bug-Url: https://bugzilla.redhat.com/1129553 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Peřina: Verified -- To view, visit http://gerrit.ovirt.org/31964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30c6275f70b3692dd9fc25704b302d85e7651720 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Do not suppress dismissed alerts
by oourfali＠redhat.com 27 Aug '14

27 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Do not suppress dismissed alerts ...................................................................... core: Do not suppress dismissed alerts No health check alert is issued in ui after first message was issued This patch fixed a problem when an alert is dismissed by the user. Current functionality did not addressed dismissed alerts and show for each host instance one alert from each type. In the case that the alert was dismissed by the user, it will not show again. This patch fix the SP that insert to audit log not to suppress the alert in case that the alert exists for the host instance but it was dismissed by the user (delete=true in audit_log table) Change-Id: Ie831e8ec49b81bcb49f106f2fb377cff4dc4566b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133611 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/audit_log_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie831e8ec49b81bcb49f106f2fb377cff4dc4566b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: extmgr: add logging for extension load/initialize
by yzaslavs＠redhat.com 27 Aug '14

27 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extmgr: add logging for extension load/initialize ...................................................................... extmgr: add logging for extension load/initialize easier to track what extension may misbehave. Change-Id: I03169863db00b5bf4ac5f827fbd0aebcf73a51f3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03169863db00b5bf4ac5f827fbd0aebcf73a51f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: fix builtin modules xml file
by yzaslavs＠redhat.com 27 Aug '14

27 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: fix builtin modules xml file ...................................................................... aaa: fix builtin modules xml file Change-Id: Ie7af7451b9a67e256ea87de75df301b8a07134a8 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7af7451b9a67e256ea87de75df301b8a07134a8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fix style misalignments in block domain view
by derez＠redhat.com 26 Aug '14

26 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix style misalignments in block domain view ...................................................................... webadmin: fix style misalignments in block domain view Some alignment issues were introduced in block storage dialog and DirectLUN disk dialog (lists/tabs/etc) - see attached screenshots in BZ. Change-Id: I21975fb1fb5193322bf0e0d3565cc03767a4052c Bug-Url: https://bugzilla.redhat.com/1133779 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 6 files changed, 12 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21975fb1fb5193322bf0e0d3565cc03767a4052c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix alignment in New Cluster dialog / Optimization
by awels＠redhat.com 26 Aug '14

26 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fix alignment in New Cluster dialog / Optimization ...................................................................... webadmin: fix alignment in New Cluster dialog / Optimization New Cluster dialog / Optimization tab had alignment and spacing issues. Fixed. Change-Id: Iae1712442dec2988e51312461df4c8669441f4ea Bug-Url: https://bugzilla.redhat.com/1123319 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 3 files changed, 18 insertions(+), 15 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae1712442dec2988e51312461df4c8669441f4ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0