August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: add DirectLUN disk - hide disk profile
by derez＠redhat.com 26 Aug '14

26 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add DirectLUN disk - hide disk profile ...................................................................... webadmin: add DirectLUN disk - hide disk profile Disk profile is not applicable for DirectLUN disks, hence, hide from DirectLUN disks dialog. Change-Id: If070376361b67d3502ea8d23c3198d1ed05e08d4 Bug-Url: https://bugzilla.redhat.com/1133776 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If070376361b67d3502ea8d23c3198d1ed05e08d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: Added release notes
by ydary＠redhat.com 26 Aug '14

26 Aug '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Added release notes ...................................................................... packaging: Added release notes Change-Id: Ie99b733194171d1119c85b8952ff9e0f34988dc6 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie99b733194171d1119c85b8952ff9e0f34988dc6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: Added release notes
by ydary＠redhat.com 26 Aug '14

26 Aug '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Added release notes ...................................................................... packaging: Added release notes Change-Id: Idab4bca3e6b6a876d11f034522aec58b52733b85 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idab4bca3e6b6a876d11f034522aec58b52733b85 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: Fix timezone on import of Windows VMs
by shavivi＠redhat.com 26 Aug '14

26 Aug '14

Shahar Havivi has submitted this change and it was merged. Change subject: backend: Fix timezone on import of Windows VMs ...................................................................... backend: Fix timezone on import of Windows VMs Incorrect default timezeone was being set based on uninitialized osId. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1123809 Change-Id: I61197951a3ea7e0aeb1a10a7f11e7cbefd9d99fe Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 12 insertions(+), 13 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61197951a3ea7e0aeb1a10a7f11e7cbefd9d99fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: sysprep custom variables should be in CDATA section
by shavivi＠redhat.com 26 Aug '14

26 Aug '14

Shahar Havivi has submitted this change and it was merged. Change subject: backend: sysprep custom variables should be in CDATA section ...................................................................... backend: sysprep custom variables should be in CDATA section for handling special characters we need to put all inputs inside xml CDATA section. Change-Id: I941e1422077383386ee788e75ae5ad38d1de39a2 Bug-Url: https://bugzilla.redhat.com/1122160 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M packaging/conf/sysprep/sysprep.2k12x64 M packaging/conf/sysprep/sysprep.2k8 M packaging/conf/sysprep/sysprep.2k8x64 M packaging/conf/sysprep/sysprep.w7 M packaging/conf/sysprep/sysprep.w7x64 M packaging/conf/sysprep/sysprep.w8 M packaging/conf/sysprep/sysprep.w8x64 7 files changed, 146 insertions(+), 146 deletions(-) Approvals: Shahar Havivi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I941e1422077383386ee788e75ae5ad38d1de39a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: disable 'Remove' for OVF store not in ILLEGAL status
by laravot＠redhat.com 26 Aug '14

26 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: webadmin: disable 'Remove' for OVF store not in ILLEGAL status ...................................................................... webadmin: disable 'Remove' for OVF store not in ILLEGAL status Currently when OVF store isn't in ILLEGAL status it can't be removed, this patch greys out the remove button in the webadmin in that case. Change-Id: Ie2defe1bc6dfb1a770546bc664bb141d0923a1fa Bug-Url: https://bugzilla.redhat.com/1131845 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2defe1bc6dfb1a770546bc664bb141d0923a1fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: isRemoveCommandAvailable() - removal of unneeded b...
by laravot＠redhat.com 26 Aug '14

26 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: webadmin: isRemoveCommandAvailable() - removal of unneeded booleans ...................................................................... webadmin: isRemoveCommandAvailable() - removal of unneeded booleans isRemoveCommandAvailable() is storing the checks results into booleans and checks them all at each iteration. The booleans can be replaced with comments and we can return immediately when the result is known. Change-Id: I808275fb826e2d4fd154e87aa9730f4c57b53002 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131845 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I808275fb826e2d4fd154e87aa9730f4c57b53002 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ignore cpu profile for instance type
by gchaplik＠redhat.com 26 Aug '14

26 Aug '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: ignore cpu profile for instance type ...................................................................... core: ignore cpu profile for instance type Since both template and instance type use same commands, CPU profile should be checked only for template. Change-Id: I5d2b043fbcfacd59d61cb26e28078df38554dc9f Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d2b043fbcfacd59d61cb26e28078df38554dc9f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: relax disk profile validation
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: relax disk profile validation ...................................................................... webadmin: relax disk profile validation Allow not passing the engine profile (to support lower compatibility versions) Change-Id: Ib4c9489659900f6855492c936bf71a6e2cb3c89a Bug-Url: https://bugzilla.redhat.com/1085049 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/31962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4c9489659900f6855492c936bf71a6e2cb3c89a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Change disk alias suggestions to use alias recycling
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Change disk alias suggestions to use alias recycling ...................................................................... webadmin: Change disk alias suggestions to use alias recycling In change 24061, disk alias suggestions was changed not to suggest a disk alias that is already attached to the VM, this change now also makes sure that the aliases will be recycled (i.e. if we had alias1 and alias2 and we deleted alias1, the next suggestion will be alias1) Change-Id: I8d5b8ba00a144b864208d971def7087182538be2 Bug-Url: https://bugzilla.redhat.com/1022795 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java 2 files changed, 13 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d5b8ba00a144b864208d971def7087182538be2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0