August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: add cpu profile support
by juan.hernandez＠redhat.com 25 Aug '14

25 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: add cpu profile support ...................................................................... restapi: add cpu profile support href="/ovirt-engine/api/cpuprofiles"; "add"; method: POST; request type: CpuProfile; response type: CpuProfile href="/ovirt-engine/api/cpuprofiles"; "get"; method: GET; response type: CpuProfiles href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}"; "delete"; method: DELETE href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}"; "get"; method: GET; response type: CpuProfile href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}"; "update"; method: PUT; request type: CpuProfile; response type: CpuProfile href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}/permissions"; "add"; method: POST; request type: Permission; response type: Permission href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}/permissions"; "get"; method: GET; response type: Permissions href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}/permissions/{permission:id}"; "delete"; method: DELETE href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}/permissions/{permission:id}"; "get"; method: GET; response type: Permission href="/ovirt-engine/api/clusters/{cluster:id}/cpuprofiles"; "add"; method: POST; request type: CpuProfile; response type: CpuProfile href="/ovirt-engine/api/clusters/{cluster:id}/cpuprofiles"; "get"; method: GET; response type: CpuProfiles href="/ovirt-engine/api/clusters/{cluster:id}/cpuprofiles/{cpuprofile:id}"; "delete"; method: DELETE href="/ovirt-engine/api/clusters/{cluster:id}/cpuprofiles/{cpuprofile:id}"; "get"; method: GET; response type: CpuProfile Change-Id: I65976b00665a7f6d87b3fa6f62e54c753c51238c Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedCpuProfileResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedCpuProfilesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ClusterResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CpuProfileResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CpuProfilesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfileResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfilesResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedCpuProfileResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedCpuProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCpuProfileResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCpuProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedCpuProfileResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedCpuProfilesResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCpuProfileResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCpuProfilesResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/CpuProfileMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/CpuProfileMapperTest.java 27 files changed, 1,326 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65976b00665a7f6d87b3fa6f62e54c753c51238c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: support cpu qos limit
by juan.hernandez＠redhat.com 25 Aug '14

25 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: support cpu qos limit ...................................................................... restapi: support cpu qos limit Add it to current qos infra. Change-Id: I176f7d3e5776c515f09db94177eeb679e71412af Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/QosType.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQosResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/CpuQosMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/QosMapperTest.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageQosMapperTest.java 10 files changed, 92 insertions(+), 20 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I176f7d3e5776c515f09db94177eeb679e71412af Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: add disk profile to disk
by juan.hernandez＠redhat.com 25 Aug '14

25 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: add disk profile to disk ...................................................................... restapi: add disk profile to disk Change-Id: Ie16441ce28390c42a0f97ab7014aa3669964ae57 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java 3 files changed, 15 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie16441ce28390c42a0f97ab7014aa3669964ae57 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: add disk profile support
by juan.hernandez＠redhat.com 25 Aug '14

25 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: add disk profile support ...................................................................... restapi: add disk profile support href="/ovirt-engine/api/diskprofiles"; "add"; method: POST; request type: DiskProfile; response type: DiskProfile href="/ovirt-engine/api/diskprofiles"; "get"; method: GET; response type: DiskProfiles href="/ovirt-engine/api/diskprofiles/{diskprofile:id}"; "delete"; method: DELETE href="/ovirt-engine/api/diskprofiles/{diskprofile:id}"; "get"; method: GET; response type: DiskProfile href="/ovirt-engine/api/diskprofiles/{diskprofile:id}"; "update"; method: PUT; request type: DiskProfile; response type: DiskProfile href="/ovirt-engine/api/diskprofiles/{diskprofile:id}/permissions"; "add"; method: POST; request type: Permission; response type: Permission href="/ovirt-engine/api/diskprofiles/{diskprofile:id}/permissions"; "get"; method: GET; response type: Permissions href="/ovirt-engine/api/diskprofiles/{diskprofile:id}/permissions/{permission:id}"; "delete"; method: DELETE href="/ovirt-engine/api/diskprofiles/{diskprofile:id}/permissions/{permission:id}"; "get"; method: GET; response type: Permission href="/ovirt-engine/api/storagedomains/{storagedomain:id}/diskprofiles"; "add"; method: POST; request type: DiskProfile; response type: DiskProfile href="/ovirt-engine/api/storagedomains/{storagedomain:id}/diskprofiles"; "get"; method: GET; response type: DiskProfiles href="/ovirt-engine/api/storagedomains/{storagedomain:id}/diskprofiles/{diskprofile:id}"; "delete"; method: DELETE href="/ovirt-engine/api/storagedomains/{storagedomain:id}/diskprofiles/{diskprofile:id}"; "get"; method: GET; response type: DiskProfile Change-Id: I65976b00665a7f6d87b3fa6f62e54c753c58548c Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedDiskProfileResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedDiskProfilesResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskProfileResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskProfilesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfileResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfilesResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedDiskProfileResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedDiskProfilesResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskProfileResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedDiskProfileResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedDiskProfilesResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskProfileResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskProfilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskProfileMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskProfileMapperTest.java 29 files changed, 1,332 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65976b00665a7f6d87b3fa6f62e54c753c58548c Gerrit-PatchSet: 32 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Refactor VM and Template mappers
by juan.hernandez＠redhat.com 25 Aug '14

25 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Refactor VM and Template mappers ...................................................................... restapi: Refactor VM and Template mappers Refactor VmMapper and TemplateMapper classe and extract common set of field mappings to newly created VmBaseMapper class. Also introduce new base resource class VmBase from which the VM and Template are derived similarly as they are implemented on the backend. Change-Id: Iddd80e10360234d75d142f224ecb8ad920fbf282 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmBaseMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 10 files changed, 398 insertions(+), 689 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/30189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddd80e10360234d75d142f224ecb8ad920fbf282 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Remove redundant header splitter
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove redundant header splitter ...................................................................... webadmin: Remove redundant header splitter The styling of ResizableHeader added a right border, which is redundant in the case of an EntityModelCellTable because there's always the left border of the next column header (as opposed to ActionCellTable whose styling works differently). Change-Id: Ied14df6f093514e26bbeb3dc60e509d58d056dae Bug-Url: https://bugzilla.redhat.com/1125192 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> (cherry picked from commit 034ea2168126a63c2fd4cf629581ef3a438fbbc0) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java 3 files changed, 27 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied14df6f093514e26bbeb3dc60e509d58d056dae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Expose effective SPICE proxy in VM.display
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Expose effective SPICE proxy in VM.display ...................................................................... restapi: Expose effective SPICE proxy in VM.display Change-Id: I0bc84f39c8b6a2da742baae9b0874c2f36c3738d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1054948 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 4 files changed, 61 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/31907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bc84f39c8b6a2da742baae9b0874c2f36c3738d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: fix popup dialog header text spacing
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: fix popup dialog header text spacing ...................................................................... userportal, webadmin: fix popup dialog header text spacing Changed popup dialog header text to be spaced with CSS only. Popup dialog header text was shifting left over the icon. This was a regression. Hopefully permanently fixed by restructuring the layout of the dialog header bar. Now when an icon is present, CSS takes care of moving the header text over. Also cleaned up some CSS class names for the dialog header. Bug-Url: https://bugzilla.redhat.com/1119027 Change-Id: I28ffde8e344b1bedc10310f6eb814a37a7aecefe Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml M packaging/branding/ovirt.brand/common.css R packaging/branding/ovirt.brand/images/dialog/dialog_header_TL.png A packaging/branding/ovirt.brand/images/dialog/dialog_header_TR.png R packaging/branding/ovirt.brand/images/dialog/dialog_header_background_repetitive.png D packaging/branding/ovirt.brand/images/dialog/dialog_header_image.png M packaging/branding/ovirt.brand/images/dialog/error.png M packaging/branding/ovirt.brand/images/dialog/guide.png M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css M packaging/branding/ovirt.brand/web_admin.css 12 files changed, 94 insertions(+), 85 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/31844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28ffde8e344b1bedc10310f6eb814a37a7aecefe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: stop special handling of '@' in user name
by awels＠redhat.com 25 Aug '14

25 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin, userportal: stop special handling of '@' in user name ...................................................................... webadmin, userportal: stop special handling of '@' in user name Simplify login page behavior: send user-name as is (don't parse by '@', etc.), don't disable the Domain drop-down. Change-Id: If7568c98c34e6edbd011949c5bad397aeba7b4ae Bug-Url: https://bugzilla.redhat.com/1112252 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java 1 file changed, 4 insertions(+), 45 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified Yair Zaslavsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7568c98c34e6edbd011949c5bad397aeba7b4ae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix height of EntityModelWidgetWithInfo
by lvernia＠redhat.com 25 Aug '14

25 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fix height of EntityModelWidgetWithInfo ...................................................................... webadmin: Fix height of EntityModelWidgetWithInfo Fixed the height to be the same as most other widgets, to correct all sorts of layout issues. Also removed references to styles that no longer exist. Change-Id: Ia3a8381cf747609389f6c2ec806bef65d9248ee1 Bug-Url: https://bugzilla.redhat.com/1115524 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.ui.xml 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3a8381cf747609389f6c2ec806bef65d9248ee1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0