August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: try to start the vm even if other hosts have the same score
by msivak＠redhat.com 18 Aug '14

18 Aug '14

Martin Sivák has submitted this change and it was merged. Change subject: try to start the vm even if other hosts have the same score ...................................................................... try to start the vm even if other hosts have the same score if there are hosts with the same best score all should try to start the VM otherwise we might end up in the situation when every host thinks the others are better and no one will start the VM Change-Id: Ib1ab72dfd8c4f07268eabe3e6fdc7a74929d9308 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093638 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> (cherry picked from commit 3b3fdf2e3b56f61d76d0073ed5a24d8833dc6302) --- M ovirt_hosted_engine_ha/agent/states.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/31513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1ab72dfd8c4f07268eabe3e6fdc7a74929d9308 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: cannot edit description of a VM from pool
by shavivi＠redhat.com 18 Aug '14

18 Aug '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: cannot edit description of a VM from pool ...................................................................... ui: cannot edit description of a VM from pool Bug-Url: https://bugzilla.redhat.com/1060518 Change-Id: I9273136a6dd1f3b6f28c329828c23f3a798c6075 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/31337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9273136a6dd1f3b6f28c329828c23f3a798c6075 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix fence-status operation
by oourfali＠redhat.com 18 Aug '14

18 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix fence-status operation ...................................................................... core: fix fence-status operation When the fencing policy is null, we check that the host is compatible with cluster level 3.0, which is wrong. This patch changes that by not checking cluster level when fencing policy is null. Also getMinimalSupportedVersion was modified to throw IllegalArgumentException when null is passed as parameter. Change-Id: Idecf91da729cbd8744f894c341b7044cc791853d Bug-Url: https://bugzilla.redhat.com/1130791 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/FencingPolicyHelper.java 2 files changed, 17 insertions(+), 11 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idecf91da729cbd8744f894c341b7044cc791853d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: DeactivateStorageDomain - removing unneeded part of lo...
by laravot＠redhat.com 18 Aug '14

18 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: core: DeactivateStorageDomain - removing unneeded part of log message ...................................................................... core: DeactivateStorageDomain - removing unneeded part of log message getExceptionString() always returns null, therefore there's no need to have it logged. Change-Id: I226ab3c43d8bddbca495be933f700d97641886e1 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/31564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I226ab3c43d8bddbca495be933f700d97641886e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SpmStopOnIrs - set result
by laravot＠redhat.com 18 Aug '14

18 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: core: SpmStopOnIrs - set result ...................................................................... core: SpmStopOnIrs - set result When executing SpmStopOnIrs we should set the return value to be as the return value of the command that's being executed, otherwise the caller can't tell what actually happend. Change-Id: I5eb2a4c788ef5cf571a8de150355c85e3a9ae77a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130222 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SpmStopOnIrsVDSCommand.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/31563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5eb2a4c788ef5cf571a8de150355c85e3a9ae77a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: gluster volume geo replication entities
by ofrenkel＠redhat.com 18 Aug '14

18 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: engine: gluster volume geo replication entities ...................................................................... engine: gluster volume geo replication entities Gluster volume geo replication entities Change-Id: If86abee9276b8f2e4bdd4a4276dbbd76b9514c68 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepCrawlStatus.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepSessionStatus.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionConfiguration.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 6 files changed, 374 insertions(+), 0 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If86abee9276b8f2e4bdd4a4276dbbd76b9514c68 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: redundant call to vminit when initializing vms template
by shavivi＠redhat.com 18 Aug '14

18 Aug '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: redundant call to vminit when initializing vms template ...................................................................... ui: redundant call to vminit when initializing vms template When setting vminit to desktop vm (one that have a template), we call again vminit.init() method - after it has been initialize with the right values. Removing that not influence current code work-flow (ie vm, template and pool) Change-Id: Idc2e40f72b85cd3641c6e5c705438cd217308f91 Bug-Url: https://bugzilla.redhat.com/1126195 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/31382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc2e40f72b85cd3641c6e5c705438cd217308f91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : CoCo Handle restart logic for commands
by tnisan＠redhat.com 18 Aug '14

18 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: engine : CoCo Handle restart logic for commands ...................................................................... engine : CoCo Handle restart logic for commands When a command has failed due to an exception in executeCommand method the status of the command is set to FAILED and the execute flag is false. If the server is restarted before the callback is notified the status of the command should not be set to FAILED_RESTARTED and the callback's onFailed should called after restart for both FAILED and FAILED_RESTARTED commands Change-Id: I9d00ea9d29acfa4894595a978a8376a530c2fc8d Bug-Url: https://bugzilla.redhat.com/1129885 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit c01ac6733886c0108937251ccbc4948309e41688) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d00ea9d29acfa4894595a978a8376a530c2fc8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Second suspend of a vm doesn't work
by tnisan＠redhat.com 18 Aug '14

18 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: engine : Second suspend of a vm doesn't work ...................................................................... engine : Second suspend of a vm doesn't work When the vm is suspended in succession the second time it is suspended after a run the backend throws a NPE because the RunVMCommand does not set the entity info in the action parameters. Change-Id: Ib6d142ad00e9045a615d5489cb7104a2404bcf08 Bug-Url: https://bugzilla.redhat.com/1128807 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 2e85cd3957d379866765e843b4915efcf0dd4aa2) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6d142ad00e9045a615d5489cb7104a2404bcf08 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : CoCo Handle restart logic for commands
by oourfali＠redhat.com 18 Aug '14

18 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : CoCo Handle restart logic for commands ...................................................................... engine : CoCo Handle restart logic for commands When a command has failed due to an exception in executeCommand method the status of the command is set to FAILED and the execute flag is false. If the server is restarted before the callback is notified the status of the command should not be set to FAILED_RESTARTED and the callback's onFailed should called after restart for both FAILED and FAILED_RESTARTED commands Change-Id: I9d00ea9d29acfa4894595a978a8376a530c2fc8d Bug-Url: https://bugzilla.redhat.com/1129885 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d00ea9d29acfa4894595a978a8376a530c2fc8d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0