August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Cleanup: Removed unused code
by amureini＠redhat.com 13 Aug '14

13 Aug '14

Allon Mureinik has submitted this change and it was merged. Change subject: Cleanup: Removed unused code ...................................................................... Cleanup: Removed unused code StorageDomainValidator.isDomainHasNoImages() is not used and now removed from the code. Change-Id: Ie1f3a3a31a3b428db69bbdbc86bc9a91c8076dd8 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/31452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1f3a3a31a3b428db69bbdbc86bc9a91c8076dd8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: next page not working
by awels＠redhat.com 13 Aug '14

13 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: next page not working ...................................................................... userportal,webadmin: next page not working - Due to commit d98ef3131f9fd6ff3fcbad02a3601a52392d2800 the next page wasn't working anymore. This was caused by reverse boolean check. This patch fixes the check. Change-Id: I096ae25229b839c27c288040d7996eeb468acb63 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1123614 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Alexander Wels: Verified -- To view, visit http://gerrit.ovirt.org/31410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I096ae25229b839c27c288040d7996eeb468acb63 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: common: introduce qos package, and storage qos
by gchaplik＠redhat.com 13 Aug '14

13 Aug '14

Gilad Chaplik has submitted this change and it was merged. Change subject: common: introduce qos package, and storage qos ...................................................................... common: introduce qos package, and storage qos - Base Qos abstract class, in the future all QoS will inherit it. - QosType (version >= 3.3 network, version >= 3.5 disk, cpu), to distinguish between the types. - StorageQos object as the first implementation. - Handle field validation propeties. For more information see http://www.ovirt.org/Features/aggregate_QoS, http://www.ovirt.org/Features/blkio-support Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 378 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: Require bzip2
by sbonazzo＠redhat.com 13 Aug '14

13 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: Require bzip2 ...................................................................... packaging: spec: Require bzip2 engine-backup needs bzip2. Change-Id: I4c20ef5393b20336cfe38c2405a000a8b58e8c62 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/31441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c20ef5393b20336cfe38c2405a000a8b58e8c62 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: ovf: move compat xml to ovf as it is the only consumer
by oourfali＠redhat.com 13 Aug '14

13 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: utils: ovf: move compat xml to ovf as it is the only consumer ...................................................................... utils: ovf: move compat xml to ovf as it is the only consumer Change-Id: Iae2b6e697f82702cfb211c670a079f2da14994de Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/compat/exclude-filters.xml M backend/manager/modules/utils/exclude-filters.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfParser.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlAttribute.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlAttributeCollection.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlDocument.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlNamespaceManager.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlNode.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlNodeList.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlTextWriter.java 16 files changed, 53 insertions(+), 52 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae2b6e697f82702cfb211c670a079f2da14994de Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: fix logical loop in deps
by sbonazzo＠redhat.com 13 Aug '14

13 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: fix logical loop in deps ...................................................................... packaging: setup: fix logical loop in deps An addition to I767a574aa19be57e66ad0541d38852c953591d2f for remove/rename. Change-Id: Id0f2f9d55ffbab69f0c8b74b003295fc65cfc90b Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/misc.py 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/31449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0f2f9d55ffbab69f0c8b74b003295fc65cfc90b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: backward compatibility for template's monitor devices
by ahadas＠redhat.com 13 Aug '14

13 Aug '14

Arik Hadas has submitted this change and it was merged. Change subject: core: backward compatibility for template's monitor devices ...................................................................... core: backward compatibility for template's monitor devices In 8c53fa4 we implemented backward compatibility for VM's monitor devices. This patch do the same for templates. Change-Id: I00f365263827b4c154cd1f762fce9afbe73e5015 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 3 files changed, 10 insertions(+), 22 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/29843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00f365263827b4c154cd1f762fce9afbe73e5015 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: confusing error message retrieving from http session
by tnisan＠redhat.com 13 Aug '14

13 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: confusing error message retrieving from http session ...................................................................... engine: confusing error message retrieving from http session - Fixed confusing error message when retrieving non existing value from http session. Instead of throwing error message in log, just return null. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1101551 Change-Id: I336430e35bbbad07ea9566c8f5293980056361de Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I336430e35bbbad07ea9566c8f5293980056361de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Rename TaskManagerUtil to CommandCoordinatorUtil
by tnisan＠redhat.com 13 Aug '14

13 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: engine : Rename TaskManagerUtil to CommandCoordinatorUtil ...................................................................... engine : Rename TaskManagerUtil to CommandCoordinatorUtil Rename TaskManagerUtil to CommandCoordinatorUtil Change-Id: Idf796edd6c0812dac03bbf1e71b637e9d2b452e5 Bug-Url: https://bugzilla.redhat.com/1127774 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandEntityCleanupManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTasksStatusesByTasksIDsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java 20 files changed, 68 insertions(+), 68 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31346 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf796edd6c0812dac03bbf1e71b637e9d2b452e5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: spec: Confict with dwh/reports 3.4 setup
by tnisan＠redhat.com 13 Aug '14

13 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: spec: Confict with dwh/reports 3.4 setup ...................................................................... packaging: spec: Confict with dwh/reports 3.4 setup setup plugins of dwh/reports 3.4 do not work well with engine-setup 3.5 Change-Id: I41485912f97bef698897105ede46bd6e8b748986 Bug-Url: https://bugzilla.redhat.com/1129568 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/31435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41485912f97bef698897105ede46bd6e8b748986 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0