September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Show correct tooltip in disks tab when a disk is u...
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Show correct tooltip in disks tab when a disk is unattached ...................................................................... webadmin: Show correct tooltip in disks tab when a disk is unattached Bug-Url: https://bugzilla.redhat.com/1140093 Change-Id: Ibc9858297ff9f4cace04707a8894c95429bf2422 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc9858297ff9f4cace04707a8894c95429bf2422 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: VmGuideModel - fix new disk dialog title
by derez＠redhat.com 30 Sep '14

30 Sep '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: VmGuideModel - fix new disk dialog title ...................................................................... webadmin: VmGuideModel - fix new disk dialog title GuideMe -> New disk dialog: fixed dialog title. Change-Id: Ia2ccf6d4110d0772a8bf119486eeaa103bff3bb3 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/33523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2ccf6d4110d0772a8bf119486eeaa103bff3bb3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Do not attempt to extend a block domain if LUNs dat...
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Do not attempt to extend a block domain if LUNs data not supplied ...................................................................... restapi: Do not attempt to extend a block domain if LUNs data not supplied When editing a block domain via REST, in case the storage data was not supplied there is still a comparison between the old an new LUNs which results in an NPE, in that case we just skip the comparison if the data was not sent in the request Change-Id: Ibf4b28c2dbc289b88107f1e7fdc19127fb536326 Bug-Url: https://bugzilla.redhat.com/1115966 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf4b28c2dbc289b88107f1e7fdc19127fb536326 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: Report on insufficient parameters on add provider form
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: ui: Report on insufficient parameters on add provider form ...................................................................... ui: Report on insufficient parameters on add provider form Adding report on insufficient parameters on test if authentication parameters are missing Change-Id: Iafcb126db61fe1ac1b4b668a78c3b09b95fefe90 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1125961 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafcb126db61fe1ac1b4b668a78c3b09b95fefe90 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: userportal, webadmin: keep proper USB support selection
by oourfali＠redhat.com 30 Sep '14

30 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: userportal,webadmin: keep proper USB support selection ...................................................................... userportal,webadmin: keep proper USB support selection There were 2 problems: 1: the UnitVmModel.initUsbPolicy() did set the USB policy always to "disabled". Fixed by making sure that if the previously selected still applys than select it 2: The UnitVmModel.updateDisplayProtocol() have delegated the selection of the old display protocol to behavior.postDisplayTypeItemChanged which is too late, because meanwhile the VNC has been selected by getDisplayProtocol().setItems() which fired an appropriate event which in turn changed the USB support to "disabled" Fixed by removing the logic from VmModelBehaviorBase and moved it into the updateDisplayProtocol() to make sure the event is fired only when needed. Change-Id: I7e1b1048784e9d0c289fab13b4d8b9b80afd6cc9 Bug-Url: https://bugzilla.redhat.com/966415 Bug-Url: https://bugzilla.redhat.com/1080144 Bug-Url: https://bugzilla.redhat.com/1147827 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 27 insertions(+), 53 deletions(-) Approvals: Tomas Jelinek: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e1b1048784e9d0c289fab13b4d8b9b80afd6cc9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: frontend: Fix SPICE-ActiveX upgrade issues
by oourfali＠redhat.com 30 Sep '14

30 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: Fix SPICE-ActiveX upgrade issues ...................................................................... frontend: Fix SPICE-ActiveX upgrade issues This patch basically reverts previous IE 11 workaround: Syntax error (missing '+' to concatenate strings) in SpicePluginImpl caused silent fail of activex plugin in IE. This patch addresses this. This patch also removes IE11 workaround from SpicePluginImpl (i.e. dummy <PARAM NAME="SecurePort" VALUE="0">). Current SPICE ActiveX plugin already works on IE 11 without this workaround (moreover - it crashes with it!). Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Bug-Url: https://bugzilla.redhat.com/1147609 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/33516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: skip non-responding hosts in proxy selection.
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: skip non-responding hosts in proxy selection. ...................................................................... core: skip non-responding hosts in proxy selection. non-responding host is selected as a proxy for fencing operations This patch adds the host NonResponsive status as an illegal status for the proxy selection algorithm. Hosts that are in NonResponsive state have communication problems that prevents them from being proxy candidates. Change-Id: Idaa861b32b20cca43a7fe41f318c3e8bcec4c95d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145321 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaa861b32b20cca43a7fe41f318c3e8bcec4c95d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Fix SPICE-ActiveX upgrade issues
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Fix SPICE-ActiveX upgrade issues ...................................................................... frontend: Fix SPICE-ActiveX upgrade issues This patch basically reverts previous IE 11 workaround: Syntax error (missing '+' to concatenate strings) in SpicePluginImpl caused silent fail of activex plugin in IE. This patch addresses this. This patch also removes IE11 workaround from SpicePluginImpl (i.e. dummy <PARAM NAME="SecurePort" VALUE="0">). Current SPICE ActiveX plugin already works on IE 11 without this workaround (moreover - it crashes with it!). Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Bug-Url: https://bugzilla.redhat.com/1081533 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/33488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Fix SPICE-ActiveX upgrade issues
by tjelinek＠redhat.com 30 Sep '14

30 Sep '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix SPICE-ActiveX upgrade issues ...................................................................... frontend: Fix SPICE-ActiveX upgrade issues This patch basically reverts previous IE 11 workaround: Syntax error (missing '+' to concatenate strings) in SpicePluginImpl caused silent fail of activex plugin in IE. This patch addresses this. This patch also removes IE11 workaround from SpicePluginImpl (i.e. dummy <PARAM NAME="SecurePort" VALUE="0">). Current SPICE ActiveX plugin already works on IE 11 without this workaround (moreover - it crashes with it!). Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Bug-Url: https://bugzilla.redhat.com/1081533 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/33487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: notifier: add support for snmpv6 in SNMP_MANAGERS.
by oourfali＠redhat.com 30 Sep '14

30 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: notifier: add support for snmpv6 in SNMP_MANAGERS. ...................................................................... notifier: add support for snmpv6 in SNMP_MANAGERS. Change-Id: I9a21038928b7e553feefb9ab7669eac588c1c93c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073498 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java A backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/transport/snmp/ProfileTest.java M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 3 files changed, 60 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a21038928b7e553feefb9ab7669eac588c1c93c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0