January 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Leave free space value as null
by amureini＠redhat.com 25 Jan '15

25 Jan '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Leave free space value as null ...................................................................... core: Leave free space value as null In Some situations, such as a newly created disks or disks on a storage domain that's been re-connected, the disk's free space - StorageDomainDynamic.availableDiskSize is null. This was interpreted into 0 in some cases, causing a strict reaction from the system, though is doesn't necessarily means the storage has 0 space. These cases are now using the null value and do not assume low space. The value will be updated on the next poll from vdsm, making sure future behaviour is as is should. Change-Id: I3379f34c0022eb7066db400f9d9342f8d02fb85f Bug-Url: https://bugzilla.redhat.com/1177147 Bug-Url: https://bugzilla.redhat.com/1182012 Related-To: https://bugzilla.redhat.com/1176854 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 3 files changed, 17 insertions(+), 17 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/37250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3379f34c0022eb7066db400f9d9342f8d02fb85f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : Change message on import data domain
by amureini＠redhat.com 25 Jan '15

25 Jan '15

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin : Change message on import data domain ...................................................................... webadmin : Change message on import data domain When importing a data domain to a DC below 3.5 the information message should be changed to :"The selected Data center compatibility version does not support importing a data domain with its entities(VM's and Templates). The domain will be imported without them." Change-Id: I77a292acca38751b078daf61ba5c9ffb7601600a Bug-Url: https://bugzilla.redhat.com/1182109 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit http://gerrit.ovirt.org/37214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77a292acca38751b078daf61ba5c9ffb7601600a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: ovf_store isn't added
by gchaplik＠redhat.com 25 Jan '15

25 Jan '15

Gilad Chaplik has submitted this change and it was merged. Change subject: core: ovf_store isn't added ...................................................................... core: ovf_store isn't added When disk is added and there is no active user- currently only for ovf_store disk, disk profile permission check causes NPE. Since user is null when command is invoked by the internally, we can skip the permission check. Bug-Url: https://bugzilla.redhat.com/1185615 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Change-Id: I0ab3247d0f80e2f5123aace3fac58bee2a8a7b8d --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified Allon Mureinik: Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ab3247d0f80e2f5123aace3fac58bee2a8a7b8d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Bump openstack-java-sdk version to 3.0.6
by oourfali＠redhat.com 25 Jan '15

25 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Bump openstack-java-sdk version to 3.0.6 ...................................................................... engine: Bump openstack-java-sdk version to 3.0.6 Version 3.0.6 supports connecting to the openstack Juno identity service. Change-Id: Ie462cd84893330d501be2f2cbb5e9c2003cd206c Bug-Url: https://bugzilla.redhat.com/1177890 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Eyal Edri: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, but someone else must approve Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie462cd84893330d501be2f2cbb5e9c2003cd206c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: sharpen the test for engine enabled
by tnisan＠redhat.com 25 Jan '15

25 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: sharpen the test for engine enabled ...................................................................... packaging: setup: sharpen the test for engine enabled Without this change: 1. install and setup engine on machine A 2. install and setup other components (dwh, reports, wsp) on machine B 3. install engine on machine B 4. Run engine-setup - will silently enable the engine This was done for upgrades from 3.4 that need to enable the engine in the environment, because in 3.4 it was always enabled and there was no environment for that. This change also checks the engine FQDN in engine config files and compares that with our FQDN. We enable if exists and equal. Bug-Url: https://bugzilla.redhat.com/1181586 Change-Id: Ie58fcaff0925f3b5ac16fc5159a3eda4498f0b6e Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 67d346cfc4efd7d620d20e6b626392ae39246280) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py 1 file changed, 23 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/37187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie58fcaff0925f3b5ac16fc5159a3eda4498f0b6e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add the exception to the query result on failure
by mlipchuk＠redhat.com 25 Jan '15

25 Jan '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add the exception to the query result on failure ...................................................................... core: Add the exception to the query result on failure Adding the exception when calling GetUnregisteredBlockStorageDomainsQuery, so once this query will be called from the REST we can know the origin of the failure. Change-Id: I3fb4163c52ec0f8d3ad38681a2946f405dc805a7 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/37258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fb4163c52ec0f8d3ad38681a2946f405dc805a7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Preventing moving a shareable disk to a Gluster do...
by derez＠redhat.com 25 Jan '15

25 Jan '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Preventing moving a shareable disk to a Gluster domain ...................................................................... webadmin: Preventing moving a shareable disk to a Gluster domain Gluster doamin does not support shareable disks- therefore UI now prevents this action. Change-Id: Ibc2ea43f2131056c6f9ea86ecfb574fe71b638be Bug-Url: https://bugzilla.redhat.com/1135771 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Amit Aviram: Verified -- To view, visit http://gerrit.ovirt.org/36359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc2ea43f2131056c6f9ea86ecfb574fe71b638be Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fix pom for 3.5.2
by tnisan＠redhat.com 25 Jan '15

25 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix pom for 3.5.2 ...................................................................... core: Fix pom for 3.5.2 Replaced lingering 3.5.1 with 3.5.2 Change-Id: Iab3a15349311c377f503b9cfb5809ef20076e86f Bug-Url: https://bugzilla.redhat.com/1155170 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M build/validations/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/37230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab3a15349311c377f503b9cfb5809ef20076e86f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: override SSL protocol to TLSv1
by oourfali＠redhat.com 25 Jan '15

25 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: override SSL protocol to TLSv1 ...................................................................... core: override SSL protocol to TLSv1 Some newer JDK versions disabled the use of SSLv3, so we need to make sure to set the protocol to TLSv1 Change-Id: I7ebf1021231d888451a14201639f623aa1384d82 Bug-Url: https://bugzilla.redhat.com/1185430 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ebf1021231d888451a14201639f623aa1384d82 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: override SSL protocol to TLSv1
by oourfali＠redhat.com 25 Jan '15

25 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: override SSL protocol to TLSv1 ...................................................................... core: override SSL protocol to TLSv1 Some newer JDK versions disabled the use of SSLv3, so we need to make sure to set the protocol to TLSv1 Change-Id: I7ebf1021231d888451a14201639f623aa1384d82 Bug-Url: https://bugzilla.redhat.com/1185430 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ebf1021231d888451a14201639f623aa1384d82 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0