January 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: Remove unneeded comment
by sbonazzo＠redhat.com 27 Jan '15

27 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Remove unneeded comment ...................................................................... packaging: setup: Remove unneeded comment Removing a wrong comment about uninstall files - the code it talks about is still relevant for users running cleanup after upgrade from 3.3. Change-Id: I093c19d192dcf6beb7320c75ab5831caecd30212 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I093c19d192dcf6beb7320c75ab5831caecd30212 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Validate if the host is connected to the storage id.
by juan.hernandez＠redhat.com 27 Jan '15

27 Jan '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Validate if the host is connected to the storage id. ...................................................................... restapi: Validate if the host is connected to the storage id. Adding a validation to check if the Host is connected to the iSCSI storage domain before importing it. The import process should be after the Host has been connected to the targets and can see the Storage Domain with the id which has been configured in the request. Change-Id: I6a6376a358c0c3d02960efe12b3a8b79cd62aeb1 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6376a358c0c3d02960efe12b3a8b79cd62aeb1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin : Change message on import data domain
by tnisan＠redhat.com 27 Jan '15

27 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin : Change message on import data domain ...................................................................... webadmin : Change message on import data domain When importing a data domain to a DC below 3.5 the information message should be changed to :"The selected Data center compatibility version does not support importing a data domain with its entities(VM's and Templates). The domain will be imported without them." Commit for 3.5.1 Change-Id: I77a292acca38751b078daf61ba5c9ffb7601600a Bug-Url: https://bugzilla.redhat.com/1185666 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Freddy Rolland: Verified -- To view, visit http://gerrit.ovirt.org/37276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77a292acca38751b078daf61ba5c9ffb7601600a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: nit: removing useless todo
by sbonazzo＠redhat.com 27 Jan '15

27 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: nit: removing useless todo ...................................................................... nit: removing useless todo Change-Id: I96db1057d89378fe074711ab3ca65e753e8f7591 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/cpu.py 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96db1057d89378fe074711ab3ca65e753e8f7591 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add API to support warning for attached Storage Dom...
by juan.hernandez＠redhat.com 27 Jan '15

27 Jan '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add API to support warning for attached Storage Domains ...................................................................... restapi: Add API to support warning for attached Storage Domains Adding a REST API to support warning for attached Storage Domains on attach or import of Storage Domain. POST /api/storagedomains/d97c4fc5-bf5d-41a3-94c6-8fe821f98ff0/isattached HTTP/1.1 Accept: application/xml Content-type: application/xml <action> <host id="383a1e8d-d299-45d4-84d5-9bcc9fcf8823"></host> </action> The response which should returned is a Storage Domain with the flag is_attached. as so: <?xml version="1.0" encoding="UTF-8" standalone="yes"?> <storage_domain id="d97c4fc5-bf5d-41a3-94c6-8fe821f98ff0"> <is_attached>false</is_attached> </storage_domain> The operation is not implemented with GET since the operation requires the connection-host to be provided as parameter. Change-Id: I4b12e5ea2abea66cb950e3cdd64baaaff72a6919 Bug-Url: https://bugzilla.redhat.com/1179246 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java 4 files changed, 64 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/36849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b12e5ea2abea66cb950e3cdd64baaaff72a6919 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[master]: upload: use low level copy and print a progress bar
by sbonazzo＠redhat.com 27 Jan '15

27 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: use low level copy and print a progress bar ...................................................................... upload: use low level copy and print a progress bar Using python code to copy the file measuring its progress and printing a progress bar. Change-Id: I029e1d59fa51cb97514e5c3f4e9d35c2d2b67abe Bug-Url: https://bugzilla.redhat.com/1077235 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 55 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I029e1d59fa51cb97514e5c3f4e9d35c2d2b67abe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: Renamed NewTemplate* to EditTemplate*
by tjelinek＠redhat.com 27 Jan '15

27 Jan '15

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Renamed NewTemplate* to EditTemplate* ...................................................................... userportal,webadmin: Renamed NewTemplate* to EditTemplate* This widgets/viewes are used to edit the template but were called "NewTemplate". Change-Id: Ib48a289c623e44eae22f80e2ddcf2ca621f45324 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/template/TemplateEditPopupWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java R frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/template/TemplateEditPopupPresenterWidget.java R frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/template/TemplateEditPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/template/UserPortalTemplateListProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/TemplateModule.java R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/template/TemplateEditPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/template/TemplateEditPopupView.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/template/TemplateNewPopupView.java 10 files changed, 63 insertions(+), 63 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib48a289c623e44eae22f80e2ddcf2ca621f45324 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: missing cluster policy validation
by oourfali＠redhat.com 27 Jan '15

27 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: missing cluster policy validation ...................................................................... core: missing cluster policy validation Regression made by recent AddVdsGroupCommand#canDoAction refactoring Change-Id: Ie84058decb0994c1981f77858ff62346884eeeff Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie84058decb0994c1981f77858ff62346884eeeff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add default-options to iDrac7 Fencing agent
by oourfali＠redhat.com 27 Jan '15

27 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add default-options to iDrac7 Fencing agent ...................................................................... core: Add default-options to iDrac7 Fencing agent Adding implicit default parameters for drac7 that will be sent by engine when a fencing operation is executed against drac PM agent. Change-Id: Iea36b5fab3879fe3ea3e820154991cfa7c70ea63 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1166755 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea36b5fab3879fe3ea3e820154991cfa7c70ea63 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Javanize AddVdsActionParameters
by oourfali＠redhat.com 27 Jan '15

27 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Javanize AddVdsActionParameters ...................................................................... core: Javanize AddVdsActionParameters * Format the class * Maintain naming conventions * Remove redundant code * Organize the class Change-Id: Idcb067baa3b6f4f3be057d881e29c29e22dcad21 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVdsActionParameters.java 1 file changed, 46 insertions(+), 30 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idcb067baa3b6f4f3be057d881e29c29e22dcad21 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0