October 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: Correctly finish Remove VM Pool job
by tnisan＠redhat.com 07 Oct '15

07 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Correctly finish Remove VM Pool job ...................................................................... core: Correctly finish Remove VM Pool job For every VM in the pool removed, the endAction() of the corresponding RemoveVmCommand must be called. For this purpose, RemoveVmCommand must be parent command of all async tasks, not RemoveVmPoolCommand. Also, adding IDs of all async tasks to the return value of RemoveVmPoolCommand (RemoveVmCommand also needed to be fixed to add the IDs to the correct list if RemoveVmCommand is executed as internal command). Change-Id: I49e31a498cf57dc8a1b459c79fbe4566cd3d0e89 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257132 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49e31a498cf57dc8a1b459c79fbe4566cd3d0e89 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin, userportal: Contextual alert messages
by tnisan＠redhat.com 07 Oct '15

07 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin,userportal: Contextual alert messages ...................................................................... webadmin,userportal: Contextual alert messages This patch introduces an infrastructure for displaying contextual alert messages in top-center part of oVirt's main (post-login) UI. Being part of gwt-common module, this infrastructure is usable from both WebAdmin and UserPortal applications through AlertManager class. Messages shown via AlertManager are visible only within the main section; any messages requested while in login section will be 'replayed' once the user logs in. Messages shown via AlertManager are one-line messages. If the message overflows its designated alert box area, a tooltip is added so that moving mouse over that area reveals the full message. This patch also implements an 'Uncaught exception' alert message triggered by global uncaught exception handler (see BaseApplicationInit.initUncaughtExceptionHandler). This is to inform users about UI-specific runtime errors that might break UI behavior. Screenshots: 'Danger' alert http://imgur.com/xcZhcaK 'Warning' alert http://imgur.com/Jgdl6vA 'Success' alert http://imgur.com/U9EGejw 'Info' alert http://imgur.com/llLVR9d 'Danger' alert, with tooltip http://imgur.com/CDpgics Change-Id: Ic0928ea873305bf7246f6b7c6ec255fa785ca1b3 Bug-Url: https://bugzilla.redhat.com/1215727 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/ElementTooltip.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/MainSectionPresenter.java M packaging/branding/ovirt.brand/branding.properties M packaging/branding/ovirt.brand/ovirt.css 10 files changed, 260 insertions(+), 11 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/47074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0928ea873305bf7246f6b7c6ec255fa785ca1b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: spec: aligned vdsm with 3.6
by sbonazzo＠redhat.com 07 Oct '15

07 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: aligned vdsm with 3.6 ...................................................................... packaging: spec: aligned vdsm with 3.6 Change-Id: Ib39b76cd2534d9e4d1f09a0dbd441039b6e0e3fd Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib39b76cd2534d9e4d1f09a0dbd441039b6e0e3fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix "Activate disk" checkbox position on attach di...
by tnisan＠redhat.com 07 Oct '15

07 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix "Activate disk" checkbox position on attach disks popup ...................................................................... webadmin: Fix "Activate disk" checkbox position on attach disks popup Change-Id: I160a1fd8192696c9849914fbd5609d61274605e1 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1180883 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.ui.xml 3 files changed, 12 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I160a1fd8192696c9849914fbd5609d61274605e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Add tooltips to alias and source domain in move di...
by tnisan＠redhat.com 07 Oct '15

07 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add tooltips to alias and source domain in move disk dialog ...................................................................... webadmin: Add tooltips to alias and source domain in move disk dialog Added tooltips to disk alias and source domain name in disk allocation view it will now show a tooltip with the complete names Change-Id: Iabdd221d8f317f1e37a1c4cd836b9ac1722e9040 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1149450 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabdd221d8f317f1e37a1c4cd836b9ac1722e9040 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin, userportal: DOM flag to guard user interaction
by tnisan＠redhat.com 07 Oct '15

07 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin,userportal: DOM flag to guard user interaction ...................................................................... webadmin,userportal: DOM flag to guard user interaction Both WebAdmin and UserPortal are single-page web applications comprised of multiple places (UI states). Transitions between application's places are triggered either via UI interaction (e.g. clicking a main tab) or via manual URL change. Once the application starts transitioning from one place to another, user interaction should be avoided. For human users, this is accomplished via invisible "glass" overlay [1] that effectively blocks user-triggered DOM events (e.g. click) from reaching application's UI. [1] com.gwtplatform.mvp.client.RootPresenter.RootView#glass For automated test scripts, checking for "glass" overlay can be unnecessarily complex. This patch ensures that DOM <body> flag (data attribute) is set to reflect the current status of the application:  <body data-app-status="busy">  <body data-app-status="ready"> ... </body> Change-Id: I214493322774cf7727433c3a63d6ebfa7d3177cc Bug-Url: https://bugzilla.redhat.com/1150581 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/LockInteractionManager.java 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/47049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I214493322774cf7727433c3a63d6ebfa7d3177cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: core userportal webadmin: Typo fix
by tnisan＠redhat.com 07 Oct '15

07 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core userportal webadmin: Typo fix ...................................................................... core userportal webadmin: Typo fix While deleting cluster with host associated to it: 'Host Cluster contains one or more Hosts' -> 'Cluster contains one or more Hosts'. Change-Id: I9da686e10767ef0a9b6835a5d553c967bd52e9db Bug-Url: https://bugzilla.redhat.com/1149468 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9da686e10767ef0a9b6835a5d553c967bd52e9db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Disable sound card for ppc64
by ahadas＠redhat.com 07 Oct '15

07 Oct '15

Arik Hadas has submitted this change and it was merged. Change subject: core: Disable sound card for ppc64 ...................................................................... core: Disable sound card for ppc64 Added canDoAction checks to Add/Import/UpdateVM commands using new flag in os-info. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1253261 Change-Id: I848686fb88e9a2128c9308546f1e26711b48654d Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/conf/osinfo-defaults.properties 20 files changed, 171 insertions(+), 26 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46530 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I848686fb88e9a2128c9308546f1e26711b48654d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: Contextual alert messages
by vszocs＠redhat.com 07 Oct '15

07 Oct '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Contextual alert messages ...................................................................... webadmin,userportal: Contextual alert messages This patch introduces an infrastructure for displaying contextual alert messages in top-center part of oVirt's main (post-login) UI. Being part of gwt-common module, this infrastructure is usable from both WebAdmin and UserPortal applications through AlertManager class. Messages shown via AlertManager are visible only within the main section; any messages requested while in login section will be 'replayed' once the user logs in. Messages shown via AlertManager are one-line messages. If the message overflows its designated alert box area, a tooltip is added so that moving mouse over that area reveals the full message. This patch also implements an 'Uncaught exception' alert message triggered by global uncaught exception handler (see BaseApplicationInit.initUncaughtExceptionHandler). This is to inform users about UI-specific runtime errors that might break UI behavior. Screenshots: 'Danger' alert http://imgur.com/xcZhcaK 'Warning' alert http://imgur.com/Jgdl6vA 'Success' alert http://imgur.com/U9EGejw 'Info' alert http://imgur.com/llLVR9d 'Danger' alert, with tooltip http://imgur.com/CDpgics Change-Id: Ic0928ea873305bf7246f6b7c6ec255fa785ca1b3 Bug-Url: https://bugzilla.redhat.com/1215727 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/ElementTooltip.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/MainSectionPresenter.java M packaging/branding/ovirt.brand/branding.properties M packaging/branding/ovirt.brand/ovirt.css 10 files changed, 260 insertions(+), 11 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/46191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0928ea873305bf7246f6b7c6ec255fa785ca1b3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: DOM flag to guard user interaction
by vszocs＠redhat.com 07 Oct '15

07 Oct '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: DOM flag to guard user interaction ...................................................................... webadmin,userportal: DOM flag to guard user interaction Both WebAdmin and UserPortal are single-page web applications comprised of multiple places (UI states). Transitions between application's places are triggered either via UI interaction (e.g. clicking a main tab) or via manual URL change. Once the application starts transitioning from one place to another, user interaction should be avoided. For human users, this is accomplished via invisible "glass" overlay [1] that effectively blocks user-triggered DOM events (e.g. click) from reaching application's UI. [1] com.gwtplatform.mvp.client.RootPresenter.RootView#glass For automated test scripts, checking for "glass" overlay can be unnecessarily complex. This patch ensures that DOM <body> flag (data attribute) is set to reflect the current status of the application:  <body data-app-status="busy">  <body data-app-status="ready"> ... </body> Change-Id: I214493322774cf7727433c3a63d6ebfa7d3177cc Bug-Url: https://bugzilla.redhat.com/1150581 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/LockInteractionManager.java 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/46796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I214493322774cf7727433c3a63d6ebfa7d3177cc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0