November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: avoid NPE on add template when balloonEnabled is null
by masayag＠redhat.com 04 Nov '15

04 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: avoid NPE on add template when balloonEnabled is null ...................................................................... core: avoid NPE on add template when balloonEnabled is null When importing an image as template from Glance, 'balloonEnabled' is null. Consequently, an NPE is thrown on VmDeviceUtils -> copyVmDevices. Since 'balloonEnabled' been defaulted to null on I16adef671bc77e26f56657add59621a1aa9b1c4a, fixed by comparing to TRUE. Change-Id: Ie54212974b8deea6141d0a1b07dca393565e1dc0 Bug-Url: https://bugzilla.redhat.com/1275629 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Arik Hadas: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie54212974b8deea6141d0a1b07dca393565e1dc0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix adding Cinder snapshot after commiting previewed s...
by tnisan＠redhat.com 03 Nov '15

03 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix adding Cinder snapshot after commiting previewed snapshot. ...................................................................... core: Fix adding Cinder snapshot after commiting previewed snapshot. Fix the scenario when commiting a Cinder snapshot and after that adding a new Cinder snapshot. The problem is that the volume that is being updated is the basic one instead of the new active volume which has just been commited Change-Id: I9fa2e1f138bd68b0f09d7892c4ab5490f004942f Bug-Url: https://bugzilla.redhat.com/1277469 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/48013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fa2e1f138bd68b0f09d7892c4ab5490f004942f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: snapshots general panel - alter width
by derez＠redhat.com 03 Nov '15

03 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: snapshots general panel - alter width ...................................................................... webadmin: snapshots general panel - alter width VMs -> Snapshots -> General panel: * Spread label/value width to 3/9. * Column width set to 12. Change-Id: I9f0d0f92da8106a93f1bb9faceca9d44974d6a82 Bug-Url: https://bugzilla.redhat.com/1244757 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoGeneral.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/47993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f0d0f92da8106a93f1bb9faceca9d44974d6a82 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Change order of actions in remove data center flow
by tnisan＠redhat.com 03 Nov '15

03 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Change order of actions in remove data center flow ...................................................................... core: Change order of actions in remove data center flow When removing a data center the master storage domain was marked as a data domain and then the DestroyStoragePool command was sent to VDSM, since commit 2105394209362347655facec80b61c6b632932c9 a connect to storage pool is being sent as a part of the spm start flow, since the destroy command triggers the spm start after the master domain was marked as data the connect command could not find the master domain resulting in an error connecting to the pool and failure of the remove data center operation, the order of the actions was reversed to to avoid this fault Change-Id: I0e97919385e5ffc4db0d4d5b5a2ed78935b16bfd Bug-Url: https://bugzilla.redhat.com/1272110 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 1 file changed, 15 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e97919385e5ffc4db0d4d5b5a2ed78935b16bfd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change order of actions in remove data center flow
by tnisan＠redhat.com 03 Nov '15

03 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Change order of actions in remove data center flow ...................................................................... core: Change order of actions in remove data center flow When removing a data center the master storage domain was marked as a data domain and then the DestroyStoragePool command was sent to VDSM, since commit 2105394209362347655facec80b61c6b632932c9 a connect to storage pool is being sent as a part of the spm start flow, since the destroy command triggers the spm start after the master domain was marked as data the connect command could not find the master domain resulting in an error connecting to the pool and failure of the remove data center operation, the order of the actions was reversed to to avoid this fault Change-Id: I0e97919385e5ffc4db0d4d5b5a2ed78935b16bfd Bug-Url: https://bugzilla.redhat.com/1272110 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 1 file changed, 15 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e97919385e5ffc4db0d4d5b5a2ed78935b16bfd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Remove VM Pool even if VMs are running
by ahadas＠redhat.com 03 Nov '15

03 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: engine: Remove VM Pool even if VMs are running ...................................................................... engine: Remove VM Pool even if VMs are running Support VM Pool removal even in the case when some VMs from it are running. If some of the VMs in the pool are running, RemoveVmPoolCommand stops them and uses CommandCoordinator to wait until all VMs in the pool will be down. After that the pool with all VMs is removed as usually. Change-Id: I778362023e9f03b17e7306425e84245c0b9fcec0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1246886 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommandCallback.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 134 insertions(+), 24 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47654 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I778362023e9f03b17e7306425e84245c0b9fcec0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Fix adding cluster quota limit through REST
by tnisan＠redhat.com 03 Nov '15

03 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix adding cluster quota limit through REST ...................................................................... restapi: Fix adding cluster quota limit through REST Now it is possible to add cluster quota limit with unlimmited memory or vcpu through REST. Change-Id: Idd0748a529055cabea6e63c4df62a06da532a6a3 Bug-Url: https://bugzilla.redhat.com/1244519 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> (cherry picked from commit 9064434866515070f5f12e3b76eea85b0f668b5b) --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QuotaMapper.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/48011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd0748a529055cabea6e63c4df62a06da532a6a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix adding Cinder snapshot after commiting previewed s...
by mlipchuk＠redhat.com 03 Nov '15

03 Nov '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix adding Cinder snapshot after commiting previewed snapshot. ...................................................................... core: Fix adding Cinder snapshot after commiting previewed snapshot. Fix the scenario when commiting a Cinder snapshot and after that adding a new Cinder snapshot. The problem is that the volume that is being updated is the basic one instead of the new active volume which has just been commited Change-Id: I9fa2e1f138bd68b0f09d7892c4ab5490f004942f Bug-Url: https://bugzilla.redhat.com/1277469 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/47986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fa2e1f138bd68b0f09d7892c4ab5490f004942f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Windows 10 requires special CPU
by tnisan＠redhat.com 03 Nov '15

03 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Windows 10 requires special CPU ...................................................................... core: Windows 10 requires special CPU Because of BSOD: SYSTEM_THREAD_EXCEPTION_NOT_HANDLES, running guest OS Windows 10 is limited westmere+ CPUs This patch makes RunVmCommand to respect 'cpu.unsupported' entries in osinfo-defaults.properties file. Change-Id: Iaa53264e12d8f80562987ea5bfa131e91d5737b2 Bug-Url: https://bugzilla.redhat.com/1275810 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandlerRule.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerRule.java M packaging/conf/osinfo-defaults.properties 6 files changed, 151 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47797 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa53264e12d8f80562987ea5bfa131e91d5737b2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in gerrit-admin[master]: Fix to the warn_if_not_merged_to_previous_branch
by dcaroest＠redhat.com 03 Nov '15

03 Nov '15

David Caro has submitted this change and it was merged. Change subject: Fix to the warn_if_not_merged_to_previous_branch ...................................................................... Fix to the warn_if_not_merged_to_previous_branch Change-Id: I58ce7a20844177ed8456c1e243e0f2ec4d94b7a8 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/custom_hooks/patchset-created.warn_if_not_merged_to_previous_branch 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: David Caro: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58ce7a20844177ed8456c1e243e0f2ec4d94b7a8 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>

1 0