December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fix typo
by alkaplan＠redhat.com 20 Dec '15

20 Dec '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fix typo ...................................................................... webadmin: fix typo Fix typo: 'defAult' rather than 'deAfult'. Change-Id: Id314399e4b1d53f1b478f06ec70b364abf77663c Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/50467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id314399e4b1d53f1b478f06ec70b364abf77663c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix vnic type init in (New|Edit)VnicModel
by alkaplan＠redhat.com 20 Dec '15

20 Dec '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fix vnic type init in (New|Edit)VnicModel ...................................................................... webadmin: fix vnic type init in (New|Edit)VnicModel Fix vNIC type field initialization in (New|Edit)Vnic screens. The patch fixes the UI behaviour where a user can see the defaulti vnic type and then that is changed to the actual value. Change-Id: I01437e487274e18d53a326f48fb0f3ee14823261 Bug-Url: https://bugzilla.redhat.com/1290315 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java 2 files changed, 28 insertions(+), 10 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/50466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01437e487274e18d53a326f48fb0f3ee14823261 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: setup: engine_db_timekeeping fix for rename
by sradco＠redhat.com 20 Dec '15

20 Dec '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: engine_db_timekeeping fix for rename ...................................................................... packaging: setup: engine_db_timekeeping fix for rename engine_db_timekeeping was moved to engine_common some time ago. Import it from there. Bug-Url: https://bugzilla.redhat.com/1289983 Change-Id: I153d9e1dcc6927e66c22481b0a5fbf500b5b3f6a Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine-dwh/database.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/48813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I153d9e1dcc6927e66c22481b0a5fbf500b5b3f6a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Misleading audit log in ISO domain refresh
by tnisan＠redhat.com 20 Dec '15

20 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Misleading audit log in ISO domain refresh ...................................................................... engine: Misleading audit log in ISO domain refresh Add support for Unknown file types refresh in the ISO auto refresh flow. After change I85f93246f903c16e8fdf9054ab54b9d9a3184eed, an audit log about failing refresh of files of Unknow type appears in the auto refresh flow. Change-Id: Ibee1c17c975632a4e1adab200b540668cbee4a97 Bug-Url: https://bugzilla.redhat.com/1290097 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/50652 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibee1c17c975632a4e1adab200b540668cbee4a97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix method header in CommandBase
by emesika＠redhat.com 20 Dec '15

20 Dec '15

Eli Mesika has submitted this change and it was merged. Change subject: core: fix method header in CommandBase ...................................................................... core: fix method header in CommandBase Change-Id: Ifcacf57372f403726d11df1abbed1371a3e52216 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcacf57372f403726d11df1abbed1371a3e52216 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.5]: build: spec: re-added changelog entry for ovirt-engine-3.5.7
by tnisan＠redhat.com 20 Dec '15

20 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: build: spec: re-added changelog entry for ovirt-engine-3.5.7 ...................................................................... build: spec: re-added changelog entry for ovirt-engine-3.5.7 Change-Id: I7297093d86293a82d82f7449a5b34593bfb72ea1 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/50624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7297093d86293a82d82f7449a5b34593bfb72ea1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fixed generics QuotaPopupView
by tnisan＠redhat.com 20 Dec '15

20 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fixed generics QuotaPopupView ...................................................................... webadmin: Fixed generics QuotaPopupView Unchecked casting discovered by coverity (CID:1288218). Fix generic in eventlistener definition. Change-Id: Ib9c55d4b2a855261b9c12e9f9380a866e2a33e48 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/50434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9c55d4b2a855261b9c12e9f9380a866e2a33e48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: instance images not working well with templates
by tnisan＠redhat.com 20 Dec '15

20 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: instance images not working well with templates ...................................................................... webadmin: instance images not working well with templates Couple of problems: - some NPE vulnerabilities in finding disks which are not bootable anymore - disabled defining instance images when there are disks inherited from template Change-Id: I122c70bea2af733b7360baf9cf549e08a50a6e53 Bug-Url: https://bugzilla.redhat.com/1286224 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 82 insertions(+), 45 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/50646 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I122c70bea2af733b7360baf9cf549e08a50a6e53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: device: avoid warning about Graphics device
by ahadas＠redhat.com 20 Dec '15

20 Dec '15

Arik Hadas has submitted this change and it was merged. Change subject: core: device: avoid warning about Graphics device ...................................................................... core: device: avoid warning about Graphics device Libvirt gives no address to Graphics devices, on purpose, so better not to emit misleasing warning about them. Change-Id: Iafdc3566f625988e462e50cf1685bdc5330743bd Bug-Url: https://bugzilla.redhat.com/1273965 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafdc3566f625988e462e50cf1685bdc5330743bd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Format VmDeviceUtils.shouldOverrideSoundDevice()
by ahadas＠redhat.com 20 Dec '15

20 Dec '15

Arik Hadas has submitted this change and it was merged. Change subject: backend: Format VmDeviceUtils.shouldOverrideSoundDevice() ...................................................................... backend: Format VmDeviceUtils.shouldOverrideSoundDevice() Reformatted VmDeviceUtils.shouldOverrideSoundDevice() function to better fit VmDeviceUtils.java file conventions. Change-Id: I34caa2281285f456cddb5f95999b139513c08e41 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 4 files changed, 34 insertions(+), 22 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34caa2281285f456cddb5f95999b139513c08e41 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0