December 2015 - Engine-commits - oVirt List Archives

Change in jenkins[master]: master: add rubygem-libxml-ruby
by sbonazzo＠redhat.com 18 Dec '15

18 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: master: add rubygem-libxml-ruby ...................................................................... master: add rubygem-libxml-ruby Change-Id: Ife6d3f9669f9d7184c5db4cb28188075036b56bf Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml M jobs/confs/projects/rubygem-libxml-ruby/rubygem-libxml-ruby.yaml 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife6d3f9669f9d7184c5db4cb28188075036b56bf Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: spec: fix missing shadow-tools deps
by piotr.kliczewski＠gmail.com 18 Dec '15

18 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: spec: fix missing shadow-tools deps ...................................................................... packaging: spec: fix missing shadow-tools deps Added missing shadow-tools dep to packages creating users. Bug-Url: https://bugzilla.redhat.com/1292009 Change-Id: I40a422eea7164229657fa6e83f60d38872a99a1a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40a422eea7164229657fa6e83f60d38872a99a1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Default display type for PPC
by piotr.kliczewski＠gmail.com 18 Dec '15

18 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Default display type for PPC ...................................................................... restapi: Default display type for PPC Default display type and graphics is selected for PPC in REST Add VM based on osinfo-defaults.properties. Change-Id: I9d0606b47e267526b071d63883d0eca16ece65b8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1253263 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 25 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50702 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d0606b47e267526b071d63883d0eca16ece65b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix ISO Domain List refresh NPE
by piotr.kliczewski＠gmail.com 18 Dec '15

18 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix ISO Domain List refresh NPE ...................................................................... core: Fix ISO Domain List refresh NPE Fix ISO DomainList refresh NPE when no ISO domain is configured. Change-Id: Ied2b1490d8f66bb40f6f456d2d39bb05120e97d3 Bug-Url: https://bugzilla.redhat.com/1291202 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/50642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied2b1490d8f66bb40f6f456d2d39bb05120e97d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: update ovirt dependencies
by sbonazzo＠redhat.com 18 Dec '15

18 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: update ovirt dependencies ...................................................................... packaging: spec: update ovirt dependencies Change-Id: I29e6c44cb90de12c374053990deb2d617ced7b52 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29e6c44cb90de12c374053990deb2d617ced7b52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: fix missing shadow-tools deps
by sbonazzo＠redhat.com 18 Dec '15

18 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: fix missing shadow-tools deps ...................................................................... packaging: spec: fix missing shadow-tools deps Added missing shadow-tools dep to packages creating users. Bug-Url: https://bugzilla.redhat.com/1292009 Change-Id: I40a422eea7164229657fa6e83f60d38872a99a1a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40a422eea7164229657fa6e83f60d38872a99a1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: OvfWriter refactoring
by ahadas＠redhat.com 18 Dec '15

18 Dec '15

Arik Hadas has submitted this change and it was merged. Change subject: core: OvfWriter refactoring ...................................................................... core: OvfWriter refactoring Common code moved from OvfTemplateWriter and OvfVmWriter to the base OvfWriter class. Change-Id: I6c67eae7addb0164736677e24345ee3a388ee71d Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 3 files changed, 243 insertions(+), 418 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c67eae7addb0164736677e24345ee3a388ee71d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Removeing Ruby SDK from master nightly publisher
by bkorren＠redhat.com 18 Dec '15

18 Dec '15

Barak Korren has submitted this change and it was merged. Change subject: Removeing Ruby SDK from master nightly publisher ...................................................................... Removeing Ruby SDK from master nightly publisher Because Ruby SDK does nod produce artifacts yet Change-Id: I908c1dfd6bb79109e4f11d4cc189a67fb5f7033a Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50703 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I908c1dfd6bb79109e4f11d4cc189a67fb5f7033a Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: remove obsolete parentHasTasks
by piotr.kliczewski＠gmail.com 18 Dec '15

18 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: remove obsolete parentHasTasks ...................................................................... core: remove obsolete parentHasTasks Removed obsolete 'parentHasTasks' members/getters/setters/usages from parameters classes and commands. Change-Id: Ib83accd4ccc9ef0bc5485a0319186d0153d49a54 Bug-Url: https://bugzilla.redhat.com/1287771 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneCinderDisksParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesContainterParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveAllVmCinderDisksParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RestoreAllCinderSnapshotsParameters.java 11 files changed, 9 insertions(+), 44 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib83accd4ccc9ef0bc5485a0319186d0153d49a54 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal: NPE if the user does not have access to manageme...
by tjelinek＠redhat.com 18 Dec '15

18 Dec '15

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: NPE if the user does not have access to management network ...................................................................... userportal: NPE if the user does not have access to management network The code expected this situation in all cases except one - fixed by simple null check. Change-Id: I65f7e5bacc59b3adf68ad92ce62d89d91acf9fad Bug-Url: https://bugzilla.redhat.com/1286984 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ProfileBehavior.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/50653 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65f7e5bacc59b3adf68ad92ce62d89d91acf9fad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0