February 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Remove ReadOnlyResources interface
by juan.hernandez＠redhat.com 16 Feb '15

16 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove ReadOnlyResources interface ...................................................................... restapi: Remove ReadOnlyResources interface The presence of this interface induces errors in the RSDL generator. In particular the type of the disk snapshots collection is reported as "BaseResource" instead of "DiskSnapshot", which causes additional issues in the consumers of the RSDL, including the generators of the Python and Java SDKs. To avoid this issue this patch removes completely that interface. Change-Id: Id449ea7bb88f7acae0a3b536aa2d45e1ddbeb48e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskSnapshotResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskSnapshotsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostNumaNodeResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ImageResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ImagesResource.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ReadOnlyResource.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ReadOnlyResources.java 7 files changed, 22 insertions(+), 82 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/37755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id449ea7bb88f7acae0a3b536aa2d45e1ddbeb48e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Refactoring in accordance with vdsm patches
by kmayilsa＠redhat.com 16 Feb '15

16 Feb '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine : Refactoring in accordance with vdsm patches ...................................................................... engine : Refactoring in accordance with vdsm patches This patch does the following : 1. The geo-rep engine patches were merged before the corresponding patches and hence at merge time, contained the exception codes and api names as the vdsm exposed at that time. Now, that the vdsm patches have been merged, this patch refactors the engine side accordingly. 2. StartGlusterVolumeGeoRepCommand was modifying the status of geo-rep session in db on success. But, it is observed that the session on gluster side takes a while to change state to ACTIVE untill then it stays as INITIALISING and hence this patch removes the state change code and allows the geo-rep sync job to detect state change. Change-Id: I702d6c62f576cf2a49437fcf37155290d8580588 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepSessionStatus.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/PauseGlusterVolumeGeoRepSessionVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/ResumeGeoRepSessionVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StartGlusterVolumeGeoRepVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 17 files changed, 59 insertions(+), 48 deletions(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I702d6c62f576cf2a49437fcf37155290d8580588 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Sysprep is sending apostrophes with sysprep name
by tnisan＠redhat.com 15 Feb '15

15 Feb '15

Tal Nisan has submitted this change and it was merged. Change subject: Sysprep is sending apostrophes with sysprep name ...................................................................... Sysprep is sending apostrophes with sysprep name No need for apostrophes in sysprep file name. The apostrophes causes vdsm to fail to create the sysprep file. Bug-Url: https://bugzilla.redhat.com/1192495 Change-Id: I6ef837ab634d75b80d5703cd103f611f2d1007d0 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ef837ab634d75b80d5703cd103f611f2d1007d0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Limitation addition for downgrading DC's compatible ve...
by tnisan＠redhat.com 15 Feb '15

15 Feb '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Limitation addition for downgrading DC's compatible version. ...................................................................... core: Limitation addition for downgrading DC's compatible version. Downgrading a DC's compatibility version can cause in some cases a downgrade of the attached storage domains' format which is not supported. Also, it can be downgraded to versions which does not necessarily support some of the DC's attached domains. Hence a limitation was added in this command's CDA. Change-Id: Ib97488c705a32fe73b390ef226b1ad19a3784b76 Bug-Url: https://bugzilla.redhat.com/1121556 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 175 insertions(+), 27 deletions(-) Approvals: Amit Aviram: Verified Allon Mureinik: Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib97488c705a32fe73b390ef226b1ad19a3784b76 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Sysprep is sending apostrophes with sysprep name
by shavivi＠redhat.com 15 Feb '15

15 Feb '15

Shahar Havivi has submitted this change and it was merged. Change subject: Sysprep is sending apostrophes with sysprep name ...................................................................... Sysprep is sending apostrophes with sysprep name No need for apostrophes in sysprep file name. The apostrophes causes vdsm to fail to create the sysprep file. Bug-Url: https://bugzilla.redhat.com/1192495 Change-Id: I6ef837ab634d75b80d5703cd103f611f2d1007d0 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ef837ab634d75b80d5703cd103f611f2d1007d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Avoid potential NPE reported by Coverity
by masayag＠redhat.com 15 Feb '15

15 Feb '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid potential NPE reported by Coverity ...................................................................... engine: Avoid potential NPE reported by Coverity >>> CID 1269335: Null pointer dereferences (NULL_RETURNS) >>> Calling a method on null object "contentHosts". Change-Id: Ia100de3d4ec5ed0eefe7c45372c9f3fe1300b05d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/37765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia100de3d4ec5ed0eefe7c45372c9f3fe1300b05d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix import from glance storage allocation check
by amureini＠redhat.com 14 Feb '15

14 Feb '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix import from glance storage allocation check ...................................................................... core: Fix import from glance storage allocation check The storage allocation check uses the DiskImage.getActualDiskWithSnapshotsSizeInBytes() method to evaluate the disk's size according to it's snapshots' sizes. In this case, the disk image is not created with an active image (which is considered as a snapshot for the aforementioned method), which resulted in a disk size of 0. This patch adds the image to the snapshots. Change-Id: I02d1cfb30c64a7d7b7b4c0386b134583faee190d Bug-Url: https://bugzilla.redhat.com/1178012 Bug-Url: https://bugzilla.redhat.com/1053750 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/37505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02d1cfb30c64a7d7b7b4c0386b134583faee190d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Some fixes for the standard jobs
by dcaroest＠redhat.com 13 Feb '15

13 Feb '15

David Caro has submitted this change and it was merged. Change subject: Some fixes for the standard jobs ...................................................................... Some fixes for the standard jobs * Corrected log generation * Added proxy config * Fixed artifacts archiving for check jobs Change-Id: I701f0c178a1820004c7e1e1567fc0e6a1231d4a7 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/standard_build_artifacts.sh M jobs/confs/shell-scripts/standard_check_merged.sh M jobs/confs/shell-scripts/standard_check_patch.sh 3 files changed, 15 insertions(+), 6 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I701f0c178a1820004c7e1e1567fc0e6a1231d4a7 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: vm: conf: fix answer file BOOT selection
by sbonazzo＠redhat.com 13 Feb '15

13 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: vm: conf: fix answer file BOOT selection ...................................................................... vm: conf: fix answer file BOOT selection revert partially I0f17abcc4ec83a69832bdb5a986136831504da2c removing a regression which caused the answer file to store OVF install instead of CD-ROM install. Fixes the reboot part by ejecting the CD-ROM if present and basing the boot order on the boot order used also in the template file. Change-Id: I9626bf3267d9bd2406db54a64250fa29c06f7f95 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/mixins.py M src/plugins/ovirt-hosted-engine-setup/engine/os_install.py 2 files changed, 13 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9626bf3267d9bd2406db54a64250fa29c06f7f95 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: codegen: Remove trailing whitespace from templates
by juan.hernandez＠redhat.com 13 Feb '15

13 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Remove trailing whitespace from templates ...................................................................... codegen: Remove trailing whitespace from templates This whitespace isn't relevant, but it forces some extra logic inside the generator, just to remove it. Change-Id: I4e0d6530fcc67cee47169fc2b68d9a004835bce0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/SubCollectionTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/UpdateMethodTemplate 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e0d6530fcc67cee47169fc2b68d9a004835bce0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0