February 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Remove unused events from HostInterface
by lvernia＠redhat.com 11 Feb '15

11 Feb '15

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Remove unused events from HostInterface ...................................................................... webadmin: Remove unused events from HostInterface No relevant class was listening on these events, so this should be dead code. Change-Id: Ia7208d82a6a02540f4d258300c6545dd888d7fdb Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterface.java 1 file changed, 9 insertions(+), 68 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/36465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7208d82a6a02540f4d258300c6545dd888d7fdb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Clean up interface cloning code
by lvernia＠redhat.com 11 Feb '15

11 Feb '15

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Clean up interface cloning code ...................................................................... webadmin: Clean up interface cloning code VdsNetworkInterface entities didn't seem to be cloned at all so that code was removed, while the code cloning VmNetworkInterface was modified to be called from copy constructors. Change-Id: I1cfb4517ea2deb7fc6d5b49587c16b1d34026552 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkStatistics.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java 5 files changed, 34 insertions(+), 58 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cfb4517ea2deb7fc6d5b49587c16b1d34026552 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extract common code to update interface statistics
by lvernia＠redhat.com 11 Feb '15

11 Feb '15

Lior Vernia has submitted this change and it was merged. Change subject: engine: Extract common code to update interface statistics ...................................................................... engine: Extract common code to update interface statistics Code was duplicated to perform the same thing for VdsNetworkInterface and VmNetworkInterface, now it's re-used. Change-Id: I195e365ae4c5898c3cb5ffb1f090bc0e62470186 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 14 insertions(+), 18 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I195e365ae4c5898c3cb5ffb1f090bc0e62470186 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Modified statistics removal DAO test
by lvernia＠redhat.com 11 Feb '15

11 Feb '15

Lior Vernia has submitted this change and it was merged. Change subject: core: Modified statistics removal DAO test ...................................................................... core: Modified statistics removal DAO test The test's description didn't match what it was actually testing (in fact, I couldn't figure out what it was indeed testing). Changed the test to make sense. Change-Id: I79979f22ad17db9e12d403774cd84d77338a43ab Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java 1 file changed, 7 insertions(+), 17 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/36462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79979f22ad17db9e12d403774cd84d77338a43ab Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Extract common NetworkStatistics DAO code
by lvernia＠redhat.com 11 Feb '15

11 Feb '15

Lior Vernia has submitted this change and it was merged. Change subject: core: Extract common NetworkStatistics DAO code ...................................................................... core: Extract common NetworkStatistics DAO code The same code was duplicated all over different DAOs (for host interfaces, VM interfaces, VM interface statistics). It's now extracted and re-used. Change-Id: Ifc60a5b80d7ef042b1b81200bb8542081b42acc0 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/CustomMapSqlParameterSource.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkStatisticsDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkStatisticsDaoDbFacadeImpl.java 5 files changed, 114 insertions(+), 54 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc60a5b80d7ef042b1b81200bb8542081b42acc0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Remove unwanted query call
by tjelinek＠redhat.com 11 Feb '15

11 Feb '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Remove unwanted query call ...................................................................... frontend: Remove unwanted query call This patch removes calling query for soundcard in InstanceTypeManager. The query makes no sense and its presence is probably a copy-paste error. Change-Id: I8d03d789b66f6b95f475df3210b2db0f8094a1b5 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 1 file changed, 11 insertions(+), 20 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/37563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d03d789b66f6b95f475df3210b2db0f8094a1b5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Improve performance of GetAllSnapshotsByStorageDomainId
by emesika＠redhat.com 11 Feb '15

11 Feb '15

Eli Mesika has submitted this change and it was merged. Change subject: core: Improve performance of GetAllSnapshotsByStorageDomainId ...................................................................... core: Improve performance of GetAllSnapshotsByStorageDomainId GetAllSnapshotsByStorageDomainId returns a huge number of duplicate rows. Under load this creates a memory issue. This patch solves this. Change-Id: I87207b3c284c161b0d0dfa72d21fb47593d010b3 Bug-Url: https://bugzilla.redhat.com/1190471 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M packaging/dbscripts/snapshots_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Roy Golan: Looks good to me, but someone else must approve Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/37645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87207b3c284c161b0d0dfa72d21fb47593d010b3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Adding the proxy to the mock config
by dcaroest＠redhat.com 10 Feb '15

10 Feb '15

David Caro has submitted this change and it was merged. Change subject: Adding the proxy to the mock config ...................................................................... Adding the proxy to the mock config Added the extra proxied mock confiogurations and an extra option to mock_genconfig to use them if the proxy is responsive, so in case the proxy is down it will not use it. The proxy is extracted from the mock config Also improved the log colletion for non-build mock executions Change-Id: I62d8a8f8016b02e68ba56274cbc60cf74d3a4835 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/build_mock_srcrpm.sh M jobs/confs/shell-scripts/build_mock_srcrpm_releng.sh M jobs/confs/shell-scripts/mock_build_onlyrpm.sh M jobs/confs/shell-scripts/mock_cleanup.sh M jobs/confs/shell-scripts/mock_install.sh M jobs/confs/shell-scripts/mock_setup.sh A mock_configs/epel-6-x86_64_proxied.cfg A mock_configs/epel-7-x86_64_proxied.cfg A mock_configs/fedora-20-x86_64_proxied.cfg A mock_configs/fedora-21-x86_64_proxied.cfg M mock_configs/mock_genconfig 11 files changed, 314 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62d8a8f8016b02e68ba56274cbc60cf74d3a4835 Gerrit-PatchSet: 9 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Max Kovgan <kovganm(a)gmail.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: remove EXTENSION definition from create table
by emesika＠redhat.com 10 Feb '15

10 Feb '15

Eli Mesika has submitted this change and it was merged. Change subject: db: remove EXTENSION definition from create table ...................................................................... db: remove EXTENSION definition from create table This was generated automatically from pg_dump and cause the engine-setup to report an error and exit Also fixed a '\x' added to a generated user id Change-Id: I6211c5818eb3afb1c2b5b7b286f0ca031a40d2db Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/create_tables.sql M packaging/dbscripts/data/00100_insert_users.sql 2 files changed, 1 insertion(+), 10 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Dima Kuznetsov: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6211c5818eb3afb1c2b5b7b286f0ca031a40d2db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[master]: centos7: load dummy module at boot
by sbonazzo＠redhat.com 10 Feb '15

10 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: centos7: load dummy module at boot ...................................................................... centos7: load dummy module at boot load dummy module at boot. It was loaded by default in el6. Change-Id: I906cb1135bf3507e4d5e7123fd34924388cc29b9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I906cb1135bf3507e4d5e7123fd34924388cc29b9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0