February 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: replace NetworkUtils.getDefaultManagementNetwork calls
by alkaplan＠redhat.com 09 Feb '15

09 Feb '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: replace NetworkUtils.getDefaultManagementNetwork calls ...................................................................... engine: replace NetworkUtils.getDefaultManagementNetwork calls Replace NetworkUtils.getDefaultManagementNetwork calls with calls to appropriate ManagementNetworkUtil methods. Change-Id: Ib0bd50e16b577b3f31765011d9b16501149c2479 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 10 files changed, 92 insertions(+), 59 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/34243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0bd50e16b577b3f31765011d9b16501149c2479 Gerrit-PatchSet: 54 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: remove NetworkUtils.isManagementNetwork methods
by alkaplan＠redhat.com 09 Feb '15

09 Feb '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: remove NetworkUtils.isManagementNetwork methods ...................................................................... engine: remove NetworkUtils.isManagementNetwork methods Remove NetworkUtils.isManagementNetwork methods. Change-Id: I12fbe3fbf6c0a50e408770d04e776f501957dceb Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java 2 files changed, 9 insertions(+), 75 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/34192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12fbe3fbf6c0a50e408770d04e776f501957dceb Gerrit-PatchSet: 52 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: make SetupNetworksVDSCommand use ManagementNetworkUtil
by alkaplan＠redhat.com 09 Feb '15

09 Feb '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: make SetupNetworksVDSCommand use ManagementNetworkUtil ...................................................................... engine: make SetupNetworksVDSCommand use ManagementNetworkUtil Make SetupNetworksVDSCommand use ManagementNetworkUtil instead of NetworkUtils. Change-Id: Iaea8e36d556243836a124fa410f42b712f509ecd Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/34190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaea8e36d556243836a124fa410f42b712f509ecd Gerrit-PatchSet: 51 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: change HostNetworkTopologyPersister to use Managemen...
by alkaplan＠redhat.com 09 Feb '15

09 Feb '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: change HostNetworkTopologyPersister to use ManagementNetworkUtil ...................................................................... engine: change HostNetworkTopologyPersister to use ManagementNetworkUtil Add HostNetworkTopologyPersisterImpl, the implementation of HostNetworkTopologyPersister. The impl class defined as a @Singleton bean so its instance could be obtained through DI framework. The new impl uses ManagementNetworkUtil instead of NetworkUtils.isManagementNetwork. Change-Id: I1dfc34a6789f9ec06c1760c1417df801886bf166 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java 4 files changed, 75 insertions(+), 34 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/34188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dfc34a6789f9ec06c1760c1417df801886bf166 Gerrit-PatchSet: 51 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: move Injector to vdsbroker
by alkaplan＠redhat.com 09 Feb '15

09 Feb '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: move Injector to vdsbroker ...................................................................... engine: move Injector to vdsbroker 1. add CDI functionality to vdsbroker 2. move Injector to vdsbroker Change-Id: I0009744272e5eef1ca505d4d5fd8030058c40f33 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/di/Injector.java 9 files changed, 9 insertions(+), 11 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/34138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0009744272e5eef1ca505d4d5fd8030058c40f33 Gerrit-PatchSet: 49 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Move ManagementNetworkUtil to vdsbroker module
by alkaplan＠redhat.com 09 Feb '15

09 Feb '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Move ManagementNetworkUtil to vdsbroker module ...................................................................... engine: Move ManagementNetworkUtil to vdsbroker module Move ManagementNetworkUtil to vdsbroker module in order to be able to use it there. Note: That is planned to be a temporary solution until it'll be possible to move the interface to a more suitable module (extract business logic from vdsbroker). Change-Id: Ic24a70445e672ca88ce425fb89702cf0360dcd67 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtil.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/33902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic24a70445e672ca88ce425fb89702cf0360dcd67 Gerrit-PatchSet: 54 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: update NetworkValidator logic
by alkaplan＠redhat.com 09 Feb '15

09 Feb '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: update NetworkValidator logic ...................................................................... engine: update NetworkValidator logic Update NetworkValidator and DetachNetworkValidator logic to use ManagementNetworkUtil in order to determine whether a Network is management or not. Change-Id: I2b9d4643c28c8ca90494ed774942a9dfe50c5e67 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java 2 files changed, 41 insertions(+), 8 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/33823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b9d4643c28c8ca90494ed774942a9dfe50c5e67 Gerrit-PatchSet: 53 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Update UpdateStoragePoolCommand logic
by alkaplan＠redhat.com 09 Feb '15

09 Feb '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Update UpdateStoragePoolCommand logic ...................................................................... engine: Update UpdateStoragePoolCommand logic Replace the call to legacy NetworkUtils.isManagementNetwork by the call to ManagementNetworkUtil class. Change-Id: Iaf3a156bd711f0f044d256bab8c514c33ca66aa2 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java 2 files changed, 71 insertions(+), 39 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/33822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf3a156bd711f0f044d256bab8c514c33ca66aa2 Gerrit-PatchSet: 52 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Update AddBondCommand logic
by alkaplan＠redhat.com 09 Feb '15

09 Feb '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Update AddBondCommand logic ...................................................................... engine: Update AddBondCommand logic Replace the call to legacy NetworkUtils.isManagementNetwork by the call to ManagementNetworkUtil class. Change-Id: I4e07bbaae24559d5df752c065aca6e8d841ba225 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/33821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e07bbaae24559d5df752c065aca6e8d841ba225 Gerrit-PatchSet: 51 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: update RemoveNetworkParametersBuilder logic
by alkaplan＠redhat.com 09 Feb '15

09 Feb '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: update RemoveNetworkParametersBuilder logic ...................................................................... engine: update RemoveNetworkParametersBuilder logic Remove usage of legacy NetworkUtils.isManagementNetwork with the new ManagementNetworkUtil one in RemoveNetworkParametersBuilder. Change-Id: I519b9d4db919f143a36c3b15fbaa21e8380311f5 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 3 files changed, 28 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/33820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I519b9d4db919f143a36c3b15fbaa21e8380311f5 Gerrit-PatchSet: 51 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0