February 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: setup: checking if command_entities table exist
by oourfali＠redhat.com 25 Feb '15

25 Feb '15

Oved Ourfali has submitted this change and it was merged. Change subject: setup: checking if command_entities table exist ...................................................................... setup: checking if command_entities table exist oVirt 3.5 has introduced command_entities table. In addition to adding some new functions related to this table to the task clenaer utility, some functions got changed, but as it is run during setup and might run on top of version which preceeds oVirt 3.5, it should be checked in the relevant SPs that the table exists. Bug-Url: https://bugzilla.redhat.com/1161012 Bug-Url: https://bugzilla.redhat.com/1164771 Change-Id: I3152c4d3f6e02915053ada5019abeea7cb356751 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/setup/dbutils/taskcleaner.sh M packaging/setup/dbutils/taskcleaner_sp.sql A packaging/setup/dbutils/taskcleaner_sp_3_5.sql 3 files changed, 107 insertions(+), 81 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3152c4d3f6e02915053ada5019abeea7cb356751 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 25 Feb '15

25 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 7984e91. Change-Id: Ieabdb1749dd2d894743e48b04ca687f216a91d0f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M generator/src/main/resources/api.xsd M generator/src/main/resources/rsdl.xml M setup.py M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 7 files changed, 11,537 insertions(+), 2,774 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieabdb1749dd2d894743e48b04ca687f216a91d0f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Avoid calculation of singulars and plurals
by juan.hernandez＠redhat.com 25 Feb '15

25 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Avoid calculation of singulars and plurals ...................................................................... codegen: Avoid calculation of singulars and plurals Currently the code generator assumes that there is a semantic relationship between the names of XML schema complex type that represent collections and entities: the name of the entity is the plural of the name of the collection. To handle this it uses rules to calculate the plurals from singulars, and the other way around. But for some collections and entities simple calculation of plural and singular (adding or removing a trailing "s") doesn't work. For example: SchedulingPolicies -> SchedulingPolicy Another example is the following, which has been introduced in the server side: KatelloErrata -> KatelloErratum The code generator also assumes that the names of the XML schema complex types match the URL segments. This doesn't always work. For example, with the recent addition of external providers to the server side there are URL segments like this one: /externalhostproviders/{externalhostprovider:id}/hosts The XML complex type corresponding to this "hosts" collection is "ExternalHost", and not "Host" as the existing rules expect. We have been handling these situations adding exceptions in the code of the generator, and implementing more robust rules for calculations of plurals and singulars, but this doesn't scale well, and it is prone to unexcpected failures. To avoid these issues in a more systematic way this patch modifies the generator so that it will extract the required information from the XML schema and the RSDL instead of making calculations. The core of this change is the introduction of a tree data structure that stores the links extracted from the RSDL, so that it is easy to find from one node its children and parents. This data structure is used to decide if a location corresponds to a collection, entity or action, and combined with querying the XML schema to extract the type names. Change-Id: I7b27061d436e524683dbed81c5521eed51e8c2f0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/Main.java D generator/src/main/java/org/ovirt/engine/sdk/generator/common/AbstractCodegen.java A generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/Action.java A generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/BrokerRules.java M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/CodeHolder.java M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/Collection.java M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/CollectionExceptions.java M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/Documentation.java A generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/Location.java A generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/LocationRules.java M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/Resource.java M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/RsdlCodegen.java A generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/SchemaRules.java M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/SubCollection.java M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/SubResource.java M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionAddTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetDisksTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetNotSearchableTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetSearchableTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionListNotSearchableTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionListSearchableTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/ResourceActionTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/ResourceTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/ResourceUpdateTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubCollectionAddTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubCollectionGetTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubCollectionListTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubCollectionListWithParamsTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubCollectionTemplate D generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceActionTemplate D generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceActionTemplate.java D generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceCollectionActionTemplate D generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceCollectionActionTemplate.java M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceDeleteWithUrlParamsAndBodyTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceDeleteWithUrlParamsTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceUpdateTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/utils/CollectionsUtils.java D generator/src/main/java/org/ovirt/engine/sdk/generator/utils/StringUtils.java A generator/src/main/java/org/ovirt/engine/sdk/generator/utils/Tree.java D generator/src/main/java/org/ovirt/engine/sdk/generator/utils/TypeUtils.java M generator/src/main/java/org/ovirt/engine/sdk/generator/utils/UrlUtils.java M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/XsdCodegen.java M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/XsdData.java 44 files changed, 1,201 insertions(+), 1,423 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b27061d436e524683dbed81c5521eed51e8c2f0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Manually fix brick parameter name
by juan.hernandez＠redhat.com 25 Feb '15

25 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Manually fix brick parameter name ...................................................................... sdk: Manually fix brick parameter name This name of the parameter used to add a Gluster brick is currently "glusterbricks", and that is wrong, it should be "brick". This happens because the current version of the code generator calculates types using plural to singular (and the other way around) rules, instead of getting the exact information from the XML schema. This issue will be properly fixed in the next version of the generator. This patch fixes it manually to reduce the differences on the generated code. Change-Id: I090119f6d3972970ecf81756139f57a21ebd4769 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I090119f6d3972970ecf81756139f57a21ebd4769 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Manually fix host storage broker class
by juan.hernandez＠redhat.com 25 Feb '15

25 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Manually fix host storage broker class ...................................................................... sdk: Manually fix host storage broker class This class extends the "HostStorage" parameter class, and that is wrong, it should extend "Storage". This happens because the current version of the code generator calculates types using plural to singular (and the other way around) rules, instead of getting the exact information from the XML schema. This issue will be properly fixed in the next version of the generator. This patch fixes it manually to reduce the differences on the generated code. Change-Id: I8cc05bb01ce2267fb4ee1bd5ee77ace1e2f4d6f5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cc05bb01ce2267fb4ee1bd5ee77ace1e2f4d6f5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Manually fix VM NUMA node broker class
by juan.hernandez＠redhat.com 25 Feb '15

25 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Manually fix VM NUMA node broker class ...................................................................... sdk: Manually fix VM NUMA node broker class This class extends the "NumaNode" parameter class, and that is wrong, it should extend "VirtualNumaNode". This happens because the current version of the code generator calculates types using plural to singular (and the other way around) rules, instead of getting the exact information from the XML schema. This issue will be properly fixed in the next version of the generator. This patch fixes it manually to reduce the differences on the generated code. Change-Id: I35f5c82a7b3d592f9570f500b8684eeda2494203 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35f5c82a7b3d592f9570f500b8684eeda2494203 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Manually fix type of disk snapshots
by juan.hernandez＠redhat.com 25 Feb '15

25 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Manually fix type of disk snapshots ...................................................................... sdk: Manually fix type of disk snapshots Currently the RSDL generator of the engine doesn't report correctly the type of disk snapshots collection, it reports "BaseResource" instead of "DiskSnapshot". The current version of the generator doesn't have a problem with this, because it doesn't use this information (it calculates it from the collection type, using plural to singular rules). But the new version of the generator will stick to the reported information, and will generate wrong code. To avoid this issue this patch fixes the type manually. The issue will be fixed in the engine by the following change: http://gerrit.ovirt.org/37755 Change-Id: I1e2d046c9f10f5bd7576671ec29b31e1a2799ce5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/resources/rsdl.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e2d046c9f10f5bd7576671ec29b31e1a2799ce5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Manually remove action broker
by juan.hernandez＠redhat.com 25 Feb '15

25 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Manually remove action broker ...................................................................... sdk: Manually remove action broker The current code generator creates a broker class for the "Action" schema type. This doesn't make sense, as actions are represented by methods not by classes. This patch manually remove that class in order to reduce diffs with the code generated by the next version of the code generator. Change-Id: If02d79178a0f15c4d051af36aa331c6dbb7455c0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py 1 file changed, 0 insertions(+), 21 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If02d79178a0f15c4d051af36aa331c6dbb7455c0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Manually fix scheduling policy naming issue
by juan.hernandez＠redhat.com 25 Feb '15

25 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Manually fix scheduling policy naming issue ...................................................................... sdk: Manually fix scheduling policy naming issue The code generator assumes that the name of the URL segment for scheduling policies is "schedulingpolicy", but in fact it is "schedulingpolicie". This is a bug of the server side. This patch fixes it manually to reduce the diffs with the code generated with the next version of the code generator. Change-Id: I8e044c1831191811af13fd49641bc5b828222d88 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e044c1831191811af13fd49641bc5b828222d88 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Warning when creating NFS in POSIX SD
by tnisan＠redhat.com 25 Feb '15

25 Feb '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Warning when creating NFS in POSIX SD ...................................................................... engine: Warning when creating NFS in POSIX SD If the user tries to create a POSIX storage domain with NFS as VFS type, the following message will be displayed: "Adding an NFS domain as POSIX is highly discouraged, please create an NFS domain for best optimizations" Change-Id: I7ce3189b02ffa4cb20dffb31aebe420fe187a785 Bug-Url: https://bugzilla.redhat.com/1109055 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml 3 files changed, 34 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Fred Rolland: Verified -- To view, visit https://gerrit.ovirt.org/37610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ce3189b02ffa4cb20dffb31aebe420fe187a785 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0