February 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: setup: Splitting taskcleaner_sp into two scripts
by wallaroo1976＠gmail.com 25 Feb '15

25 Feb '15

Yair Zaslavsky has submitted this change and it was merged. Change subject: setup: Splitting taskcleaner_sp into two scripts ...................................................................... setup: Splitting taskcleaner_sp into two scripts Change-Id: I2605484ca375ccd319d62cc63ace100cf2ca2235 Bug-Url: https://bugzilla.redhat.com/1161012 Bug-Url: https://bugzilla.redhat.com/1164771 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/setup/dbutils/taskcleaner.sh M packaging/setup/dbutils/taskcleaner_sp.sql A packaging/setup/dbutils/taskcleaner_sp_3_5.sql 3 files changed, 79 insertions(+), 75 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38147 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2605484ca375ccd319d62cc63ace100cf2ca2235 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa : process initialization errors
by wallaroo1976＠gmail.com 25 Feb '15

25 Feb '15

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa : process initialization errors ...................................................................... aaa : process initialization errors During initialization we should print and ignore exceptions from the built-in providers. At EngineExtensionsLoader each time load() or initialize() is called, there should be a try/catch to show potentials errors. same for the entry engineInitialize(). Change-Id: I63265947ff066857db19d2534628d46f01b9f2e9 Bug-Url: https://bugzilla.redhat.com/1194410 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java 2 files changed, 53 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63265947ff066857db19d2534628d46f01b9f2e9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: call postConstruct in CloneVm
by rgolan＠redhat.com 25 Feb '15

25 Feb '15

Roy Golan has submitted this change and it was merged. Change subject: core: call postConstruct in CloneVm ...................................................................... core: call postConstruct in CloneVm after the move to postConstruct in parent AddVm, the call to init the command was missing. this fixes the broken clone vm with disks Change-Id: I6b4f63d45c5cb244c773fbbd4c06e698e439b81d Bug-Url: https://bugzilla.redhat.com/1195152 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b4f63d45c5cb244c773fbbd4c06e698e439b81d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5.2]: core: Fix skipped status in fencing
by oourfali＠redhat.com 24 Feb '15

24 Feb '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix skipped status in fencing ...................................................................... core: Fix skipped status in fencing Fixes the distinction between two types of skipping fencing operation: 1. Skipped due to status - on/off operation is skipped because host power status is already on/off 2. Skipped due to fencing policy - on/off operation is skipped becuase host is non responsive but it's still connected to storage Change-Id: Ia0c2a76d10a7e501ed5a53b323acb251c05c06fb Bug-Url: https://bugzilla.redhat.com/1192596 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceStatusReturnValue.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java 3 files changed, 11 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0c2a76d10a7e501ed5a53b323acb251c05c06fb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: Added release notes
by sradco＠redhat.com 24 Feb '15

24 Feb '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: Added release notes ...................................................................... packaging: Added release notes Change-Id: I401084bdea33a5cbfc6fe2c6969d9e992fcbf171 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I401084bdea33a5cbfc6fe2c6969d9e992fcbf171 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: get 32bit max mem config with default version
by ofrenkel＠redhat.com 24 Feb '15

24 Feb '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: get 32bit max mem config with default version ...................................................................... core: get 32bit max mem config with default version currently getting the 32bit max memory config is done with the vm cluster version, but the 32bit config has 'general' value and not per-version, making this be not editable by users. changing the call to use 'general' and not version-specific for 32bit. Change-Id: I2c4f4921551ade089c3fb3b28352c4a7ab557b87 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 2 files changed, 9 insertions(+), 5 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c4f4921551ade089c3fb3b28352c4a7ab557b87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: description marked invalid in search
by awels＠redhat.com 24 Feb '15

24 Feb '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: description marked invalid in search ...................................................................... webadmin: description marked invalid in search - The valid field description was marked invalid in the search suggestion dropdown due to it containing the invalid word 'desc' (descending) which is no longer valid. Added an exception for description to be a valid suggestion. Change-Id: I83e933ad77177a4532f5bef086312f12f15545b5 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83e933ad77177a4532f5bef086312f12f15545b5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: updated jasper war pro addition patches
by sradco＠redhat.com 24 Feb '15

24 Feb '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: updated jasper war pro addition patches ...................................................................... packaging: updated jasper war pro addition patches updated jasper war patches for pro addition. Change-Id: I2a3c42a8fe37d15920a3e142c4e86a7ed6160442 Bug-Url:https://bugzilla.redhat.com/1182125 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/jasper-war-patches/pro/100_001_meta-inf_add-postgresql-jdbc-module-dependency.patch M packaging/jasper-war-patches/pro/200_006_web-inf_remove_query_manipulator_override.patch 2 files changed, 11 insertions(+), 12 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a3c42a8fe37d15920a3e142c4e86a7ed6160442 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: sdk: Code generated with Java 8
by juan.hernandez＠redhat.com 24 Feb '15

24 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Code generated with Java 8 ...................................................................... sdk: Code generated with Java 8 A previous change introduced the use of Java 8 for both building and running the code generator. As a result some of the generated source files generated by the "xjc" compiler are sligthly different, probably because the "xjc" compiler iterates hash maps, which have different order in Java 7 and Java 8. This change is the result of running the code generator with Java 8, so that in the future these differences won't get in the middle while regenerating the SDK. The changes don't affect the semantics of the SDK, just the order of some fields and methods in the code generated by the "xjc" tool. Change-Id: Ia3d179cd8a4dad4c200e3e527e9ae99562bcac01 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/src/main/java/org/ovirt/engine/sdk/entities/BaseDevice.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/BaseDevices.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/BaseResource.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/BaseResources.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/EntityProfileDetail.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/VmBase.java 7 files changed, 5,127 insertions(+), 5,127 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3d179cd8a4dad4c200e3e527e9ae99562bcac01 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: Fix PEP8 violaions in engine-setup
by sbonazzo＠redhat.com 24 Feb '15

24 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Fix PEP8 violaions in engine-setup ...................................................................... packaging: Fix PEP8 violaions in engine-setup Fixed indentation and other PEP8 problems that preventend the engine to compile. Change-Id: If5a4ae53eadbf1d69cc474280bef6d15bde70fab Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/dialog/titles.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/storage.py 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/38134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5a4ae53eadbf1d69cc474280bef6d15bde70fab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0